Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2848552lqt; Tue, 23 Apr 2024 03:38:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUICZaLWye3OlFz4tBfKegvPZsriK0mO6EnFpy+q7qq8QmFDIJqyu+znt0cYfW+ZAlmHdqKHOTib/pl8KJ+Vmn13cgdL3J32ugk7PrtDw== X-Google-Smtp-Source: AGHT+IHUX5tfoqDLGdXxhW6wlp1xq5Km2+cDnZRAwkIzbZIxjT00p6RW2YF9Kf8Crizi0sFHfgTu X-Received: by 2002:a05:6a21:3388:b0:1a7:614d:b09 with SMTP id yy8-20020a056a21338800b001a7614d0b09mr3135913pzb.20.1713868724502; Tue, 23 Apr 2024 03:38:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713868724; cv=pass; d=google.com; s=arc-20160816; b=HEhf019TRjQifIDOAbdipA95guyPYG1gFlnLsx9JOnGcf5B5x+H9n5EU538e0sBae8 V+rMOcU1rxqWtn5mjdqoLRdaMc6Ah3+GbPk1g4uJkT99v41J6mU/cwbOdD9C1LiGh1rF Oj3Ha9kLkJ1/kJP8nAbNqsJ61Sgm0BELqohJLbRjvU41Ehl/x5vhfhEd1iG9ciz3s/XL F9cx7qz37z8t6PmLC65+ABzguRazLkvl+vqZJFeWTMQwxXt+OUlmwU3/h7UHwtCWGvdV 4g5Q50LRb0lSEswvt8LcT2e6Q8xS1V5x402K2nv4W+Rgi1JHsHSU6y97KKe2HP6H4BUG 5inQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:date:message-id:dkim-signature; bh=WRh2i7VaiPuKG/rd8719h0hISkyFOp0dscoxCokq5BU=; fh=pGJXlUUwfQ/lb4L0fO0xG+2bn+SBfr/6/lfxF2CFhYM=; b=Z9bK/+kodZ40f4IiWr8Lv44zR3csAbayWI1yna3fhE5GpX4Z55OLYNKLo+Td5fTicQ 2VyIjYt4LbMVB6hJGer3cnM4jAUz8NXJgwTt9FLeW7hf5BmJ6VsbadjxfFQe0ErUNyxB K/itTLbXpZeF3R4Ii8AHTmWsiWR2+mPiE3dfAuqMZHAqy8ztES7RbMfnSVvjd0iodC5E t4mvCaIvcR4/B8jf9URSqKH8ZUPQOIc9t6xOT2X+cUg3dViXb/kiBLZFDYmmlfWFHKf8 usahfa3p8TUxM+VuJ8Li5Tndo6ItxdyK4xo3uC2RD+4YfvWWxGoUd+FThp0nUM/TJjQo LxcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=kbO8dBSx; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-154879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154879-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w35-20020a634763000000b005dc86bae4b8si9176443pgk.408.2024.04.23.03.38.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 03:38:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-154879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=kbO8dBSx; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-154879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-154879-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 357E828481F for ; Tue, 23 Apr 2024 10:37:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4448A5F84F; Tue, 23 Apr 2024 10:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="kbO8dBSx" Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C7C9481D1 for ; Tue, 23 Apr 2024 10:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868671; cv=none; b=PoH9JWXR47eOY4h1dDkw+/yJdhPtRn/n4KBcxHcmyybYsStFKLkrBCWBnPZVgqq6wmmJAKURHmE1Q4xkW+CVOKyC+ccZ4Y1WtrRwIMAuPhrqhDU6ZTLzQsi/BeZV6iXFEL4dGszlouaecrrPe64ZUeCL9KeMHhV1L1YkUuMEW5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868671; c=relaxed/simple; bh=qgMUuzaktOkVsHPFOcCpokEnOqdIAKFflr3m387+uz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lWD303kYl/u6r5j8dKxpJaJwuZMv7oDWlEVgzrZZ1RWLA77QHGTJcVEbpFSKRc9MigV/hB1tHBRDnNo+hOtnuF3WsRQ4Ox1Mkuz2GtJ01woEBmzVdAzsHKjE0qKLFqPobKX/X8cOzCqawXcjQcdgDtSDLo7hZbtQpLczOccYLSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=kbO8dBSx; arc=none smtp.client-ip=115.124.30.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713868665; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=WRh2i7VaiPuKG/rd8719h0hISkyFOp0dscoxCokq5BU=; b=kbO8dBSx2SZ+wv3S27ygTuLHbf0/p/RXii+p6ebJ3A7/w56NHuPj92dCD0cMdPKqNbxIADGGfG+tgJ5pW042aHAVY1FGN1NiW+f4tCtR+2PRE1i5gkYevK+PYJTSM9iigI3bM3ZsfJVdWUJUu5xmXKp+LAdy7DDAk+Y4nVqVqWQ= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0W592.ia_1713868662; Received: from 30.97.48.197(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0W592.ia_1713868662) by smtp.aliyun-inc.com; Tue, 23 Apr 2024 18:37:44 +0800 Message-ID: Date: Tue, 23 Apr 2024 18:37:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context To: Baokun Li , linux-erofs@lists.ozlabs.org Cc: xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, jefflexu@linux.alibaba.com, viro@zeniv.linux.org.uk, brauner@kernel.org, linux-kernel@vger.kernel.org, yangerkun@huawei.com, houtao1@huawei.com References: <20240419123611.947084-1-libaokun1@huawei.com> <20240419123611.947084-2-libaokun1@huawei.com> From: Gao Xiang In-Reply-To: <20240419123611.947084-2-libaokun1@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/4/19 20:36, Baokun Li wrote: > Instead of allocating the erofs_sb_info in fill_super() allocate it during > erofs_init_fs_context() and ensure that erofs can always have the info > available during erofs_kill_sb(). After this erofs_fs_context is no longer > needed, replace ctx with sbi, no functional changes. > > Suggested-by: Jingbo Xu > Signed-off-by: Baokun Li Thanks, it looks good to me, let's see how it behaves after applying to -next. Thanks, Gao Xiang