Received-SPF: pass (google.com: domain of linux-kernel+bounces-154885-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 23 Apr 2024 18:40:48 +0800
From: Huang Rui <ray.huang@amd.com>
To: "Yuan, Perry" <Perry.Yuan@amd.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"Du, Xiaojian" <Xiaojian.Du@amd.com>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into
 msr-index.h
Message-ID: <ZieQMCzz+VUMcWya@amd.com>
References: <cover.1713861200.git.perry.yuan@amd.com>
 <858950a317b7093df72142d227c686290ba9eda5.1713861200.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <858950a317b7093df72142d227c686290ba9eda5.1713861200.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hgPX6hVWJhEbWKlLYstbwmkd7lDRCWIcx8IEcCH5a8h2H3BvKpbFc9/pvKr/?=
 =?us-ascii?Q?IXIlnwaYE5jAXsw5k+GuiCidR5zLIm9YYs56BIrxQezuVDnh49SBIsHZ0Rmw?=
 =?us-ascii?Q?Tpg2r9H9o5uMUO/7BduhZh/AcqZQmULCQqOC4lbGTYkfII+gdK5CSggOuJVA?=
 =?us-ascii?Q?2Sy5tPpYFNdavot4jJOp3/7kvPkcc9BMMUR3Ak/wuBn7LEbRfNcWJ2PcOXCS?=
 =?us-ascii?Q?6mSBynZSIqGfnT5SfQv2mDQMqUA3hGdbv8wwak2uMbOWgInPdcJITL878Y9t?=
 =?us-ascii?Q?Cr48JdUwYSpWd9331C5mCwurXDEdojdFEnIm3BAuI5+fiWzFjmVHRZAhAqwW?=
 =?us-ascii?Q?NQq5bmd6ieoo+tINg2KYOJW4/sXSnWOfLAyALQEX3pgdrzCnVwtnOst4fJ99?=
 =?us-ascii?Q?haGomnY4hsGShQ6zXO2rnnkCRg0pyQqHnVsxaAALLeW8NWgjOMz9KoQrirDt?=
 =?us-ascii?Q?j2OzCPfQZmfLgWaI+rrfKyqlaKAnogDrJ+LO1kFSyHivooZf0woSz1z2/k9R?=
 =?us-ascii?Q?nQIiDOUuB4S55M7E51eG7Yqgw8FHDmAQMGpYxyE2TZFF50R18nWUd05IneBr?=
 =?us-ascii?Q?CMIDDb8RxBTkIM1yBHbFgNCtZWBjOZHOe9CCk1Uj2rPdtCzj15TKhCoO6mP3?=
 =?us-ascii?Q?EXhBRHXPWi7ZKHTae99KaztxcQIwLnBp28zkI/+TAtx0V54iJia2vacI5AxR?=
 =?us-ascii?Q?mbfEjvrUwT14goOEWNIYn7FPIGapraiDZpdToUCiFQfbSxawim2rBW/K7B5g?=
 =?us-ascii?Q?e1ZwdJUam1B55parDX6H7nQV9RJFwaoZ0KkV86x2EKyXTAKcq3YM3ZlNrRTI?=
 =?us-ascii?Q?ZZASWIIeECCp3KLp+Pl0rIRHl2k6z6ECBMZ6IMgHiiDHQgKJcFgtE7cBPDUk?=
 =?us-ascii?Q?jdrb5hTKwaNkUR3vWUxgDiU0Q7DgAJdCPgkl8M/6Sa9fmMyx9m9m+QhMjpSy?=
 =?us-ascii?Q?dzr5odyHDW98TOUbUE+jKY39Yadg2yCLUKKzxM6AqDUsY8jgjWo7sD5lqT1F?=
 =?us-ascii?Q?PaLwqP5uz/0X69uGegWKfQpiBai9gDTnoERLm/2PqdOb5liau2sA+lWII3oK?=
 =?us-ascii?Q?dYuHs00DnJzdMP4Rzn4U4QvTfD9EORyGQaAIZ8BDkSS2uF1jjDoZ0RS0hcin?=
 =?us-ascii?Q?9/jBczbFMfNYkl4qUFFwwdrbnXCVFl01DYyo9WGU0eE1paEG5gvMasCjicPl?=
 =?us-ascii?Q?kLMVnMcd4SCOjvU9XabCfH5QIudSa+rmlT2WtEnUiwiC3gO5sC1sOgobnLxM?=
 =?us-ascii?Q?LTyMWFtPyejBmfrZLRH9ZpeiLWtkoyM5cHwoYoon7R8YCLcbaeR6V5P6PnsS?=
 =?us-ascii?Q?LEEU9mwlsYMTuE6ivxVCQkSrrrf8nsV0je43W/99fiHMQlu7aDSYVp+lBnXF?=
 =?us-ascii?Q?C/203qMi7ie4hI6X15eF6oLGBf2p9clwBQzvefmnAO0PO8O5wo6B+apL1XWr?=
 =?us-ascii?Q?avCe+hCOYf+APp+BDg6lQz5b/YeurzXFGmjGFllOj5dE/cFVf5IAkISRGO2v?=
 =?us-ascii?Q?whsdu/1npiwqIhAANKsCbmC3d5D5vGYl46sE2zuwmrt9t/uwi/YnvuwhHAkG?=
 =?us-ascii?Q?EvIiGMJr2J04ShdsLxTYXgvB5igOJ0u6KK+VMdOA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf68bd01-1e63-4915-6e84-08dc6381e3d0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 10:41:10.5146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L0XOaVyy20kBZXi5aU3L6gYNFIquXIXadfn6MKoZ1OgQk3SLLGGxcFSm97KoZctGezekyLM3yK/BjTGA50+yEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8724

On Tue, Apr 23, 2024 at 04:40:54PM +0800, Yuan, Perry wrote:
> There are some other drivers also need to use the
> MSR_K7_HWCR_CPB_DIS_BIT for CPB control bit, so it makes sense to move
> the definition to a common header file to allow other driver to use it.
> 
> No intentional functional impact.
> 
> Suggested-by: Gautham Ranjal Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  arch/x86/include/asm/msr-index.h | 2 ++
>  drivers/cpufreq/acpi-cpufreq.c   | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index e72c2b872957..8738a7b3917d 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -782,6 +782,8 @@
>  #define MSR_K7_HWCR_IRPERF_EN		BIT_ULL(MSR_K7_HWCR_IRPERF_EN_BIT)
>  #define MSR_K7_FID_VID_CTL		0xc0010041
>  #define MSR_K7_FID_VID_STATUS		0xc0010042
> +#define MSR_K7_HWCR_CPB_DIS_BIT		25
> +#define MSR_K7_HWCR_CPB_DIS		BIT_ULL(MSR_K7_HWCR_CPB_DIS_BIT)
>  
>  /* K6 MSRs */
>  #define MSR_K6_WHCR			0xc0000082
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 37f1cdf46d29..2fc82831bddd 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -50,8 +50,6 @@ enum {
>  #define AMD_MSR_RANGE		(0x7)
>  #define HYGON_MSR_RANGE		(0x7)
>  
> -#define MSR_K7_HWCR_CPB_DIS	(1ULL << 25)
> -
>  struct acpi_cpufreq_data {
>  	unsigned int resume;
>  	unsigned int cpu_feature;
> -- 
> 2.34.1
>