Received-SPF: pass (google.com: domain of linux-kernel+bounces-154969-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 23 Apr 2024 13:21:28 +0200
From: Borislav Petkov <bp@alien8.de>
To: "Nikunj A. Dadhania" <nikunj@amd.com>
Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, x86@kernel.org,
	kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
	dave.hansen@linux.intel.com, pgonda@google.com, seanjc@google.com,
	pbonzini@redhat.com
Subject: Re: [PATCH v8 06/16] virt: sev-guest: Move SNP Guest command mutex
Message-ID: <20240423112128.GDZieZuKw8Ca2jiXw9@fat_crate.local>
References: <20240215113128.275608-1-nikunj@amd.com>
 <20240215113128.275608-7-nikunj@amd.com>
 <20240422130012.GAZiZfXM5Z2yRvw7Cx@fat_crate.local>
 <6a7a8892-bb8d-4f03-a802-d7eee48045b5@amd.com>
 <20240423102829.GCZieNTcHyuAYMcRf5@fat_crate.local>
 <f8dbd58c-78da-4b3f-a79b-6693c04fb104@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f8dbd58c-78da-4b3f-a79b-6693c04fb104@amd.com>

On Tue, Apr 23, 2024 at 04:12:00PM +0530, Nikunj A. Dadhania wrote:
> Something like below ?
> 
> snp_guest_ioctl()
> -> get_report()/get_derived_key()/get_ext_report()
>   -> snp_send_guest_request()
>        snp_guest_cmd_lock();
>        ...
>        snp_guest_cmd_lock();
> 
> With this the cmd_lock will be private to sev.c and lock/unlock function
> doesn't need to be exported.

Yes, something like that.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette