Received-SPF: pass (google.com: domain of linux-kernel+bounces-154971-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <CAGsJ_4xu4iL5pv7T1chyzGC2Vp9q1GwOp3wxb=bYMW-T-pj4dA@mail.gmail.com>
 <20240423094502.4080-1-ioworker0@gmail.com>
In-Reply-To: <20240423094502.4080-1-ioworker0@gmail.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Tue, 23 Apr 2024 19:22:47 +0800
Message-ID: <CAK1f24nS9mJ4xU+Z7uzNZxAAgAoqx4-z_v888eRqs98cFb3cpg@mail.gmail.com>
Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters
To: baolin.wang@linux.alibaba.com
Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, 
	hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, 
	willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 5:46=E2=80=AFPM Lance Yang <ioworker0@gmail.com> wr=
ote:
>
> On 2024/4/23 09:17, Barry Song wrote:
> [...]
> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> >> index 26b6fa98d8ac..67b9c1acad31 100644
> >> --- a/include/linux/huge_mm.h
> >> +++ b/include/linux/huge_mm.h
> >> @@ -270,6 +270,8 @@ enum mthp_stat_item {
> >>          MTHP_STAT_ANON_SWPOUT,
> >>          MTHP_STAT_ANON_SWPOUT_FALLBACK,
> >>          MTHP_STAT_ANON_SWPIN_REFAULT,
> >> +       MTHP_STAT_SHMEM_ANON_ALLOC,
> >> +       MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK,

Seems like you forgot to add the FILE_FALLBACK_CHARGE counter
in this patch :)

IIUC, you've excluded the THP_FILE_FALLBACK_CHARGE counter
for PTE-mapped mTHP that size < PMD in patch3.

Thanks,
Lance