Received-SPF: pass (google.com: domain of linux-kernel+bounces-154982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240422213006.505576-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20240422213006.505576-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <2b422e9f-bd80-4c57-a3e1-8b463b25c834@kernel.org> <CA+V-a8s1xDT7sGMpz_n45v9QzhpWUdJv9eXmUJoxPaJ69MiY7A@mail.gmail.com>
 <4c6d6957-3813-46d3-88de-ee64241bbe6f@kernel.org>
In-Reply-To: <4c6d6957-3813-46d3-88de-ee64241bbe6f@kernel.org>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Tue, 23 Apr 2024 12:26:50 +0100
Message-ID: <CA+V-a8s2pahd23jhkYdxJ_j8SxADaYf4QxOwO1_3jmCr9MzuFw@mail.gmail.com>
Subject: Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Magnus Damm <magnus.damm@gmail.com>, Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, 
	Biju Das <biju.das.jz@bp.renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 10:59=E2=80=AFAM Krzysztof Kozlowski <krzk@kernel.o=
rg> wrote:
>
> On 23/04/2024 09:21, Lad, Prabhakar wrote:
> > Hi Krzysztof,
> >
> > Thank you for the review.
> >
> > On Tue, Apr 23, 2024 at 7:29=E2=80=AFAM Krzysztof Kozlowski <krzk@kerne=
l.org> wrote:
> >>
> >> On 22/04/2024 23:30, Prabhakar wrote:
> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>>
> >>> Drop 'items' keyword from compatible list which have single const val=
ue.
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com=
>
> >>> ---
> >>>  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++----------=
--
> >>>  1 file changed, 6 insertions(+), 12 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml =
b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> index 29f2400247eb..90c8b1b727a8 100644
> >>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> @@ -12,16 +12,11 @@ maintainers:
> >>>  properties:
> >>>    compatible:
> >>>      oneOf:
> >>> -      - items:
> >>> -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r7s72100 # RZ/A1H
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
> >>> +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> >>> +      - const: renesas,sdhi-r7s72100 # RZ/A1H
> >>> +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> >>> +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> >>> +      - const: renesas,sdhi-r8a7740 # R-Mobile A1
> >>
> >> That's just an enum.
> >>
> > Are you suggesting to group them into a single enum instead...?
>
> Yes. That's preferred form, easier to read, because it clearly documents
> that binding enumerates.
>
Agreed.

> But just in case you start changing all const to enums: don't. Comment
> is for this patch, since you already want to touch these things.
>
Indeed.

Cheers,
Prabhakar