Received-SPF: pass (google.com: domain of linux-kernel+bounces-155093-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] bitops: Change function return types from long to int
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <e7e4ff27-ebb3-4ed6-a7cc-36c36ab90a36@app.fastmail.com>
Date: Tue, 23 Apr 2024 13:45:28 +0200
Cc: =?utf-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= <amadeuszx.slawinski@linux.intel.com>,
 Xiao W Wang <xiao.w.wang@intel.com>,
 Palmer Dabbelt <palmer@rivosinc.com>,
 Charlie Jenkins <charlie@rivosinc.com>,
 Namhyung Kim <namhyung@kernel.org>,
 Huacai Chen <chenhuacai@kernel.org>,
 Youling Tang <tangyouling@loongson.cn>,
 Tiezhu Yang <yangtiezhu@loongson.cn>,
 Jinyang He <hejinyang@loongson.cn>,
 Linux-Arch <linux-arch@vger.kernel.org>,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <99B58F85-CC9C-49F6-9A34-B8A59CABE162@toblux.com>
References: <20240420223836.241472-1-thorsten.blum@toblux.com>
 <42e6a510-9000-44a4-b6bf-2bca9cf74d5e@linux.intel.com>
 <C0856D2E-53FF-45EB-B0F9-D4F836C7222C@toblux.com>
 <e7e4ff27-ebb3-4ed6-a7cc-36c36ab90a36@app.fastmail.com>
To: Arnd Bergmann <arnd@arndb.de>

On 22. Apr 2024, at 17:55, Arnd Bergmann <arnd@arndb.de> wrote:
> On Mon, Apr 22, 2024, at 16:30, Thorsten Blum wrote:
>> On 22. Apr 2024, at 09:44, Amadeusz S=C5=82awi=C5=84ski=20
>> <amadeuszx.slawinski@linux.intel.com> wrote:
>>>=20
>>> I don't mind the idea, but in the past I've send some patches trying =
to align some arch specific implementations with asm-generic ones. Now =
you are changing only asm-generic implementation and leaving arch =
specific ones untouched (that's probably why you see no size change on =
some of them).
>>=20
>> I would submit architecture-specific changes in another patch set to =
keep it
>> simple and to be able to review each arch separately.
>=20
> I can generally merge such a series with architecture specific
> changes through the asm-generic tree, with the appropriate Acks
> from the maintainers.

Ok.

I would still prefer to keep this patch free from arch-specific changes, =
if
possible. The patch improves architectures that use the generic bitops
functions (e.g., arm64) and doesn't impact any arch-specific =
implementations,
unless I'm missing something.

Thanks,
Thorsten=