Received-SPF: pass (google.com: domain of linux-kernel+bounces-155096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 23 Apr 2024 19:45:39 +0800
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Will Deacon <will@kernel.org>, mark.rutland@arm.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org,
	namhyung@kernel.org, irogers@google.com, mike.leach@linaro.org,
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH v10 3/8] perf: imx_perf: let the driver manage the
 counter usage rather the user
Message-ID: <20240423114539.4jseauipidvwo7bh@hippo>
References: <20240415061320.3948707-1-xu.yang_2@nxp.com>
 <20240415061320.3948707-3-xu.yang_2@nxp.com>
 <20240419154913.GA3983@willie-the-truck>
 <ZiK6G3aM+K92lq0w@lizhi-Precision-Tower-5810>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZiK6G3aM+K92lq0w@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9aVnH9ioKLDBdmGUVxmDSXFuQtrev1uUgsja7L3I+13VhdkNn8WwZFBC7pqZ?=
 =?us-ascii?Q?dRGBIdB0fq3Izhk691VaLtLOoPHR2I6vF3RtWD9PHfzUZsuBaX3rtlSCO7lX?=
 =?us-ascii?Q?3fKXbtpswjAZ9+kmURj6AKEBnkvIh0XrS5p+beF9RA3Nd/5ttdzn7ejzm/ZB?=
 =?us-ascii?Q?6w2g/tcxirnnFGnY2DGJvfGn7pQOtOc2dCaWA9f5wuML8fBGYJ1KNEFf0obf?=
 =?us-ascii?Q?Y/8UxijE3AGKRGIDUy8SXzTCfr1sg3JCwfjA1HEuO3sCfHv91+cIV6eOe3Bd?=
 =?us-ascii?Q?MAT8ZGpc10t1q925rWwUWRIuH1qCFA0uKA1QoI8dhd4STuEFalrr3xra0Jgp?=
 =?us-ascii?Q?N6F71CycZebeAt6/Wk0Hb7lNV9OwCRQl3Yhkaj9zCsw2qUpv/u/8jODj57VI?=
 =?us-ascii?Q?jQH3p6d+jEy7BvdpMK9buFncAek8WnlD2a0Z4CCaIiqPAFgWZ78FnVd/vOsf?=
 =?us-ascii?Q?lfuLsieSov/ZZxYyGPjplSkUgy9tMARKqPFRqs67JaRH+9AAMhy2sGFINJqc?=
 =?us-ascii?Q?SF6179vmhqzQxAV9WVLMIZwUGnmoLfTpoGAr/vP8XSe2Q6SjmuPlMbMqAIwz?=
 =?us-ascii?Q?e+K5lFIqBwU8NdixtKuLBp66LXkVh8LDWWu188L70G5SJ7q4axPEuQ15XBey?=
 =?us-ascii?Q?147ahF1RyaoNSbOSFVAS0Tn5p2ItQKYLAuFoLJ2am2jgosPlcUAn9Rjjpbcr?=
 =?us-ascii?Q?PkxshFqtaC4C8xz0re21Fvr2JUbtX/+Gih4x34Q0ZG+P4XDftdKjLtdv6vmo?=
 =?us-ascii?Q?PHffhh3wQjfTCPghftsOeot9/vMW3NJ8k94Oocm9UNE+z4Z8TeMF5fChsu6V?=
 =?us-ascii?Q?9RQ5AfrhhzhiasLF6CtAEYx0qETPY3cqJAKf5/CbRNdFJpzOOA/l0uKOOETX?=
 =?us-ascii?Q?QbKCZR955bYpncNyt5moqqAlQMwzNpffoyH+HGXF03IQaWrjQVNafLcw9sf+?=
 =?us-ascii?Q?Tw+1vuhswGsvgB+/fb7GZt8yhXgDreRB0G5pp7UCsRZv25fBeO0/lN/utxNJ?=
 =?us-ascii?Q?FJuazYzv3balzUAPPLAi8ap/dGPPk0oGunGyLvlImPY6OocPIedQQ2Ub2Lek?=
 =?us-ascii?Q?2cCU1pcCYcmUOvPeu1IyA1o9eSluxZn/JPUYkCtFexxefEboIn1BIOnFjW5D?=
 =?us-ascii?Q?8wKOAWIre7Yy3ceHbgGYoytfANNAh0JxIYwAwz6KlUYuWCqrjWTTZSICh82y?=
 =?us-ascii?Q?zOSX93jlM+IAYxa0B7ehY3bZxw9avLrW9hIqcHljBW7Nh8mSDWfwFjqAGBA+?=
 =?us-ascii?Q?U9CypwrNqnNYtr2NZ4AdiO9pZMWJlrNAS/mG5FjCJtJ3JuDp5FaUpU66fEKC?=
 =?us-ascii?Q?0f/CuogvkFrBpHbK0U5L5jQntRrcodW7TailvQOMV2JnuxwvjeHTagh0ntHP?=
 =?us-ascii?Q?EGxIvRJEg0/yF7jUB6dFDvtowb0ne3rhYXn2DAcUSQ8mWOfcmARUdw/b2P7O?=
 =?us-ascii?Q?LOcIy3UZ4tm/J9wMoIephh9qzuWKz1Phe7d/urnojNf7sNoM0PeBikRJZJSs?=
 =?us-ascii?Q?rX3WjEh0lyt9N8IGPrICzQYg1Hk6lCKlwXiyri9EfHhmcqCZ2EwTNtDuMzzg?=
 =?us-ascii?Q?w5ByDLmJ8Oij/Yryt2JLNUitQY7CksCLeTZt8dAA?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f17926db-abc3-4118-2837-08dc638b17e2
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 11:47:03.2794
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tlm2lg5t7dv0IObkUcyQZivyoONMyFxbu/RWfQeQvgR4WuvMaKOPNKhgUX+H1M6b5mHteVxDzzPF8DtO9euokw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9120

Hi Frank,

On Fri, Apr 19, 2024 at 02:38:19PM -0400, Frank Li wrote:
> On Fri, Apr 19, 2024 at 04:49:13PM +0100, Will Deacon wrote:
> > On Mon, Apr 15, 2024 at 02:13:15PM +0800, Xu Yang wrote:
> > > In current design, the user of perf app needs to input counter ID to count
> > > events. However, this is not user-friendly since the user needs to lookup
> > > the map table to find the counter. Instead of letting the user to input
> > > the counter, let this driver to manage the counters in this patch.
> > > 
> > > This will be implemented by:
> > >  1. allocate counter 0 for cycle event.
> > >  2. find unused counter from 1-10 for reference events.
> > >  3. allocate specific counter for counter-specific events.
> > > 
> > > In this patch, counter attr will be kept for back-compatible but all the
> > > value passed down by counter=<n> will be ignored. To mark counter-specific
> > > events, counter ID will be encoded into perf_pmu_events_attr.id.
> > > 
> > > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > 
> > > ---
> > > Changes in v6:
> > >  - new patch
> > > Changes in v7:
> > >  - no changes
> > > Changes in v8:
> > >  - add Rb tag
> > > Changes in v9:
> > >  - keep 'counter' attr for back-compatible
> > > Changes in v10:
> > >  - add some explanation about 'counter' attr in commit message
> > > ---
> > >  drivers/perf/fsl_imx9_ddr_perf.c | 168 ++++++++++++++++++-------------
> > >  1 file changed, 100 insertions(+), 68 deletions(-)
> > 
> > [...]
> > 
> > > @@ -245,8 +249,8 @@ static const struct attribute_group ddr_perf_events_attr_group = {
> > >  	.attrs = ddr_perf_events_attrs,
> > >  };
> > >  
> > > -PMU_FORMAT_ATTR(event, "config:0-7");
> > > -PMU_FORMAT_ATTR(counter, "config:8-15");
> > > +PMU_FORMAT_ATTR(event, "config:0-15");
> > > +PMU_FORMAT_ATTR(counter, "config:16-23");
> > 
> > Although these mappings are advertised in sysfs, I don't think we can
> > change them because userspace could be relying on them. I also can't
> > find any examples of other PMU drivers in the kernel changing these
> > mappings after being merged, so please keep tthem the same.
> > 
> > If you need to expand the properties to be 16-bit, then you'll need to
> > split them into 2x8-bit fields.
> 
> I just see tools/perf/tests/pmu.c: { "krava01", "config:0-1,62-63\n", }
> So I supposed "config:" supported below format
> 
> PMU_FORMAT_ATTR(event, "config:0-7,16-19");

It works.

Thanks,
Xu Yang

> 
> I just want to confim with you because I have not found other perf driver
> using such format yet.
> 
> Frank
> 
> > 
> > Will