Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2901521lqt; Tue, 23 Apr 2024 05:22:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUZAqZN6gMepFtJUbQI8F+ONAwcqrrxEdvQkgXGtIxjugOYdGMlZdCPEJukkP5i7RVHOJ7ZsxaiG5WiPCt4r45ecl5TpaVSjnS0BC5l5w== X-Google-Smtp-Source: AGHT+IHltksWtRjTwW9NqsoEyxIFFC6k+b0lbdpkbLefUuAJnIjmInCXOrxgGhJmL8g9hPmvvdBd X-Received: by 2002:a17:90b:124a:b0:2ac:23fb:e3bf with SMTP id gx10-20020a17090b124a00b002ac23fbe3bfmr13013063pjb.36.1713874954792; Tue, 23 Apr 2024 05:22:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713874954; cv=pass; d=google.com; s=arc-20160816; b=FEzWIdJTTaRt1xocWBwhUpV05H7TSYHBM4ewl1EnuuMlfOwUG1cFcpZLBNUQVV0vyN NasYN58XXZZt1uIOG83ngp0z3MfQuLvDN0vdse1tcy4Mh3y03uqctKpwn7eiajM7hL6U wX5DL6HVlZ9ivL4fh8Rz2G/zekrRZtGtrfgbddQTADv9a86NBy/8WkZPJB0nFR3iUuxv uA1VGnBLHH2FTVLF582BaF0BF+dIMRsDDAGxleTSqmP67ZMR/GlLzzUIVMRS0zuBQjav 27yxlKnuuTQpAhL/BRGhc91sG+HXP040zI8HfJZ4m1w4iXmFg1mlUwqatIFM/swwIg41 8bzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=zGpCGDLM61ejMNOyLJt8CjD5GKhvUW/9uVClM+cy3Nw=; fh=jHDOAoxuEMzO4trf3zRUlJdzxbT5W/OalCR4vZcYO48=; b=N3azI0WxvDjoQA0uotIKklpLzwln2me1meik+KmU+OjTbbSPO7zSZatQS2iuFZ9tpd 9xRjBoXC4f3O/0xnHyCPOvnlD0pMNs96HuYE1n+jwE31xLUg0pFeXL/b8WML9LWkFnP8 JhcRypeqy5SMVa+9QhkS92/p9JSkDsfL/7Lx7oIhSz0X90CA/kjZ2N0FKBL980/PQgEE 9ftPqtkMpmLpuGXScKHXnR3tEMcz9yo9qAAnKKyOG2OWwca42tU0FZZSBWYx0g5GIF3Y FIlQkvBTIv2GjpmXWOfxn3RkX3dCKF7B5aVNT5ilAwPoYDfA6biLMgo2bLZh5GCdDZ5k p5Sg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@antgroup.com header.s=default header.b=Kvs7XDBR; arc=pass (i=1 spf=pass spfdomain=antgroup.com dkim=pass dkdomain=antgroup.com dmarc=pass fromdomain=antgroup.com); spf=pass (google.com: domain of linux-kernel+bounces-155145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155145-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=antgroup.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g5-20020a17090a7d0500b002ae2bfe1374si2738963pjl.7.2024.04.23.05.22.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 05:22:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@antgroup.com header.s=default header.b=Kvs7XDBR; arc=pass (i=1 spf=pass spfdomain=antgroup.com dkim=pass dkdomain=antgroup.com dmarc=pass fromdomain=antgroup.com); spf=pass (google.com: domain of linux-kernel+bounces-155145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155145-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=antgroup.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 276FA283BD0 for ; Tue, 23 Apr 2024 12:16:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9118F7E78E; Tue, 23 Apr 2024 12:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=antgroup.com header.i=@antgroup.com header.b="Kvs7XDBR" Received: from out0-213.mail.aliyun.com (out0-213.mail.aliyun.com [140.205.0.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A531483CD3 for ; Tue, 23 Apr 2024 12:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.205.0.213 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874600; cv=none; b=i7axljhjpCAEWB6cYvTbbcDXkwbJXK2qiP+/rGz6LGOi3bKTK2OcYo7VREvvFYL0aqdLbZNwpI5mhHR6Exq2/SnYnJeGpVkYGB2FtYwde0Ekg8HGLnpg/0ui0+iGs8/37RKgI6HdixAXrsfu8gEVu6dMJSXBCSmmCwhwhmGkNmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874600; c=relaxed/simple; bh=UFzQ3kWYWHBKaUYKOPY1WkcFren0Bv5aLakJ4HzCXeo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oqmsxrCn87AcSV+0lMrNgy89qTeCDEi26QFxJW/oD0tZYcLEQMqgXzNeax5VavRXV6eHpHd/OM6FDa2AvIi5d6GH9KS7gXsuAyu/5M5/LpdXpPdoE5P8zob23HM9FwpDeaPeLcPlAoQweuxajdX83TVFsxMS0f5lD0S8TqVVzr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=antgroup.com; spf=pass smtp.mailfrom=antgroup.com; dkim=pass (1024-bit key) header.d=antgroup.com header.i=@antgroup.com header.b=Kvs7XDBR; arc=none smtp.client-ip=140.205.0.213 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=antgroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=antgroup.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1713874593; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=zGpCGDLM61ejMNOyLJt8CjD5GKhvUW/9uVClM+cy3Nw=; b=Kvs7XDBRcsVTErGY3Tl7r59h7TIyoMKdxvV3PjmPP3o1m0CZ/HHdlW4nOvqjIVui/CMB7O83v6XLV13LPWnqPN7Lcebq/PdYQnG7P2ZRF/px/tJ34qLMmA57V82j+fNK0hIAD9sFrwART/nDBX8ns5YLf6NmFBBzWOFZWt4KnkI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018047198;MF=tiwei.btw@antgroup.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---.XJXNWHL_1713874275; Received: from 30.230.91.3(mailfrom:tiwei.btw@antgroup.com fp:SMTPD_---.XJXNWHL_1713874275) by smtp.aliyun-inc.com; Tue, 23 Apr 2024 20:11:16 +0800 Message-ID: Date: Tue, 23 Apr 2024 20:11:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] um: Fix the -Wmissing-prototypes warning for __switch_mm To: Johannes Berg , richard@nod.at, anton.ivanov@cambridgegreys.com Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240423112457.2409319-1-tiwei.btw@antgroup.com> <20240423112457.2409319-3-tiwei.btw@antgroup.com> <8134c423c1a7f911cb5ae2f2e8e40e80f2e5270f.camel@sipsolutions.net> Content-Language: en-US From: "Tiwei Bie" In-Reply-To: <8134c423c1a7f911cb5ae2f2e8e40e80f2e5270f.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/23/24 7:29 PM, Johannes Berg wrote: > On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote: >> >> --- a/arch/um/include/shared/skas/mm_id.h >> +++ b/arch/um/include/shared/skas/mm_id.h >> @@ -15,4 +15,6 @@ struct mm_id { >> int kill; >> }; >> >> +extern void __switch_mm(struct mm_id *mm_idp); >> > > Maybe drop the extern while at it? Sure, will do. I also prefer to drop the extern. Thanks for the review! :) Regards, Tiwei