Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2903593lqt; Tue, 23 Apr 2024 05:26:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWL4wBrdS0CCY+kHu5ylzMEIAqF7Mt+RuIbvcuH8yW7jecpa53u1iM6YcIOXv0RLzwGldTDWqoOOgLDDALvG2Az8v8d/WWV2as4+Gz6Sw== X-Google-Smtp-Source: AGHT+IGsrlUDnQHNrE8Vx0D1NCPKRr7Qql20xs804mku0ofGABbho54yCreUR05zsQP1IG7er0y8 X-Received: by 2002:ac8:5751:0:b0:437:99d9:6207 with SMTP id 17-20020ac85751000000b0043799d96207mr17179567qtx.59.1713875179183; Tue, 23 Apr 2024 05:26:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713875179; cv=pass; d=google.com; s=arc-20160816; b=RIm4KAJD5tQpgQlpkH/GcWbIecPppifnfUHkuM2Xftq74KpeR/skg8fYnIg4VSauHC EeqVP4k1cvP20LHYGsODxXnRP9k1hVBmh65HvvFOOYnouc7DcQWZAzpA6qVvH1KhAsp4 AKdWzIYbMd0tNPxN3oo1Z/fu4qkIH2y7dlTegCd1aS3dlNlnnFPyB/6mu+tznSsSS6h+ tIzPGViBRfvLPVfcDZ4Cplr0FI8FNk7Bz+EhxmtIF5przoQXTdqlhmke9rBcizXRfgFq CHeTZUaLxybVokBRbdMdJrB5SO+DiRQX+v/NLa91n43osKNbMW6k+te1ONdP85aZNv6h S/Mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from :dkim-signature; bh=e6ARaU2OvtoZ+qzRuhjbMDMgcKFgiApYcNksWkkvBME=; fh=jQGUmjI18alFtDLjDaM2zundwvQZHBUVx7nrAZMPErY=; b=dbyfjoTOJfiF6DX/xZYtqeuZeX4JX+nzYKHF3ZSEtqiVDW+CX2BgUGvcU3vCkAZEN4 3PEiLEE0hQIuVO6tYfTJZVWyk2cRwR6bFCkNsjLFi/wKdsdiNzu8cgWzGvTHQAKEks4G mi4GA8VYcDrZBBOJwWM7V22dx1UR0/jeGAoKn6ub43Kd+dRKJbtG2CY4l/j707AoT3Pj 4xyheHk5/s0FyNbVf6WfSPos4mAU+pbULhsLkuL627mhHzQGJk8cOEiLXEhLz8Z09LLu j+BZN6xMozDCfmU4QAxYtCtQUqh9ugN/vxu2lT8weOLw8B7fIYM22QXaD/Wq7rh6SlPB 4mCg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b="as/Udpef"; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-155156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155156-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ga23-20020a05622a591700b00439e82a5be3si1832533qtb.775.2024.04.23.05.26.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 05:26:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b="as/Udpef"; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-155156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155156-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E2D3A1C2239E for ; Tue, 23 Apr 2024 12:26:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6A7784FC4; Tue, 23 Apr 2024 12:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b="as/Udpef" Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8BE778285 for ; Tue, 23 Apr 2024 12:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713875170; cv=none; b=WZdbmAlaJkjjUtIQmoWymwC10k6HjceHySfrZ+D2665zZFIb6YfEQwirtjwe11z0PCHvDPQ545rpczT6OTjWwro0h345P/KPJMBBywnfYnVHEw34KOC9T8aHVwj8wAVZtrxQy5GjexRxigUBKsdQJC5ykhYkKIhSQ44qjxHe84w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713875170; c=relaxed/simple; bh=e6ARaU2OvtoZ+qzRuhjbMDMgcKFgiApYcNksWkkvBME=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=sstF/uFw7cCKfZhgPKogZAySeDR0+DkH2J+P0H/7gfFVL6KVhBxtFEnVbD0Y8Wu1BvVmwaodjFVp4NsKLLjHkZNbP4VPi78mxQTrTbINwzRzcq87oy7P7bfjmuokmU4HH6ZKPKF2J1ogDqcDE0dfR/ehk3BgaWiMJHXZAhE0kYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf; spf=pass smtp.mailfrom=kl.wtf; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b=as/Udpef; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kl.wtf X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kl.wtf; s=key1; t=1713875165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=e6ARaU2OvtoZ+qzRuhjbMDMgcKFgiApYcNksWkkvBME=; b=as/Udpef9eDD+8GaJPHSDIIQANVuzGADEdLLCu2Ok9qKb9HbUhQsXLDuQUJZRQUSWP7dD1 6AQ/02qX/tHtpv5EpmBd25oELsLQhRh0QBbBI93PiMfSd9pJxuDWVtwY3Ah4TXGxFm73o5 Xb+C/1m4iSChBucJ0m1J49V6XUZtISl1FTeo2SqHVxTeuK1cAHgE23Jee/i78gFGe4gqBZ aQxsMhC/JZtHPnsL4l6akpGOZTXa/KvYBCgdriCq5ZHC8Q3hTQbkL0kKB0KoGmuA8q63jF v2dOjGogQdxc1zWCWvM2Y6FK6KShSJM9BeQUv/oZETdk7z//RvpF8CvW1i6fbA== From: Kenny Levinsen To: Jiri Kosina , Dmitry Torokhov , Benjamin Tissoires , Douglas Anderson , Hans de Goede , Maxime Ripard , Kai-Heng Feng , Johan Hovold , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Lukasz Majczak Subject: [PATCH v2 0/3] HID: i2c-hid: Probe and wake device with HID descriptor fetch Date: Tue, 23 Apr 2024 14:07:52 +0200 Message-ID: <20240423122518.34811-1-kl@kl.wtf> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This revises my previous patch[0] to add the sleep STM chips seem to require as per discussion on the original patch from Lukasz and Radoslaw[1]. I had initially tried without as it had not previously been needed in the similar logic in our resume path, but it would appear that this was simply luck as the affected device was woken up in that case by "noise" from other sources. To reiterate, the idea is to add the retry that Lukasz and Radoslaw discovered was necessary, but do away with the dummy smbus probe and instead just let HID descriptor fetch retry as needed, aligning more with the existing retry logic used after resume while saving some noise on the bus and speeding up initialization a tiny bit. I added Co-developed-by tags, I hope that's appropriate. We should await an ACK from Lukasz on it fixing their hardware quirk. [0]: https://lore.kernel.org/all/20240415170517.18780-1-kl@kl.wtf/ [1]: https://lore.kernel.org/all/CAE5UKNqPA4SnnXyaB7Hwk0kcKMMQ_DUuxogDphnnvSGP8g1nAQ@mail.gmail.com/