Received-SPF: pass (google.com: domain of linux-kernel+bounces-155186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Bert Karwatzki <spasswolf@web.de>
To: Jianfeng Wang <jianfeng.w.wang@oracle.com>
Cc: Bert Karwatzki <spasswolf@web.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] mm: slub: Fix compilation without CONFIG_SLUB_DEBUG
Date: Tue, 23 Apr 2024 14:40:21 +0200
Message-ID: <20240423124025.193812-1-spasswolf@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:q34wlOvMt0c=;BVUMuW6vvd6A1LiVuJo8p522QlI
 Ekbm7NOD9glCWSVlJU9F/QPqP4VfJ52JOYcm2PsUYCdlHudW10uBnYBmbseeIioevdLjIay6C
 ilMmUPyWKd4/8dcW9ptWjMRbTPLyIPW44JifH6MIcQNUCcQAmGznUx0zrXnzcjc88lnYlt1XG
 WkfnoJcK1gUvmSshYUFIpNBCmJel+cD1UDecpDdvzYRYWRFQCP0OTJWivzglao4PJoZxqZPK6
 NGXOwrbyu9DvArHHFBq2GRejPYceHPMsnyoIp+iCD8cPk9LCCCRWf6gI1u9hAKFDBtniwX0Pw
 wb+yByLt+bPi8+Yk6V1TrBEgjtCbonlBOeP+Pm/CWZDCuekP0Gty8E7hf9wfTmxpv3i6eoWPj
 MSqAuInshruxIF80x9ydKqEsdpbQtPRQDnkygOdptKKTOiwkgQfdXyjwGBFyD87A6/a7B/7yp
 25FaOK0VcG8Wc+kifuelcazDqJoihgDDyTA3IKKmc/rmkgx04iHIt2Vd1JDb2u3G74DNxjIvl
 ydyvKW/mQQJxpf2BDE0CLpgm7Km/DP1Y+ba5P/Yz1jMS2UcJQAQDlPVqIe/B7G4sGTkefghBR
 lTpoFce7+JvnPgkWclhJCwVKdkHW9mnjn0+tkBWuLldHmgg9pjL/4BAQ+YjzaSPQnjXZ7lUV5
 UmdwVE8UNX8qACwFrDkWC64uh9W1+5kCCBazqlZJCd/Bzik/L5iJxJNorMHCbCE+B2upFaVal
 wNgfHVDHZ2ZQ8Pw1ikgzqnylbozQzz4IjcO5+mtdP+t/gkYN8h+jLCPVqCAtJTROiWnt7et1l
 qjYI9FkoiwCDh7N9ujzbVCarUFljvPtV9PWiBvsEQ+EiI=

Since the introduction of count_partial_free_approx the compilation of
linux fails with an implicit declaration of function =E2=80=98node_nr_objs=
=E2=80=99
because count_partial_free_approx is compiled when SLAB_SUPPORTS_SYSFS
is defined even without CONFIG_SLUB_DEBUG. As count_partial_free_approx
is only used when CONFIG_SLUB_DEBUG is defined it should only be
compiled in that case.

Fixes: commit 1c5610f451be ("slub: introduce count_partial_free_approx()")
Signed-off-by: Bert Karwatzki <spasswolf@web.de>
=2D--
 mm/slub.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index a3b6f05be2b9..a547ed041bc7 100644
=2D-- a/mm/slub.c
+++ b/mm/slub.c
@@ -3226,6 +3226,7 @@ static inline int node_match(struct slab *slab, int =
node)
 }

 #ifdef CONFIG_SLUB_DEBUG
+#define MAX_PARTIAL_TO_SCAN 10000
 static int count_free(struct slab *slab)
 {
 	return slab->objects - slab->inuse;
@@ -3293,10 +3294,6 @@ static inline bool free_debug_processing(struct kme=
m_cache *s,

 	return checks_ok;
 }
-#endif /* CONFIG_SLUB_DEBUG */
-
-#if defined(CONFIG_SLUB_DEBUG) || defined(SLAB_SUPPORTS_SYSFS)
-#define MAX_PARTIAL_TO_SCAN 10000

 static unsigned long count_partial_free_approx(struct kmem_cache_node *n)
 {
@@ -3332,7 +3329,9 @@ static unsigned long count_partial_free_approx(struc=
t kmem_cache_node *n)
 	spin_unlock_irqrestore(&n->list_lock, flags);
 	return x;
 }
+#endif /* CONFIG_SLUB_DEBUG */

+#if defined(CONFIG_SLUB_DEBUG) || defined(SLAB_SUPPORTS_SYSFS)
 static unsigned long count_partial(struct kmem_cache_node *n,
 					int (*get_count)(struct slab *))
 {
=2D-
2.43.0