Received-SPF: pass (google.com: domain of linux-kernel+bounces-155225-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <c8a7744c-2225-4fd8-9ee7-bd513a4668cd@collabora.com>
Date: Tue, 23 Apr 2024 18:26:53 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 3/4] drm/ci: uprev IGT and generate testlist from build
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 =?UTF-8?Q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Cc: dri-devel@lists.freedesktop.org, daniels@collabora.com,
 helen.koike@collabora.com, airlied@gmail.com, daniel@ffwll.ch,
 robdclark@gmail.com, david.heidelberg@collabora.com,
 guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
 linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org,
 linux-rockchip@lists.infradead.org, amd-gfx@lists.freedesktop.org,
 linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
References: <20240423040243.448091-1-vignesh.raman@collabora.com>
 <20240423040243.448091-4-vignesh.raman@collabora.com>
 <e3a0ea8f-d306-488c-a69c-aa18078e5e03@igalia.com>
 <CAA8EJppaaitcXkXSFTB4-S2CbBcrAVHouB0wWiU5Nw2FvpagqA@mail.gmail.com>
Content-Language: en-US
From: Vignesh Raman <vignesh.raman@collabora.com>
In-Reply-To: <CAA8EJppaaitcXkXSFTB4-S2CbBcrAVHouB0wWiU5Nw2FvpagqA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 23/04/24 17:53, Dmitry Baryshkov wrote:
> On Tue, 23 Apr 2024 at 13:24, Maíra Canal <mcanal@igalia.com> wrote:
>>
>> On 4/23/24 01:02, Vignesh Raman wrote:
>>> Uprev IGT to the latest version and stop vendoring the
>>> testlist into the kernel. Instead, use the testlist from
>>> the IGT build to ensure we do not miss renamed or newly
>>> added tests.
>>
>> Nitpick: wouldn't it be better to (1) stop vendoring the
>> testlist into the kernel in one patch and then (2) uprev
>> IGT to the latest version? I feel that this patch is changing
>> a lot of different stuff.
> 
> Definitely. Otherwise it's hard to understand whether a change to
> fails/flakes is caused by the uprev or by the testlist change. E.g. in
> several cases the list of failing subtests seems to be replaced with
> the test itself.
> 

Yes, will follow the below approach.
1) Use the testlist from build and update fails/flakes/skips
2) Uprev IGT and update fails/flakes/skips

Regards,
Vignesh

>>
>>>
>>> Skip kms tests for panfrost driver since it is not a kms
>>> driver and skip driver-specific tests. Update xfails with
>>> the latest testlist.
>>>
>>> Increase the timoout of i915 jobs to 2h30m since some jobs
>>> takes more than 2 hours to complete.
>>>
>>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>>> ---
> 
>