Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2933222lqt; Tue, 23 Apr 2024 06:14:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWpMSbgqDiq8fYscUmK1NXftO2985SuMqDoCW3noAyMYAv1QAnclWLmeZE/tPtRrbzQx8QWYXBjh8nBTvx1P+BDqQLtOIYHUwtYVKtIAA== X-Google-Smtp-Source: AGHT+IHUE7TM18ar8DyW6KDRnqyW1TET+KlXunhDMFqEAaM/AvKyoLbWDS3Jf7U9NWeVVzxHTYKt X-Received: by 2002:a05:6a21:398a:b0:1ac:d36d:dc40 with SMTP id ad10-20020a056a21398a00b001acd36ddc40mr13266888pzc.17.1713878095082; Tue, 23 Apr 2024 06:14:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713878095; cv=pass; d=google.com; s=arc-20160816; b=XrPR/lLbY7AqoIbyMKqxs0q3CRs5K9uobeuZpD5VHau3MFzMARZspQcz+d3uleFKCa idNPSNlm4N7tK4EcT0Ypw0JkvuQ84HRYC7Cktv1NwVbxpz439voA0E+9eudPgCIcpxaV ZIB+Rc9D+IPjYAJ8BnWPIfFrq//CRNR936FTT4o9QGhM6dqA6kcCRuyvKSjSD7pEEDnh N2WAbBvY0wL6uNQC+6GG1W51dfZucmRrY0dn5K+TxsD0+VMPDFq/yDWBaE6p57mDbPQC 3t1+m0UmN3N8RcPGe0Ypog50sT5Q8KB6zDSN85ULvdclhPYIhL9CoBP2xSommfogIIGQ 8CbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=dfWMwHQIpw4zS3iFGNbv1FwxyBMpqPbqqndAtgdwOvo=; fh=xmc6abdzZgmlxCrPfnxRPrSOhL1PGNB2CV4ylSBbDdA=; b=xwWHabhb0sC4HK5dCTSz3vWx46o0tg0NKiy/0VeSU/RnoqOA/905bB5GT83yvKS8HB 8ajc31cWrUwhW3HmcdRUAjQv+38jd92xA7Z3shZGq246kxmx20BUWikvTyQF1mjtwTLz lMdAgg3UbgAk9VsaBz6pyiddcrSMvkoC397y2+xUeMR+ReaWNSmzdARxulXMqGf9nogS buWyZU70Yp2MJXW/Z2420W8Qrnt/ANdaykd4gP2lTftgG2Mh1iYeWCDoVLwscUNxBQJ8 fquAl0DgUuwoISxHko41FX04rClxjEdJjKM5ndP0+2Dh2puGLF3/kvYFxEGixL9jCcAi HB5Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=STZkVB2x; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-155229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155229-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c7-20020a637247000000b00601f0c1d8bcsi2354989pgn.715.2024.04.23.06.14.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 06:14:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=STZkVB2x; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-155229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155229-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E5A01B22EFA for ; Tue, 23 Apr 2024 12:58:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 32F2E86AE6; Tue, 23 Apr 2024 12:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="STZkVB2x" Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFAF97E765 for ; Tue, 23 Apr 2024 12:58:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713877128; cv=none; b=WDiIxgl6QvzJhZDAWgE3YzLAys1P7cY4LNWBck0YQeSphD+xx9EVHMRFOgCeh0Y7MLVyuyj7UOCAKp5wnVIgT2/W4GQO4uSYQTxHqskbwBkw0kAAzD/rbzc0jI5IP+AhOBvgz/S2dsOOMkAKm40myC83oTmQkiRF5Yd1nEpClQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713877128; c=relaxed/simple; bh=C38jNkPQIY9PbuFlXsBJRUbs0C33ZReaOCMWgYaSpZI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=k58jjb83nIVbES6/Uo1n3Osej+LYW+tB52eOICmTimDajIW0ICbhsRc816hyoArZtmvqfV1DHbxpHBKvs+kmB5e9DLCEaXxo5vCic4yz6F5ne3HTZN9KfygiAMlU08HlEVkTgreqx1sbdKeZKUnDgsbJir0qwFET74fzNW3GMUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=STZkVB2x; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-51acc258075so4693587e87.2 for ; Tue, 23 Apr 2024 05:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713877124; x=1714481924; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=dfWMwHQIpw4zS3iFGNbv1FwxyBMpqPbqqndAtgdwOvo=; b=STZkVB2xoG0zGbe9KBS4l7UH0vv9pJ3uqHQVktFP/nzt+wghIG27zyNGC56W9J9hmI 43DRQKtRQuosG2bct4YVMylVhh9nwYUWGUHEjKysZqPw/UHR0Uv92W6WkJ0VXYuc6Smt BWaYwKmgUQqEtvxBpoVKqlqkHVk+h6/R8Wcg5q3JKvCZrO7Dt2NG9E9C1VGhlsxgHqtW eM8gSV9mnZX/Wo+t5Y5LkTyZh04tvNZkxqBRol+vp/On7hTRtDhbhRnZ9Adk0t5xzTLP eZCtyJhWnyfGsrra6IeeNbX8ocQs3AxL5W99M3RJo9TCZvLiWJFcoiJoH2DrkgU89iNR HNNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713877124; x=1714481924; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dfWMwHQIpw4zS3iFGNbv1FwxyBMpqPbqqndAtgdwOvo=; b=jHSDtFUjOKtF/GgOkKbQf42ZJkOZI54TVffTQl1meX2jGi168Gyfvxg3sbAMXTdrY0 oXeVCruDxRpU3g+tccy3MmBiLri3I9rnozVMeNX+h8IMP2S8ge9K0ZtvwASplhvXnSia t9ohABoAN89kdHIgGp5qNhyt2Zs8rbPoed8X2tiCl+k/fAZvnqlhdULeOSzYzPbDyn/z ttPSpJGYwXbY4r9FyBRITWoeAIZMqvh3gz8F7MBgQRaeBpNoDiu3/B78+OwBcOwf3+dc FvSm7b9STc1esMOQzXW1Lgr1F7WeT/govcSNETUVdC6igMq0QuTNUTeDLffxMMsAOIzy s7sA== X-Forwarded-Encrypted: i=1; AJvYcCXd41nKYLoUG+B0ek/lrJS+zaTuxMzMMC3uFMhS0sdm9TSF0toScF034eOb+Qubl49z9uimTRdQxJAR0xv1JhWS+rbQ/CZmh/WzH/9m X-Gm-Message-State: AOJu0YzUtFY5WngSYMu9DlQathWjtk27mQUMX98XQXbXMCtUHr++JyeF EBDVD6+vWAcgQxVLdKFO4UyXeGTqwA/qZFltfcnexLNkr5yZN4SgaHAqo47Itc8= X-Received: by 2002:a05:6512:3712:b0:516:c8e5:964e with SMTP id z18-20020a056512371200b00516c8e5964emr6801237lfr.21.1713877123745; Tue, 23 Apr 2024 05:58:43 -0700 (PDT) Received: from [172.30.205.0] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id c12-20020ac2414c000000b0051ae53e9afbsm1148796lfi.92.2024.04.23.05.58.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 05:58:43 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 14:58:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 6/6] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc To: Varadarajan Narayanan , andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, djakov@kernel.org, dmitry.baryshkov@linaro.org, quic_anusha@quicinc.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20240418092305.2337429-1-quic_varada@quicinc.com> <20240418092305.2337429-7-quic_varada@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240418092305.2337429-7-quic_varada@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/18/24 11:23, Varadarajan Narayanan wrote: > IPQ SoCs dont involve RPM in managing NoC related clocks and > there is no NoC scaling. Linux itself handles these clocks. > However, these should not be exposed as just clocks and align > with other Qualcomm SoCs that handle these clocks from a > interconnect provider. > > Hence include icc provider capability to the gcc node so that > peripherals can use the interconnect facility to enable these > clocks. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Varadarajan Narayanan > --- If this is all you do to enable interconnect (which is not the case, as this patch only satisfies the bindings checker, the meaningful change happens in the previous patch) and nothing explodes, this is an apparent sign of your driver doing nothing. The expected reaction to "enabling interconnect" without defining the required paths for your hardware would be a crash-on-sync_state, as all unused (from Linux's POV) resources ought to be shut down. Because you lack sync_state, the interconnects silently retain the state that they were left in (which is not deterministic), and that's precisely what we want to avoid. Konrad