Received-SPF: pass (google.com: domain of linux-kernel+bounces-155271-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <c8b72a0a-93af-9024-1fec-5cd56b57a933@oracle.com>
Date: Tue, 23 Apr 2024 09:20:34 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] admin-guide/hw-vuln/core-scheduling: fix return type of
 PR_SCHED_CORE_GET
To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        Josh Don <joshdon@google.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
References: <20240423-core-scheduling-cookie-v1-1-5753a35f8dfc@weissschuh.net>
Content-Language: en-US
From: Chris Hyser <chris.hyser@oracle.com>
In-Reply-To: <20240423-core-scheduling-cookie-v1-1-5753a35f8dfc@weissschuh.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QlMyWFRiYXpGSnFmM0xDT0xjaEUrSnVuNXQyOVlGNG5sa0xQeVFhU1NlTHVk?=
 =?utf-8?B?R21ta0lVTmdaZm9HSUkwNnd2ZytrM3k0cUtCTm94bGhYWVNsTEo2NWlKTWpJ?=
 =?utf-8?B?QTNVd0pFRHpUVGY2YjJOdkNjdU1nK2xXcHBHZFYvblRlSDNjSTlsSndNR3Rx?=
 =?utf-8?B?MUNwMFNJM1ZXTXl1MVR6MkZuNzRLRFMzdWRhTFQ3RzkxSm44UlNzVk5XU1kz?=
 =?utf-8?B?L3ZVU0pRZWU1TC8wWExNQXdBNlkxbDRFSVZRMTFQbkdFalFrOTNEUXJ4YzVj?=
 =?utf-8?B?alFHV3RwWEdsM09xaittWlNVSFQ0T2NQR0dod2JmelN1dVRYNHgvSG02Nmo1?=
 =?utf-8?B?bGRGYmtlZjZISUJDayt5SnUzUm1wTFAxYmg1c2JSTjRXVmpuM2llVmY5YUlw?=
 =?utf-8?B?cmZsd1oxUTFBUFVseStYSmZpb0hiMEZNb0h2aVFJSHFER2VkTFlWbTYrai9T?=
 =?utf-8?B?MTNEQzd4VVl4cHhNTkF6ZFZHMUxyYVB4eFhzTDFhSGFHL2hYUHUwQ2llYXYx?=
 =?utf-8?B?bXpwQ2RCRkxkaFQrTWtETW5Lam9oc0VMTUJIZ3dsa0U5eENtcjFpeGxxUlNX?=
 =?utf-8?B?c29HTThxVTc3VGJ2d1JKVXpwTmZnNkRRdkU1ZXFwaGlSVE1kTDFhSHU4Zml2?=
 =?utf-8?B?c2xsclRGZ3dpZ0htMTVTcnY1YTFCR0JQQVdrdFdNelFNZnZ1MGJpMXY0dGtF?=
 =?utf-8?B?U2NJTTNxMkIrTHcwVE14eFdwK3NOZThHL09iSzFRc1JHSWxNYUlTVTFTcldp?=
 =?utf-8?B?UVlSV1pvb0xFbjRkaER3Ymhxem9NdzJMcm9hdWFqRWhjNGJZVlJsU0xXanF5?=
 =?utf-8?B?NXA1MmNyTjIvZTZyQ3NwR2JSTXNFRGdHTWNIR2J3cU9VS25jQmVtQkJ3OWhG?=
 =?utf-8?B?YkdpRXlmZ1gyVzhGWHRuU01uQmhvVC9hZW1ZcVUwWGsxdGlXTmgwcG82blBm?=
 =?utf-8?B?Rjc0bkk3b0g4OStvUGNEN1QzTU9qYUZUVmtVckkrUmdlK1hmcW5mdURZRC9l?=
 =?utf-8?B?bWtuNC9QQVpMS2tMdVl1S3dSTWs3VUoxU0w5Y3BWUmlqQjRMekNzVnhRUndD?=
 =?utf-8?B?QXljRkZSWEUySHdPUEtiRnRJZlVmdnV4Zm1Mb09HcmFEWURkcFdIeDRqUS9w?=
 =?utf-8?B?TWtiSk1nR0p5dU5xb0k4M0Uwei9UeFV1S2lqbGs3Rk9YK25LMUhpOTdjTUdq?=
 =?utf-8?B?ZUVJNC91NlBvMnpUK091TjFxQ3RVRkFTQkg1TVhRa1doWnAvL1NZclJNWXVk?=
 =?utf-8?B?OVZKZ3Z1M1ordjZ5UzVzMjRTOWg4SldrRENsWnN3eTBqQ1I3RjQ2Z1NrejVR?=
 =?utf-8?B?T1RjcEVYa21lMnJjMllSTlVKL3dWL2dzTmJSYm9PL0dQRy9qQWRaNndHKzBF?=
 =?utf-8?B?cmFjOS9BeERrYmwxK1c3K3YrYWFiaDVzbDk0Z3YxTmJXNXFRMTZwTUsxeG56?=
 =?utf-8?B?OG9NVjh1K0EzMC9aUjFzbjdYOEdqNnJNT2dFVklJVWFIK3YzdHM3d3NIK0lE?=
 =?utf-8?B?TmJWV25ER3dZYXgzRnQ0alI2OGlZb2ZIZTdnUCtBY1ZXNzVoM2JGbEF1OU9B?=
 =?utf-8?B?cXdSOTl3dndqeEt1b3o3Tm5PRFhaaStwNURCOE1CTEFSN3JxcGNHeHJWZHVp?=
 =?utf-8?B?aXMrS29MbkY3WGVnOTJyT09NUWZqVUpFamRNeU9aUlQwRU1aeTNtZzcvOXgx?=
 =?utf-8?B?UW5nTmtIZnN6QldwSHBCQlpPNDNURS9QLzc4WU9PMmpnSitPdWZzbFZ1NnR4?=
 =?utf-8?B?d3J4VlhXYTNTbTE2c2RnTVhOQkQ2Qjl3RElibE9hTVV4Q3Jrbk5ZaFVHTjNn?=
 =?utf-8?B?eWI2OWlFa2NTZzBoUHk2VFZ4V1VsZGV5WFl3MXFSa1ZwQ3ZGTW1tN2E2VjlJ?=
 =?utf-8?B?Yi9oK3N2RHBDQzRKeGJWUVVrNnFnd2h0ODlWYkhvVHhVd0RxTXNzeEsyWW5T?=
 =?utf-8?B?OXh4SFM4S24wdWFOTnVUK1EzRHI2cWpjZXQ1MTlOVWxiakZzTjRoL1JZWVNZ?=
 =?utf-8?B?cG9PcGYwRWJSMkZ6L0Fnb1ZIVlZlZE9YTzJHT3JhZEMzTkRiQmJ0NUJYUUN4?=
 =?utf-8?B?VXpxMm9CQjd4TGdvQjdHM0ozM1pWMy8vWjdOVmx6NVQ2bGptMkZaZGJmZ2ow?=
 =?utf-8?B?Qk9HOHRiVE5BVXV3TSt4eTNEcUxUUlV5L2JTbFc1WDVrSkR3M3hkRWFYVTVV?=
 =?utf-8?B?bnc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	h3hRAqZMO/9RtDCofg3J3hm5nz9N0kqojrNDTwNAdHDofzMhpTeuiDAu/uDB0Tn5akMhESKRTEtecMGiAcrgKgw2V5ysuQ/y9/3MHjY7MZ5CvlWToMA5m5x0P62XNCNEXcd4C802F4J9BmRnF5cWiPdmE0BoSVfM0fzEdNxUGwmmSVi/L8xSIv1HTcr18UDnSv6LMlXJ+KhDT4GS1iHywCw7HgSA7F6RjM0Jvr0PbOnKmMWYFzDfP7mdMd48//klrZ5Ta34APJxVoJr2HY7UUXvBQSjK5JBaWkuEWmecQRq5J9uG0HlYzaAZ008VnnKRtglYUuub0dPlUkboZqjsFpy9Wo/q/0G62vhCqoyNyxabRM5Gv9aKJKorfpAnZSzssb7l6ZRiM+0rRkETTcZtmTglNo5TmtnG7leRS512DJVMCpuS+p7bmCA0YQmHnrMmoXk7qcK2fIHGXvg44sqKoGrTcJE6/2KAC3FfATLXVB+doycnK35OJAUQMg3dATc4HqcZ0UlU9jffGdPzar+9NAlvt2+siG6FERugnAPgu/z6oTujg62CSbpZur/+lC0WsG+b2VQluhbmcrwChKfpST7e4LUpJRkhy2Ay7R/j3/s=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1af50238-c58c-4a0e-5dc4-08dc63982abe
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 13:20:38.4669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 88k+y4rUFL+eNPFGm7SypmbBsCn3AL9XQoWQzU5DoQ6ofY+p8tZLheStvawl3Ey7FANydzTJMsCYQ6BE5Zi4vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5973
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-23_11,2024-04-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404230033
X-Proofpoint-ORIG-GUID: aLzSRgbjSFTHyLFdJd5ZyV6y-F_BwCOa
X-Proofpoint-GUID: aLzSRgbjSFTHyLFdJd5ZyV6y-F_BwCOa

On 4/23/24 06:34, Thomas Weißschuh wrote:

> sched_core_share_pid() copies the cookie to userspace with
> put_user(id, (u64 __user *)uaddr), expecting 64 bits of space.
> The "unsigned long" datatype that is documented in core-scheduling.rst
> however is only 32 bits large on 32 bit architectures.
>
> Document "unsigned long long" as the correct data type that is always
> 64bits large.
>
> This matches what the selftest cs_prctl_test.c has been doing all along.
>
> Fixes: 0159bb020ca9 ("Documentation: Add usecases, design and interface for core scheduling")
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/util-linux/df7a25a0-7923-4f8b-a527-5e6f0064074d@t-8ch.de/
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>   Documentation/admin-guide/hw-vuln/core-scheduling.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/hw-vuln/core-scheduling.rst b/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> index cf1eeefdfc32..a92e10ec402e 100644
> --- a/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> +++ b/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> @@ -67,8 +67,8 @@ arg4:
>       will be performed for all tasks in the task group of ``pid``.
>   
>   arg5:
> -    userspace pointer to an unsigned long for storing the cookie returned by
> -    ``PR_SCHED_CORE_GET`` command. Should be 0 for all other commands.
> +    userspace pointer to an unsigned long long for storing the cookie returned
> +    by ``PR_SCHED_CORE_GET`` command. Should be 0 for all other commands.
>   


Yes you're right, that is what the test code actually does.


Reviewed-by: Chris Hyser <chris.hyser@oracle.com>


>   In order for a process to push a cookie to, or pull a cookie from a process, it
>   is required to have the ptrace access mode: `PTRACE_MODE_READ_REALCREDS` to the
>
> ---
> base-commit: 71b1543c83d65af8215d7558d70fc2ecbee77dcf
> change-id: 20240423-core-scheduling-cookie-b0551c40b086
>
> Best regards,