Received-SPF: pass (google.com: domain of linux-kernel+bounces-155277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 23 Apr 2024 15:22:52 +0200
From: Borislav Petkov <bp@alien8.de>
To: "Nikunj A. Dadhania" <nikunj@amd.com>
Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, x86@kernel.org,
	kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
	dave.hansen@linux.intel.com, pgonda@google.com, seanjc@google.com,
	pbonzini@redhat.com
Subject: Re: [PATCH v8 07/16] x86/sev: Move and reorganize sev guest request
 api
Message-ID: <20240423132252.GJZie2LGgVszU_XejZ@fat_crate.local>
References: <20240215113128.275608-1-nikunj@amd.com>
 <20240215113128.275608-8-nikunj@amd.com>
 <20240422131459.GAZiZi0wUtpx2r0M6-@fat_crate.local>
 <eadcab6f-b533-49e3-9aec-dc06036327f5@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <eadcab6f-b533-49e3-9aec-dc06036327f5@amd.com>

On Tue, Apr 23, 2024 at 09:56:38AM +0530, Nikunj A. Dadhania wrote:
> Yes, I had tried that compilation/guest boot does not break at this
> stage.  That was the reason for intermixing movement and code change.
>
> Let me give a second stab at this and I will try just to make sure
> compilation does not break.

Yes, you can also do preparatory changes which get removed later, if
that helps.

It is perfectly fine to have a couple more patches preparing and doing
the move which are trivial to review and verify vs one combo patch which
makes you stare at it a long time and you're still not sure it doesn't
change something...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette