Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2959038lqt; Tue, 23 Apr 2024 06:55:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXFXFF7inefvKjEkSRn+wZBguDCZpX0ZuFyKzryE/kEKdVJRsmhrgBfXPaYHBjAdYO8LIatg5Ed5Srwq5j+bRVeF5Kp51D0+zgpAGCKvQ== X-Google-Smtp-Source: AGHT+IFjLaaU7/Ef8dV8+fGtxKSFyL3TyNws7c4c4fPeP/+K/0CAbvfbXq6Y0OwpM362e9m+FnPs X-Received: by 2002:a05:6a00:188e:b0:6ec:ff28:df5 with SMTP id x14-20020a056a00188e00b006ecff280df5mr17396138pfh.27.1713880531188; Tue, 23 Apr 2024 06:55:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713880531; cv=pass; d=google.com; s=arc-20160816; b=V8hSto2VxElA0+zDRtxDwKUTO1XttUC3JFCZsY8FgVviElE9jyivxcM9s/LHDj/7N7 QnmhN34BCZZheQ+GUz38R2h6e8kNtvT6XqQOKdD8ls7G80NoEmRICu3hQyi+/9gWC4z0 MMDZd16qpl7ejagcW4sQWmnq2+vj3/UmPfoZVfGFmrQ7JEa8E2Wz/jdP7G69/5nESSC0 WhBB6TielCcAlHURgUahH57oR82GtuXRt2c2IiIazKzl1bF61hdw7d5b6MvlbmKuYXG2 Je/lq/sSQfzJPLdpeo5h9en4CQ6xWTxRIOgXnV8+B9H6cv4a0ckO2HsyaG87nxuq7jcK ygDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; fh=NmdW3TbMWHwGIwwNV/WiW3wNlmSHMZ1RGjDQeGvdHaw=; b=nvb2XO3gor0HG+Cy5A+3N/h6TrROV7U/FKRdvZcwm5PQgacCb38Rnq/Rl10LIB3TI/ gn8SbFKgTzuVjtaDi4At1J4238kqGbp1hEZP5Kiqp/8aw1J/q722shfOOsmD6RRxy9fm PnnYlq4gEJzAhE3qcVerQiXVQL7sD3q1AkmwzJOlt/sZIXPc+C8+oxBnREJBq5B8klyk mb0/l90I3nA6xK/SN46w5GnWa8Yu2K0G+/b/aO4KhjI7oLAMp6ATkGS+bqn5DSLFiLf1 cwHmoUEdilSsaAg6ProIKvZgUEUVVRdMfxyvRN5dquufms+OAL42C1JNir2l9byDGRAN KVkA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=rYatyu05; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=3J4H+zWP; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-155314-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155314-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b123-20020a633481000000b005f759a13e0bsi9620704pga.569.2024.04.23.06.55.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 06:55:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155314-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=rYatyu05; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=3J4H+zWP; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-155314-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155314-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 894D6284F09 for ; Tue, 23 Apr 2024 13:52:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02026136E0E; Tue, 23 Apr 2024 13:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="rYatyu05"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="kf/COY7l"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="3J4H+zWP"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="mIJh+WXZ" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9AEB135A5B; Tue, 23 Apr 2024 13:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713880351; cv=none; b=t6iIl307C+jmBOtLgBucIlT3cbMudJ50GBtCblFS5vLsZ6OekfDjRQSmcHBp47tSBptZPSP1t/TvYNbGv233ZvzehKK7s5CvguDsr1FqXIH4++UHyKDeR9ZokxTa6ImSuyAUzV44ZE947Y96zlE2jWzN0/lsHeuYVtvSVt+V5dY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713880351; c=relaxed/simple; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X1UJtZvvsmE1BSPocTDzg5/ZLtJybi9l5awT5SVldhlHQRPlfW1eWXHvEnKSuK21WpkDoVk3EsDe5/HjMbO7YFJM+cHBvcJ9ipT3Hd3Y3Uq5Kgviwi0EdmR1Iw/Nx0HxXguPZhz/XEZcWuN9lkKKH0YvWAP6/TQcB6jPsN33ZE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=rYatyu05; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=kf/COY7l; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=3J4H+zWP; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=mIJh+WXZ; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B9A0F5FFDE; Tue, 23 Apr 2024 13:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713880348; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=rYatyu05UZ5WqfVfLxuNOAWMy4W+PCssPHr/5n3oIhVfFL64DgPd0Ay5HoUsqmLklmASk0 8OoIuI8PnoWMfndsKm+RSUwVdQepQ49bCZ8MsoVBChreIEihIkL+k7BkuVrC0WLyJcDv/2 PYh1rQcPsG4G/8bH57kDhgo00wpDexw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713880348; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=kf/COY7lXjOGh1SP1uOSoH0J1Gjot3A704KY9ffiUAs2Q9LT1OtQP/LLG8z1DQ/KUbcggf k+kB89sdmk6QyhBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3J4H+zWP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mIJh+WXZ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713880346; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=3J4H+zWPsS0SxnmdTAdUwVpRt8QPEJyJ3CMqNJgNI9RTJl+zewqgIwzP0gHnvwZ/Ber77Q DjASXm6+Bth5b2VEPuO60a++OL/FD0xz5gMhozkpx3TvLat9EZZ8GZUzaei6kCoXPaeQbc LeWLXi8D2X69TJy6tz6Rwhn3J4zHpsI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713880346; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=mIJh+WXZjqUkXb04mduTycZiYg5xS5Z83Im/3aErIrKZzpAtF4UHO+ifGdWuor8OvXfQGn sDHMfHO6sAdNH/DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7BF7013929; Tue, 23 Apr 2024 13:52:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1BinHRq9J2aecAAAD6G6ig (envelope-from ); Tue, 23 Apr 2024 13:52:26 +0000 Date: Tue, 23 Apr 2024 15:52:25 +0200 From: Petr Vorel To: Christian Brauner Cc: Cyril Hrubis , lkp@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel test robot , oe-lkp@lists.linux.dev, ltp@lists.linux.it, linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Andrew Morton Subject: Re: [LTP] [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail Message-ID: <20240423135225.GA195737@pevik> Reply-To: Petr Vorel References: <202403151507.5540b773-oliver.sang@intel.com> <20240315-neufahrzeuge-kennt-317f2a903605@brauner> <20240318-fegen-bezaubern-57b0a9c6f78b@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240318-fegen-bezaubern-57b0a9c6f78b@brauner> X-Spam-Level: X-Spamd-Result: default: False [-3.68 / 50.00]; BAYES_HAM(-2.97)[99.85%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; REPLYTO_EQ_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:replyto,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: B9A0F5FFDE X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Score: -3.68 Hi, > On Fri, Mar 15, 2024 at 03:49:03PM +0100, Cyril Hrubis wrote: > > Hi! > > > So I'd just remove that test. It's meaningless for pseudo fses. > > Wouldn't it make more sense to actually return EINVAL instead of > > ignoring the request if readahead() is not implemented? > It would change the return value for a whole bunch of stuff. I'm not > sure that wouldn't cause regressions but is in any case a question for > the readahead maintainers. For now I'd just remove that test for pidfds > imho. @Matthew, any input on Cyril's question please? Kind regards, Petr