Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2999460lqt; Tue, 23 Apr 2024 07:52:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU9jz+/LD/u+Jyl0uooQjshdNdDtQa1mZ6Hhf1IYWrv7ThBE6uPSBy4GDj88HBqoI93+GMlJ6n6O6qOAdU46S/LY476pipcNazkmVT+pg== X-Google-Smtp-Source: AGHT+IGRzXrTORVwjrWwhEbv1Uqn6l3JR51gq3bxI345EoPIoJRfRekXa6sw9t8JPawYbslaiQ7e X-Received: by 2002:a17:90a:6587:b0:2af:8d8:c90a with SMTP id k7-20020a17090a658700b002af08d8c90amr372697pjj.5.1713883932266; Tue, 23 Apr 2024 07:52:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713883932; cv=pass; d=google.com; s=arc-20160816; b=VnTdVpJkroCpaMpXlYP+lUeDZiBpJls+yz4+niAbpu168WO2oHYbncbfDtE9HyN5zw 4UQrVI5BueodXQbDhSIXg3BvbYVx3nqqHB+EEq6SCLtI+Ig/izVv1YXF3anN1TyDVOgj RzM0HOc2hUHKw+pM9B00UwHuglhhf1Lblk7HV+CMNkPwcS65ppT+uRQekD8Ah8a4D+kN Wi8sr/w2WKaG4FlzwnGmArUZTgpCTvinHBTU1T12RTSeMukCX9vm6zxVzYElQJr98mxB RKMV6+jD5+t2x5nBZfft0D+uZW6yIOr7DpH0b3vhcTRcacXCOC/5LAHRt1zt0bqDsYps d/lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :reply-to:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=ERxOOMezRAufIKqgnoffsNNUlab+BjMEAF6+1TvdqL0=; fh=fAf2inQR0v8PwWCAinlozhlV5aWEv+e2Pyg63KGwzqM=; b=H2M17wTvw6+Uju3AuGy5fV14/dlFHcZfwr+nUZm03kQWMHFAtYoyyTpeku0sGULSrz /tiDjhrpDP6SUlw51xUmr+nGJTaFVg8v9U/GSL5xE7Akkj1eDCR3AHqAi7gmRCQV92F8 Yq+SDt88C7rC9kWx6qS9xTBYZSpUN6+Ax7jvo5rN2JmsMsExzmXXaGbodwbyBqWx3/8H wo1DDZjmJRjCS3+KcRQW4ZOYmoQDA6YkZJdBUo5cJuaRKvKXDtvt5St/yDhYZglRAGd6 VEv9NT0EXDRW6jYan1yYINEvxKLcvs2JYzmtEvUbAjPxzXAZU+HNSkX+z8PAARaSzCjP NR4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=kYHpLDkH; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=iDgKYK0Q; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=1evyy4Cl; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=V3cxaLrz; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-155394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155394-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id bx24-20020a17090af49800b002a2aa681bd9si9520803pjb.170.2024.04.23.07.52.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 07:52:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=kYHpLDkH; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=iDgKYK0Q; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=1evyy4Cl; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=V3cxaLrz; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-155394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155394-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 53412B2301C for ; Tue, 23 Apr 2024 14:45:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69E2C13B2AC; Tue, 23 Apr 2024 14:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="kYHpLDkH"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="iDgKYK0Q"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="1evyy4Cl"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="V3cxaLrz" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBDD88F5E; Tue, 23 Apr 2024 14:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713883538; cv=none; b=UTVEySOiiJmVhxSdwZbOTrOdeXjxRD2VgAQuG9kuY0KgHYLI/ihGd4drhF8fsl7idjn5zuvdHwfQ8guBD33VUs1sdpV0fM8NFr5iIkA4Ej6zms2Q4KyAu++HV/wsGDIzUWolC/ucXSd9LncaNXmikx55j53uPHkkPmVdY50pdjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713883538; c=relaxed/simple; bh=gPByzlowu52gZBR0jPs98e/qH0LAV1N1EdaNJp9k5pU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q9edEq/S4EC2QfnlXWQXU+px8aSlsMGRKvnGpK1RZFviLVoyVNOxfnEkzJV+KJjYs4P71mX4r2O1X8h1ZPD8qL8EMfunLNR2XBiv8v8k921N/NbVYXfJlsoGG9nnkovhkrIwsAEH/T4wRhko422LWfjkT8NtCgOEY1OAfu2CCRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=kYHpLDkH; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=iDgKYK0Q; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=1evyy4Cl; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=V3cxaLrz; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E128D600B8; Tue, 23 Apr 2024 14:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713883535; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERxOOMezRAufIKqgnoffsNNUlab+BjMEAF6+1TvdqL0=; b=kYHpLDkHdRQHUO1ImpunLE2b+SuGC8tpIhIpKCZ3ftKd3KHoFYV0RoM07n6lxcqokvr2Sm 7cnoUIUEi2KVdSuiUTYx8CJ8sDJkSZ1tQjYoEiNC//Ea9w6saukAwUi8thmUw4EbqUTWzm tqSKhTzFHTVMA626W0tBctGtN6mUF3Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713883535; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERxOOMezRAufIKqgnoffsNNUlab+BjMEAF6+1TvdqL0=; b=iDgKYK0Qtdgpl1cAc8B+ZT8wMjb8Fks1FJhQJht044mBoApnXedDU1NrW5lYMjiXcgptoC YGEwQFgEDkW4K7Ag== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713883534; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERxOOMezRAufIKqgnoffsNNUlab+BjMEAF6+1TvdqL0=; b=1evyy4Cl+UoOgOnUIXg1/q4G5gjdSMMfixQ9AUFI3ZH1o4Ji3ZEE7xe6lduUFDUScD9NRC U+AoxYUdaKdUEymg+XTYyoA/OlCGQGJOFflWUcTAiJhTqG7+8L6hNXmyMTmVyOtLp+oUAg oI1Z3yPCLULJo7wFclpk/jYpNxpDkWI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713883534; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ERxOOMezRAufIKqgnoffsNNUlab+BjMEAF6+1TvdqL0=; b=V3cxaLrzAwF9PoRBfy+nEXrfs7bAIm0jGSbLKDT06xCnPrOa+fQwscTdxYcbeoWNhVGS/G CE18HfQ/g2ubJ+Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C4D4113894; Tue, 23 Apr 2024 14:45:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ESPiL47JJ2ZyAwAAD6G6ig (envelope-from ); Tue, 23 Apr 2024 14:45:34 +0000 Date: Tue, 23 Apr 2024 16:38:01 +0200 From: David Sterba To: Dominique Martinet Cc: Chris Mason , Josef Bacik , David Sterba , Anand Jain , Greg Kroah-Hartman , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Dominique Martinet , Pavel Machek , stable@vger.kernel.org Subject: Re: [PATCH] btrfs: add missing mutex_unlock in btrfs_relocate_sys_chunks() Message-ID: <20240423143801.GI3492@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20240419-btrfs_unlock-v1-1-c3557976a691@codewreck.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419-btrfs_unlock-v1-1-c3557976a691@codewreck.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Level: X-Spamd-Result: default: False [-3.69 / 50.00]; BAYES_HAM(-2.69)[98.66%]; NEURAL_HAM_LONG(-1.00)[-1.000]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[11]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:replyto] X-Spam-Score: -3.69 X-Spam-Flag: NO On Fri, Apr 19, 2024 at 11:22:48AM +0900, Dominique Martinet wrote: > From: Dominique Martinet > > The previous patch forgot to unlock in the error path > > Link: https://lore.kernel.org/all/Zh%2fHpAGFqa7YAFuM@duo.ucw.cz > Reported-by: Pavel Machek > Cc: stable@vger.kernel.org > Fixes: 7411055db5ce ("btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks()") > Signed-off-by: Dominique Martinet Added to for-next, thanks for catching it.