Received-SPF: pass (google.com: domain of linux-kernel+bounces-155398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2be6c0e6-416e-484f-9fa1-c4cb12486bbc@intel.com>
Date: Tue, 23 Apr 2024 07:48:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 085/130] KVM: TDX: Complete interrupts after tdexit
To: Binbin Wu <binbin.wu@linux.intel.com>, <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <aa6a927214a5d29d5591a0079f4374b05a82a03f.1708933498.git.isaku.yamahata@intel.com>
 <7d19f693-d8e9-4a9d-8cfa-3ec9c388622f@intel.com>
 <fe9cec78-36ee-4a20-81df-ec837a45f69f@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <fe9cec78-36ee-4a20-81df-ec837a45f69f@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3g2amg4eUVLRkZTNG11eDRQZnY3SThJQkhRSXA0ZS9WZTNyZDI4UE4zdGJJ?=
 =?utf-8?B?UVhic3MySUFlakYzb25sRGJGVVlKQ3BPeEVVVEpsUUdzZ0xIL3hWU1k4L0tW?=
 =?utf-8?B?aW5IemdQTzZROS9UM3ovUFp4bU5IU3BqRGE3b2pxeHNteU1EMUdKTjNmUDNh?=
 =?utf-8?B?c25PNURzNlRwS0ptM0F0cmphZE5hT1p3RTFxN1dWSTVvVldnaUdvNkh4bEQ3?=
 =?utf-8?B?ZjlDQWZnZXkydmc2dUFweVQzRzdCdjg2RG5mOS80UjlNNEdCNldWK1R3OGV0?=
 =?utf-8?B?K2w1VDhQTWFzZE1zamFDMmJDakVZT0txWjVhcm5aTG5iTHZsc2MyUDcraWlu?=
 =?utf-8?B?c0Q1OG0xSGJBL2h0WThwMll0cmk0SU9ualBSVGoyVVhqNTYxWjc4bGNCbUlW?=
 =?utf-8?B?eks4M0tjMnB1ODJ2a2JqSWZ4NUhJbE05VXBEL1BoR3BJM2JPTXdrQ2xLbGE0?=
 =?utf-8?B?amVJaktoR29JR3ZYUjhCVWM5WUdSQURFWGdQVWZmVk12cCtBa0RHS1VEbXM3?=
 =?utf-8?B?b3pxaEpzc3ZNQzNHOXFXOUMyT2J6K015Z1lJWjJLNEpjdGJ0cHVFTW5xTmJx?=
 =?utf-8?B?dnB6OU9RM1RKbDBlMWllRXNpSTYyMHBQQTZaV29XZ1k4WTgxUVJVWWlXWDU4?=
 =?utf-8?B?WXhrWm1YaE9DTFpkY2pKU1M4bUxDWjl2c3Z5QkVHK0QwaWd2Vzcrek1VcDlB?=
 =?utf-8?B?QTUwYUtGdm5OaHFZUWVhcGp1TVRhUmhZNVpJVzN4T0pGbGVEUzE3L3cyK05j?=
 =?utf-8?B?c2NQTC9IRnJJaEJiTzFrWFFmSEltV0hyYkdkWUxndXBaMUo3TkUzWmQwUTJx?=
 =?utf-8?B?R0hPUzZHWXMxZlpieWVsR1pLRTlTN0FLeUp2bzlhejZtQWxuVkQxb2F6MzFq?=
 =?utf-8?B?UXkrZXRFdDdWZmdJcHFXajBISHNRVnpNNVdjdmdEeW5vTkVwaEs4R1hZaytM?=
 =?utf-8?B?aVJ0ZHBzSVlqWDd5cTVSVVRJOGhsWERnblM0d0FwNGxpWWJ6RFJqYlRUT1RB?=
 =?utf-8?B?YTl2a0tWMXAzRm1PUTNmZU81L2JIa1V4RXFPcmZNYUVHVmNoek1pYTBVdCtD?=
 =?utf-8?B?a3luSXR4R25ZU1psQnlZNjFZVm92S1JJaUtWVUNDaFFYbWowQ0s3NTBzUFB4?=
 =?utf-8?B?cU9jSGZGc1pHTk5GcE9aeCsxREQ0YVhISHdkMWJzVkJVS2NaZFFXVXl2WUto?=
 =?utf-8?B?TG5iRTgyL3k2Vk9OVjlHeDhOdWJuWnJXL3cyaTdKSStUYU1ZWGVSTjROSm9T?=
 =?utf-8?B?bVE0K0wrY0o4ekVVZFQvNDhWT0dNWkpyU0t2S21Rc0pJWmttcUpyc3hPVkhX?=
 =?utf-8?B?QnIxUmNkTWhxREx2Slp3Tkx5c09DZ2VTcHNwR1pDQStzRS9hRGNBSkFnb2Ft?=
 =?utf-8?B?bnNuV0pSRDN0NHVXQkVmZGFOVVVlbjU1bEtGdDNrU3JNazRxWDRhcnp0N2dh?=
 =?utf-8?B?V1BYVDNzdkwxM0Jzb05mRjVtN2RYbGtubHdDUlhINW9WV0ZuNUdDcm0yd2ZJ?=
 =?utf-8?B?cDluZEd2aHhSWVNLU09EMEx1RHd0RzZFY0RLd3VRR1ZMQ3BmN0liYjRwNGhm?=
 =?utf-8?B?Q1dIMktYTXUrM0JTWEM5bjAvVlZGYWJYeVUzcUQ5bTRUQW9rakFkQkRWSjIy?=
 =?utf-8?B?bDNZTnFsWEdUQ2NTeDdodjVvekt0WlFubFpXYnhIcXFpS1U0WDFyZXpyVmZP?=
 =?utf-8?B?VXAyS3Rybmxlc2Y2bmkyZzJXcU5MeUp2M1pWdk50NFBqM3MrM1EwQjJ5b2ZQ?=
 =?utf-8?B?ZjBSMzJkTzZZdWMvUy9Kc3R3bXZvR1FJaVRFeFM3SjFKOGEvSmh4Uy9CMENT?=
 =?utf-8?B?UFBiOE4rVEVvSnFNbFRMZDhyL2pHelhrenIvSnBEZjgyNkM2YjZjQUdROEMw?=
 =?utf-8?B?ZWhXWGdkTzljZnJPV1dwckp0dkh5WXEyUTdlZW1TQWV0dHVFa2xRVnN6TjNW?=
 =?utf-8?B?eTR2amhHZFZZSnFZMzdMYjFwckdUT2ZjRmlMd3h6dWc2VjJvUzB4RE9kNEJY?=
 =?utf-8?B?VGJwQ1JVYlhzaDF3YndkbERmQTRXdmxNSzcweXZIbzhUdzN0aVZoSnpiL3oz?=
 =?utf-8?B?VjdSMDdlc2pxaEV3d3JVZE1MRHFEK3Q2WWdOMC9yWjJKcVBtMGl6aFZVM0oy?=
 =?utf-8?B?eVdQRk5ZdUtiNHlGZENyTGFveHhIUkRVTysydzVWbk5LN240eUFqZ3RLYW5P?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab931a3-1467-4481-7de4-08dc63a4653c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 14:48:10.5522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cc6/FGSPPmBAo4V7MU3hLRDLlPbYcCkJ4Y63BXC0an4c7MNs+LaTUZ2jZzy3PJG0DuYhkJevjdeJKBAzhGVVK16G6vxOpdpzCVgr2pJirDg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8255
X-OriginatorOrg: intel.com


On 4/23/2024 6:15 AM, Binbin Wu wrote:
> 
> 
> On 4/17/2024 2:23 AM, Reinette Chatre wrote:
>> Hi Isaku,
>>
>> (In shortlog "tdexit" can be "TD exit" to be consistent with
>> documentation.)
>>
>> On 2/26/2024 12:26 AM, isaku.yamahata@intel.com wrote:
>>> From: Isaku Yamahata <isaku.yamahata@intel.com>
>>>
>>> This corresponds to VMX __vmx_complete_interrupts().  Because TDX
>>> virtualize vAPIC, KVM only needs to care NMI injection.
>> This seems to be the first appearance of NMI and the changelog
>> is very brief. How about expending it with:
>>
>> "This corresponds to VMX __vmx_complete_interrupts().  Because TDX
>>   virtualize vAPIC, KVM only needs to care about NMI injection.
>   ^
>   virtualizes
> 
> Also, does it need to mention that non-NMI interrupts are handled by posted-interrupt mechanism?
> 
> For example:
> 
> "This corresponds to VMX __vmx_complete_interrupts().  Because TDX
>  virtualizes vAPIC, and non-NMI interrupts are delivered using posted-interrupt
>  mechanism, KVM only needs to care about NMI injection.
> ...
> "
> 

Thank you Binbin. Looks good to me.

Reinette