From: Rusty Russell <rusty@rustcorp.com.au>
To: Greg KH <gregkh@suse.de>
Subject: Re: [GIT PATCH] driver core patches against 2.6.24
Date: Sat, 26 Jan 2008 20:19:01 +1100
User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       Tejun Heo <htejun@gmail.com>
References: <20080125071127.GA4860@kroah.com> <200801261550.58337.rusty@rustcorp.com.au> <20080126053509.GC27403@suse.de>
In-Reply-To: <20080126053509.GC27403@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801262019.01590.rusty@rustcorp.com.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1159
Lines: 31

On Saturday 26 January 2008 16:35:09 Greg KH wrote:
> On Sat, Jan 26, 2008 at 03:50:57PM +1100, Rusty Russell wrote:
> > That's pretty early, and before this backtrace.
>
> But that doesn't catch the case here, of trying to load a module when
> the code itself is already built into the kernel.

Ah, I missed that, sorry.

> For that we are 
> relying on the sysfs core to tell us we have a duplicate name problem,
> which happens much later.
>
> Is there any test you can do sooner, or is relying on the sysfs test
> acceptable?

As you pointed out, that's always been a "configure your kernel correctly, 
stupid" kind of bug.  Nicer would be to have a list of in-kernel "modules" 
generated by the build system, but sysfs is there and it's easy to hang our 
hats off...

So, no objections to this with that as a FIXME, and a change so the message 
says "module is already built into the kernel".

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/