Received-SPF: pass (google.com: domain of linux-kernel+bounces-155497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4cd220cc-2e8e-4193-b01a-d3cd798c7118@amd.com>
Date: Tue, 23 Apr 2024 10:43:25 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)
To: Dave Martin <Dave.Martin@arm.com>, Peter Newman <peternewman@google.com>
Cc: corbet@lwn.net, fenghua.yu@intel.com, reinette.chatre@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 paulmck@kernel.org, rdunlap@infradead.org, tj@kernel.org,
 peterz@infradead.org, yanjiewtw@gmail.com, kim.phillips@amd.com,
 lukas.bulwahn@gmail.com, seanjc@google.com, jmattson@google.com,
 leitao@debian.org, jpoimboe@kernel.org, rick.p.edgecombe@intel.com,
 kirill.shutemov@linux.intel.com, jithu.joseph@intel.com,
 kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
 james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <ZiaRXrmDDjc194JI@e133380.arm.com>
 <CALPaoCh5DDmojnkUZPnACkq_ugwKnqCnwLHj2sV69TSTzpAL9g@mail.gmail.com>
 <ZiervIprcwoApAqw@e133380.arm.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ZiervIprcwoApAqw@e133380.arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qm03aHpJZXA4RDU5Wk0xU3ZmN1BnbHhHWHF1NE01cFJxbVJzdTZEb3RHMkhr?=
 =?utf-8?B?cXlOalpHWE5HMXRSY0w5aFBiUDRkZURaczJpaTFlODhQTk9ZNnYxOE9kM1Zi?=
 =?utf-8?B?WGxyREVaNDV1eVlQdFBkV09jU05GbVR6REF3NmUwdXFmWk9Dc0d5eFJiRmtm?=
 =?utf-8?B?cm9uWkJTVkZWTkhJVGw3OXRoLzZNTnFXR1hJS3N6bVFwZW50WEJCdHBSOHB5?=
 =?utf-8?B?NTI1TVFEOHpZakxGMWUrMG9aSHVuN3pVZ2dVMWVNK2FaVnJSMURkd2s2eDli?=
 =?utf-8?B?b29YcmEwMEdxV2VCbkcweGpabi9MWENlaFZrVCsrMVpzM0J5cHlleDJqSk55?=
 =?utf-8?B?MDFpYzZHUTdydTBuTmo5V0VoMlJkMDBjeEg2Zmp5Z2RhNUZ1K3l3K25tRDJa?=
 =?utf-8?B?eEVvOW43MnUxMFhjcWgwRTIvRmRuWkQxRFFEQng3eVVFZDV0VHd2SjRVaVkr?=
 =?utf-8?B?QXo5ZS9HK0QrdTRmVlRtbGVCNUluMlluTkJ6MHVwVmtwZHVlMEJsdGdVM1lH?=
 =?utf-8?B?d2ZFR2NBVGhldE5vUWVlL2pNNmxURnVmUksrQXFYd1BZY0FRTjJvMkxBTUlV?=
 =?utf-8?B?ZnJYdlo2dmp5dDJQcUNadWxNanhOSGxqTWxsUmNSKzNDTTJVWlU2bXltOXFR?=
 =?utf-8?B?UGV6QXE3R0FlTndEVXBXcFc1RVkrNzRxNWE3QjlhbnZ3VnNPeVV3K0JhVDQ3?=
 =?utf-8?B?Titxd1JvUk00aS84Mm8yejdXbWJONm1VWWRSeGVVSStzMGtsRDVnYStKa3dG?=
 =?utf-8?B?elJ4ZFRNVnZ2QmZ2OU1DM0VCRkxXTmczRWh3T1hhWjhlZnZNQUV1VlVsNHNL?=
 =?utf-8?B?MzdabldySWxPVEgxSS94cXZWV09BcjFITHdwQjliZ2FhdXc1VW9oRmZMaXZR?=
 =?utf-8?B?UVlsODZ4Q21jNG5uL1RmSkFBQldiYXFrU0plOGlyZjJLY2pZVEZsR2Z0VFd2?=
 =?utf-8?B?OUhUeGZrZzlzYWx4YXJwRnlyeUdHdkxqTG8vNXdZUTJWdS83djZZc3ViNG55?=
 =?utf-8?B?azVJRXB3M0JKRyt5QkRBbHBIS2FaRVFySDBRUmVCTnErU2NGdVFIcy9oYW8w?=
 =?utf-8?B?ZDZsZXl2d2pvTU50Nk9TVjBCaSs0ZW9ITTdFbmt2OGsrbzBwcWNJOFZYSTFR?=
 =?utf-8?B?QkNiZUF3SWhBTWpMTnVVNVhRV2dPMFVPRHkvL2NvSnV5K2cyNzd4YlNBZkdz?=
 =?utf-8?B?MkwxbkZ5MG1LaUVOQXhhcm11dlh1U1lMMm9MdVBUV0dDVjI5clg3cmVCTzNp?=
 =?utf-8?B?RWI2YWg0Rk1EdTBKc01iTnZxTCtheHhZTmtoZ3JsZ3R4UFZrKzJ0WmRJVWcz?=
 =?utf-8?B?VU9COHRJZm4xcnlMU2V0MSt3MkZNUG5MTjlKSzRNWnRZQklwdFRSNldRTG1F?=
 =?utf-8?B?VGpaejhRMUdMWmFaMDJkSDVlSXJWckh5VW1QZHA3T0NZcTBRY2pDU1FWVVBR?=
 =?utf-8?B?cFBsZGQ4bURseGRrUmVBaVJkczVDUDhIbC8rd1dwTTNtTUdUVXhSeXI1aEJq?=
 =?utf-8?B?SEZGcFdKTVpTVG1zWW4zbjd5MWE0ZnNscHJHUkRNTytCQ1hQNit5cWFIT0lz?=
 =?utf-8?B?Rm1vdHd6SDlWb0IvRUVMVUkvREVSenBWTkEzbSt0Q2w3bFRqUnVFNUdQRUlq?=
 =?utf-8?B?RHZkZkxSaW9TbS9ROVNIYTdjaUwyVFBQUnJpQUk0RVdWa1F2K0dmaUlCTENo?=
 =?utf-8?B?WE1YUVJhUi84SUxYdXVUVTJqQTVQWTl3ckt4Zzl5RlhoZEJWTm5Ja2JzV1lL?=
 =?utf-8?B?bzd0T1lCbFBsYW0zRzhxNGZqUUZqVmQ1eVpiV3RGZXc1empoRUZESW9YMDcz?=
 =?utf-8?B?a0xwZitoMzNPL09RUE1uZkIyQllUVFZhV24vSkY0OXNlR2xHemMrNUU5dTFZ?=
 =?utf-8?B?TWQzVVpOSFVIVWNrZmg4N29BbnlERUxwc21xekR5WWpDczc0LzRFSWJDSlpa?=
 =?utf-8?B?bkdrVjcwRVdvRjRVTXhJcWJtNUhFVmgxbWM5S0g3dnVUTzBacitBYnk4N2dQ?=
 =?utf-8?B?dWRrcHlXSm5EK1d2SXN3M3E3QnZIaHBPM0RaQnc4eXpXSVltUzZaNGE1cEVO?=
 =?utf-8?B?OVdGOFlZU0gybGZ0M05VOUo3bkRGUGN4eXMyV2tSclBmREJXSWtJZnVxa3hB?=
 =?utf-8?Q?R0fY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d13aabf-6231-400a-fa01-08dc63ac1fc8
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 15:43:30.0205
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QemCMceRqx6qkJaqA0VVs0lb0gxvbtfgapU81hpsy/nxVWII0h9TVCkyzVIccjkT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7646

Hi Dave,

On 4/23/24 07:38, Dave Martin wrote:
> Hi Peter,
> 
> On Mon, Apr 22, 2024 at 11:23:50AM -0700, Peter Newman wrote:
>> Hi Dave,
>>
>> On Mon, Apr 22, 2024 at 9:33 AM Dave Martin <Dave.Martin@arm.com> wrote:
>>>
>>> Hi Babu,
>>>
>>> On Thu, Mar 28, 2024 at 08:06:33PM -0500, Babu Moger wrote:
>>>>        Assignment flags can be one of the following:
>>>>
>>>>         t  MBM total event is assigned
>>>
>>> With my MPAM hat on this looks a bit weird, although I suppose it
>>> follows on from the way "mbm_total_bytes" and "mbm_local_bytes" are
>>> already exposed in resctrlfs.
>>>
>>> From an abstract point of view, "total" and "local" are just event
>>> selection criteria, additional to those in mbm_cfg_mask.  The different
>>> way they are treated in the hardware feels like an x86 implementation
>>> detail.
>>>
>>> For MPAM we don't currently distinguish local from non-local traffic, so
>>> I guess this just reduces to a simple on-off (i.e., "t" or nothing),
>>> which I guess is tolerable.
>>>
>>> This might want more thought if there is an expectation that more
>>> categories will be added here, though (?)
>>
>> There should be a path forward whenever we start supporting
>> user-configured counter classes. I assume the letters a-z will be
>> enough to cover all the counter classes which could be used at once.
> 
> Ack, though I'd appreciate a response on the point about "_" below in
> case people missed it.

It was based on the dynamic debug interface and also Reinette's suggestion
as well.
https://www.kernel.org/doc/html/v4.10/admin-guide/dynamic-debug-howto.html
(Look for "No flags are set").

We tried to use that similar interface.
-- 
Thanks
Babu Moger