Received-SPF: pass (google.com: domain of linux-kernel+bounces-155500-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 23 Apr 2024 18:50:27 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: nuno.sa@analog.com
Cc: Petr Mladek <pmladek@suse.com>, Chris Down <chris@chrisdown.name>,
	John Ogness <john.ogness@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Jyoti Bhayana <jbhayana@google.com>, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 4/4] iio: common: scmi_iio: convert to dev_err_probe()
Message-ID: <ZifYwxjNxfM1LwW7@smile.fi.intel.com>
References: <20240423-dev-add_dev_errp_probe-v2-0-12f43c5d8b0d@analog.com>
 <20240423-dev-add_dev_errp_probe-v2-4-12f43c5d8b0d@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240423-dev-add_dev_errp_probe-v2-4-12f43c5d8b0d@analog.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Apr 23, 2024 at 05:20:33PM +0200, Nuno Sa via B4 Relay wrote:
> From: Nuno Sa <nuno.sa@analog.com>
> 
> Make use of dev_err_probe() and dev_err_ptr_probe() to simplify error paths
> during probe.

..

> +		return dev_err_ptr_probe(&iiodev->dev, ret,
> +					 "Error in registering sensor update notifier for sensor %s err %d",

\n

> +					 sensor->sensor_info->name, ret);

..

> +			return dev_err_probe(dev, -EINVAL,
> +					     "SCMI sensor %d has missing info\n", i);

One line? (It's 99 if you use relaxed limit).

..

> +			return dev_err_probe(dev, PTR_ERR(scmi_iio_dev),
> +					     "failed to allocate IIO device for sensor %s: %ld\n",
> +					     sensor_info->name, PTR_ERR(scmi_iio_dev));

Please, be sure you remove double error code printing, dev_err_probe() does it
for you already. (This applies to all places like this, if any, in the entire
series.)

..

> +			return dev_err_probe(dev, err,
> +					     "IIO buffer setup error at sensor %s: %d\n",
> +					     sensor_info->name, err);

Ditto.

..

> +			return dev_err_probe(dev, err,
> +					     "IIO device registration failed at sensor %s: %d\n",
> +					     sensor_info->name, err);

Ditto.

-- 
With Best Regards,
Andy Shevchenko