Received-SPF: pass (google.com: domain of linux-kernel+bounces-155506-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 23 Apr 2024 11:55:49 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mm: page_alloc: Avoid defining unused function
Message-ID: <f3qr7e7nmith6i4dbffsxvm63wappv4nl4d7nuto4432mpcec3@t74zh4amndir>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
References: <20240423150622.2526825-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240423150622.2526825-1-andriy.shevchenko@linux.intel.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?C8ImT3LgKljoGOJJ5Zjgzcco3I0o0wUB/fJINY4QiZFEzPZoAj+IK1gHyM74?=
 =?us-ascii?Q?TCjGgMtpet0l5sf5vgLnXbD4hybv52sjgsLyShZg+7M4di2KTo3nEX8Q9C5M?=
 =?us-ascii?Q?ZXocaY2XzCXgl453WfW4+fVj/wNiZxE4F/eLowoPG7eGMEG0JajEzSjtT+IG?=
 =?us-ascii?Q?FjVXahUXM13tR4j4qDmBk4OMNkjbsEIeUNoy9z9y/OjwxtSGaVyMIcNgg8jw?=
 =?us-ascii?Q?H1obqBQFp5uHyQZMIqfiE7Mqw21axtWnI3OrZgpA4QOl/18CC8xCFAp2qwXr?=
 =?us-ascii?Q?g0SytEkF3jn93EsFVZbw4ABP1fpnxLeR3VEFD3FOwrgx7XwMuJ285371FTtH?=
 =?us-ascii?Q?gVTvo154MbPRIYA53aEZjRObF3XvAt9pF6hZKcBwoW6Wm/r44SOIXqBMbuPD?=
 =?us-ascii?Q?hKBeTMA8U+eu3cS1v1Iwii14vQby8dQT3tcBRPymoAYn6sKjortdMb7uLBNV?=
 =?us-ascii?Q?c2gdYr30K3maYjWHtMm52FS6IGWJVBCDNk+40XpjIRSme3fJVSYAONwJX2+Z?=
 =?us-ascii?Q?0VE3TdL0qXCPle06JUeUce/FV9yVo+QU+FrqL1pbYqT9V/q4TpKNg46vGR7i?=
 =?us-ascii?Q?ursFYZy+nP03/FUYcE1EC8D84Gt5vdl5mVJdwYZl+smcjZqF5I8rnAO7FCGl?=
 =?us-ascii?Q?hLXBWP4+NSxsXTdzQYoda0QjPqQ/dmH2kx2YWBGvJw5iRIy8LwTe2wpOJTu1?=
 =?us-ascii?Q?OvNrrpNAzs4fjw2GGxlt+Ap33QQuOTXb80LJnpbGTHomkd6DWg5IkBTJkQb9?=
 =?us-ascii?Q?D8ygu3QubHfmGnV5ysFiFnVXlzjEM9fYRDsvzu3p9HvWGqIushn3CtG7t2ie?=
 =?us-ascii?Q?rzUx7i28eYgCga3xU2D15XHuZi/mbP1bJ08IYtVtbT4sfMVNYBI1sJI3tbYs?=
 =?us-ascii?Q?gw+HUQRmd/YIl0x81PpS5mm2f3JLFbBgOIGGhs8cQ16KV+AuqKYx9m6C2l1g?=
 =?us-ascii?Q?r1OJ/ZPn25WAo5ywFLl3++lzy6vcvnjj0+2K8mnHF/C3adVLEbY7eLlkQbgn?=
 =?us-ascii?Q?VD6Jga/QtUTNc3ucK55a7QbPncXgvvXkUwR95bfJss74RL+9rWiU/z3yoNg1?=
 =?us-ascii?Q?fOvSqM45tmhmB+lkxBgGtiBcJF27byskeEsFJUj1r1YcCSJUP3K30+EdXDU6?=
 =?us-ascii?Q?tpgmN9qmboSPx6dMB/sbjXpI6/6n2py6uIyVT4e5c67IspTRVaRoB5sOyRV9?=
 =?us-ascii?Q?mug2QosJSLJQEPJd/ZopGgFYsGe+3CJJBpVo8u0nJ+RH2fcZGb+rCtqMS1Iw?=
 =?us-ascii?Q?Bgo7GjJ4s0wvgSopaHjJfGSmWX4MGj8ZgXh4xbz+Pp7mOaOzQt+7im0JNGEG?=
 =?us-ascii?Q?qqzF6Cbb0GoLR1JoZQwp8QmBQjEgAE0EwWp95opuo7pQAyw9OA6ICJrAasQX?=
 =?us-ascii?Q?aqhvqGyDrPjCIKq9U1/NG9jKmFzgNVMYCANiSZk3NqADuOTWF/WtdeLgMOJB?=
 =?us-ascii?Q?D5U500ZYeY/YaIphCCRu56TqkUbLaWDg+fk6U2mYhWCZqVVl9ESoPGtt/ijh?=
 =?us-ascii?Q?3KNLaEogAkEIIoiKyGYoh/bpDRHw5a1+n8/aoSScB34uOXCORuBZThK6nhfU?=
 =?us-ascii?Q?PFKYbDITgyOFna6z/H4kkxWPfjHin78UdLwa8z1z?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	lt8L4XB8rVPeqAr/LXbG/kLNGNU6qFaQTcqyeKCQHhfzozcTlaAYJHGeu0+h4zj204VP/sE235Mq8qzzND+MVTz0rReGeegh/yABhd5GuZXio1ZSO6g0d/oi+YfGCRkhdesoKxmbfMgo8isAgqGhOUK+rw9dwayw37Mz5MJg8CBkk6yUCqeArA2jIfmefVnsBtdyNmihpy9VVqHWISlRKTPXgECJ/EBEQcOLbf5SOt82BxxsZ4AOl6Sf7GXcUPq32vmH8gcBOQ6nx6XEm8WSHaO6T8/q21X6xTqJ5+blk/D3nXlOlDk2/ltUWQrlaj/uWNWGGxyhLgO0gByQy23NvvDlWhfjOdTGlOo91WEcxbjUjUA3RiT2DnX67szCIYfvs1tEde5F79IuKRz8Ao5j1IE/C4c1hbT9tgRlyF0UH18xeekbSPy+AIWfa1vWcEr3kGCbeRRrHT3ZWERlKyS/yykJ1L6wX5VDed/qDNc7sZvH8Psu/NKUOvwW+ou0JB4d1KXWQosG+0doCDgdYXnN2u4NAyzxWOdaGyCxMgl8ndLzF1UHGCxVq8QDs4ubq211441LgNShfTR9NTDEekzdit9F6netXD2rJrOzH5IKDxg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e203e79a-05c3-44c4-a22f-08dc63add9ab
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 15:55:51.3619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vEZsfFIhXF/dSi1h/s2rRRe1acNcwSKKWz1rKOcbQJ7zAnAehss7f8rauXcpMu5JLiiNW2UvSd22LnijWxZtlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4933
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-23_13,2024-04-23_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=724
 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404230037
X-Proofpoint-ORIG-GUID: Pf4SvBpnLtztKKHKu28yz1ANnjI8vFXF
X-Proofpoint-GUID: Pf4SvBpnLtztKKHKu28yz1ANnjI8vFXF

* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [240423 11:06]:
> In some configurations I got
> mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> Becuase the only user is guarged with a certain ifdeffery,
> do the same for add_to_free_list().

Why not relocate it within the existing CONFIG_MEMORY_FAILURE block?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  mm/page_alloc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 33d4a1be927b..0fb796b700a4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -653,6 +653,7 @@ static inline void __add_to_free_list(struct page *page, struct zone *zone,
>  	area->nr_free++;
>  }
>  
> +#ifdef CONFIG_MEMORY_FAILURE
>  static inline void add_to_free_list(struct page *page, struct zone *zone,
>  				    unsigned int order, int migratetype,
>  				    bool tail)
> @@ -660,6 +661,7 @@ static inline void add_to_free_list(struct page *page, struct zone *zone,
>  	__add_to_free_list(page, zone, order, migratetype, tail);
>  	account_freepages(zone, 1 << order, migratetype);
>  }
> +#endif
>  
>  /*
>   * Used for pages which are on another list. Move the pages to the tail
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 
>