Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp3055155lqt; Tue, 23 Apr 2024 09:09:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWT3NZsL8IQptp7qnsiclMqhDbMTh5dpe6f5aLCOoVR3HijEkBSIsbm2cKrGEZU0At1W9O6iJzcmS5m1TuPYfUEBnbJcztRsQqqLUUKtw== X-Google-Smtp-Source: AGHT+IEOMbZJyk75EEIGc/y6gyVPxaNN5vXUU0MFPt6yqXIBtdsOgDAlaO638oPmHKgt6ON8Hkyq X-Received: by 2002:a17:90a:8997:b0:2a2:510f:fa43 with SMTP id v23-20020a17090a899700b002a2510ffa43mr11180617pjn.32.1713888584171; Tue, 23 Apr 2024 09:09:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713888584; cv=pass; d=google.com; s=arc-20160816; b=jXU7wicyFkqryUTDFYU8rPlI50jOYsVC3CoUktcVMa/aDgHm7LfoCEeY7rw7o/J7SK G5rhinZxhibBhVotlHm1FHjvPk6BfWdpwSacsdIcK4QbaNKFkVF1LOqHfEdIZ4qPThYe 8wWviBxdEwsQpU8nydbHKO37yEcM9DVqg76M58ziOd+q2j6E8SUh03YCLFlw8ToG/kin Qxli9EDkBd5YyFsEuwqGiBYVMycwUny43ndYGwgzTVh4uXqukiDMkiqfCs0zol4JU5Vs 79uZ/mMJh+1BgtI9jL0yM1XbDg8tgnP13fjfkEUGn6LMQiS7WklIRVHxox0c0TCnz5f3 uKVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IiD+6XFkDSEK2/f7fOiQcCjp0YlleOKij4PQKeQ0D5I=; fh=OCWOE6Y3KlriTiEdzrQKTHZ6HEy951K6imY4pklfXNU=; b=gVAne7yl8CYq/qPiAzH1X8xh1vNkvmqHdaW6aJ+mFc4eZ3vMLY/zow1BHgh8VciVc9 dC+tbLFdSpA5Q0+BWon/Edu0IFZ/kTwBUH4bVWOXukffOl1QSHgccScHeOo26L6hXA9z OP/wO7Q/8oCyLaHl03puB/n247aLRAC932VXguQjrNWVAJLgRSTNupsaN4GKklctWSQN 81d+n4ttT8U9hQAAeqsACMrcMg+QQjTKWhJNmK28mBeVpwMVWGiAhZFPMkmeIGhjzR9C pMTs9Y+0eVmO3YhfsWj2Bym5HkpA+rUVkzIz5+wepPSt22nxiU1i++4gKDgdMpaBtycI jxhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=TXxdSqMZ; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-155513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155513-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id fy12-20020a17090b020c00b002a2c3529123si11427339pjb.184.2024.04.23.09.09.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 09:09:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=TXxdSqMZ; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-155513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155513-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id CF10CB225CF for ; Tue, 23 Apr 2024 16:03:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8407B13CA97; Tue, 23 Apr 2024 16:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="TXxdSqMZ" Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F4B13C9DB for ; Tue, 23 Apr 2024 16:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713888216; cv=none; b=UdfACMGCXVdg2/YCX+TwI38h2jTTIt+tN80w5Po+MEdET7pzM7OsqKGs8+d5S4vZdnIY4YeYaULcAYcYwSOXdoWITa3sjbSQT1bIEHAb3UG/J2jHCdFLHqXID3GD2c9XUvccJl0amDzNqgtBUCXsydH/yi3sRnUr79Rf/ICpAzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713888216; c=relaxed/simple; bh=ZsuinK5RhPrAcf4onYz+ohAWbVi3KXroAewewFUGu9E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TlWk5u6a8t3A7m2c//vnSz8JC+RE9j91jW5uKhUFegO7N1kCbGqB9KDS1hf9o8oDeDEjzOp5Ki7lwGnTcVm9Gw6R79jJYvYJP9skP7DgzNSi/qkvIzYoH40f4BqmPmTlnN/YI6BwA9V6L+7gZGu1rN36yq0J3zkdO9YsRrscdOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=TXxdSqMZ; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 86CB540E0192; Tue, 23 Apr 2024 16:03:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SL5JtAOWtOYR; Tue, 23 Apr 2024 16:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1713888205; bh=IiD+6XFkDSEK2/f7fOiQcCjp0YlleOKij4PQKeQ0D5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TXxdSqMZsY+FRKwNdjz4vBICMsm9Enxv0XLC8q9Vup4Qk5tqDG705c2FJ0CMbJj72 igAyWgN4VL9Gxat3hdmABoIFuqaIXwpx2SbRKp258zyIo7xCrs23rKXYAYNgHomacS Bja2CSfG70JvAre9Ih2CatH4OMJ7QtZeZQYxere7tyjWB+pJmaHDTkf6kEzhKHJCIO BJFAgQJTgacsbJVFoCBhrBKdWb9UUReauR+Y+iDzP7rmKWIup6yWb4etUVkXbJhlCN NcmAwWwJwIUNKOC5Sc5BRYyIZcNtTjlqOMjHYaGU4BlJ+MCVMF8BrMr2Dz9OOgKoI9 GVRkRtFFg1brO/ZEriSEsG0arG3Y9sjO8UBNXyt6lAGna3y1m3WonYhhhf+naxNDbd egDk73cNtbhEPL6+bsS16kkdE35xAk/d+zKp7h61TitpU9SA6wzZQF+KzS9jYVWJ+H UQTtWDXtZ5gUrvakcZl7NeY6f6UXPPSY7eEnfBiF8oDrBHbWgekiHvAJODMnWrNx8x o8mEE/Fbobqs2VYNGVtWiSDJC4ZO6XkXdLSANmYt/n6nVGuSR5SoHB/LmET9301nKb GOv+/sPBfBOEzVxbKb90U7GCNcrCLmH9DBvuA0DhEth7ppx0BhxvR76TZiasaITCTX tZTDSfBAtksHFfubS2p9o2Iw= Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6555840E00B2; Tue, 23 Apr 2024 16:03:04 +0000 (UTC) Date: Tue, 23 Apr 2024 18:02:58 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Adrian Hunter , Kuppuswamy Sathyanarayanan , Elena Reshetova , Jun Nakajima , Rick Edgecombe , Tom Lendacky , "Kalra, Ashish" , Sean Christopherson , "Huang, Kai" , Baoquan He , kexec@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Tao Liu Subject: Re: [PATCHv10 04/18] cpu/hotplug, x86/acpi: Disable CPU offlining for ACPI MADT wakeup Message-ID: <20240423160258.GBZifbsuoTIbWDapej@fat_crate.local> References: <20240409113010.465412-1-kirill.shutemov@linux.intel.com> <20240409113010.465412-5-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240409113010.465412-5-kirill.shutemov@linux.intel.com> On Tue, Apr 09, 2024 at 02:29:56PM +0300, Kirill A. Shutemov wrote: > ACPI MADT doesn't allow to offline CPU after it got woke up. In all your text: s/woke/woken/g > > Currently CPU hotplug is prevented based on the confidential computing > attribute which is set for Intel TDX. But TDX is not the only possible > user of the wake up method. > > Disable CPU offlining on ACPI MADT wakeup enumeration. Something's missing in that "justification". It should explain why CC_ATTR_HOTPLUG_DISABLED is not needed anymore. And looking at patch 3, I'm still unclear as to why this change is done. Is it that the "ACPI MADT mailbox wakeup method" is going to be used by TDX guests now too so that you don't need CC_ATTR_HOTPLUG_DISABLED anymore? It seems that if acpi_parse_mp_wake() finds an ok wakeup entry, then offlining is disabled... Or is it something else? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette