Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp3077627lqt; Tue, 23 Apr 2024 09:40:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVh5cL1kXrnMCds2zyTQ6oNBRsQaLNDB0hoMmWOiWm6dVL35m27BEjpFoIC+HkBnI4Td7qgT1lLRO0faf+Hq9N/7ewblhje+oOGsSUg4w== X-Google-Smtp-Source: AGHT+IESDKVJsBr7OP8oYVUlUpeDVmE/81m/Aey5YNlD48IqltWsnHg/y3ONvmQb+oLaywNwQEly X-Received: by 2002:a17:90a:9509:b0:2a7:55fa:46a1 with SMTP id t9-20020a17090a950900b002a755fa46a1mr11014133pjo.12.1713890441335; Tue, 23 Apr 2024 09:40:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713890441; cv=pass; d=google.com; s=arc-20160816; b=SnnID7pUb6LJ7NeGzs8TxUtwRz8kYSAW9NTVo0d72ausXb08SYdINAlCvNUEpPBpAo acpYTCVaYn9aXTQETD2ply3VptL5s6RR75e4Ve3WSAHQ4S+wRxEvrfI6+BEwAnU2bY+7 3/7h9lm/z9UcsrqI+klPxbreY4pXoHBnF4wHu9ssfHsZrGMqFrcDnPI9flnF81tSmraW Q5d/rOHdjmFxz45+jUeiA66dLB9iCvFPEOVVbhIOVgbUXmNa0/vz9C4BW7LLoDZblI9y ZcJQi78X2YIrXKGfHRLaJazyecrNL5/1/7I3IIjn5rhoc+ea6vQlxVmCVabXzJUyjlrd k+UQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=PnokyArXxcyIbQ437WBi+fXlNam0sB9x6yTE3BbNzdE=; fh=wW6TKgE076InrKd2dQIVwDyzpdXjw7lH2EvCj6dHzoI=; b=eQrZOKxWf6Cu2F1mRbov8tdeVMWJZm3ju+V9zK0fEFhma3XQCZgWQVDJ17QneeFSe6 O72u25PJ7JTYneqVYQ8y4ZIkAoTsjWeP7xZaqw4yOqLGjdWh8XaF6cZzXbYvQI/6Ltsn tA4HeujhfNnsS4aF1VpGZqjlfL4sVCcFztCHItqN/zcQRIuatiBqMYIc5f6PeJL2tPV1 6yKCuwnu3Eqip6LUrlr1JN3o4xFLMTJ4Cmym7b3DQzrRKF6suK8CsBdzDpVnM1VdAXgB u4mWDkKW5dOJvlcZtKdVecXvO0UKvvRTH5xsuO7mIZgua+3UgnHSLTHECMiRtUkTkJFO BnrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RNSD4r7V; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-155586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155586-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id mm22-20020a17090b359600b002a6fea889fcsi9572544pjb.180.2024.04.23.09.40.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 09:40:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RNSD4r7V; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-155586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155586-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F002428ED29 for ; Tue, 23 Apr 2024 16:40:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36F8913D635; Tue, 23 Apr 2024 16:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RNSD4r7V" Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99D6813D625 for ; Tue, 23 Apr 2024 16:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713890412; cv=none; b=OfDz9dS2rMSy4L2VjRjlMlXlfsaK2si5DkziOvvG2SuJ6HoloTajPd7Jvc7bPRH7WWtF1G1jDSs8grvJfrlZ39LuMEWhS2NJX5tefl355qFfXo1y0DjKTgtzR+oPW6ao2wGYHg78QmLf2alHTI6CGItPGQY+fF1q8+TCPECJ5ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713890412; c=relaxed/simple; bh=BOJw2vRsPZHwOmrOygNkShk96qoSCUb9rWqqoRjUYVk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ui01LQ0C+fb5ub39Q81QX/QBIMo4Ro1HKPhNvEKiC06tKBprz3IUOwGAx80/gJjnuuZWTducCEddtx7DIX9C1vUcbnmevw9PVPFbaTw5IKKQXsimfjt0GCzNp5ydzsw1iEP+xvc0tI8fiPsC8yJJUKXY+9kq2L0uF26SDbEdU4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RNSD4r7V; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-34b1e35155aso2500068f8f.3 for ; Tue, 23 Apr 2024 09:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713890409; x=1714495209; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PnokyArXxcyIbQ437WBi+fXlNam0sB9x6yTE3BbNzdE=; b=RNSD4r7VuLRyOqnAVo8FDasZJdi0r4QbZlOO9ic3gffI0SVua7s+uV6T51O8LLcmJb v5HZU06DqVvaLv5/XWoDMXk+fpgljPkLNa1ugExgEGASSkv7ddvZZpyaMXvlnMGx2g/T Hj3/yYPe4D5y00A9l6RdhAs3l4mipbBEljHEzJRTsGzIeE2tBQuzASV22mjSKvizyZWW xKqiKJWzJkt/7LOIhK8vPpFwmM54yNbk5yIss1M32JS0XDeF3CLZmFoWaqOFD6jZwW/Y y9eQSO9pD5CSlgqn2AhCMBNJqDJDUuV8FHZxw++oZrbEexUW3VUGoAoctZsXuD3dqaqF mKpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713890409; x=1714495209; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PnokyArXxcyIbQ437WBi+fXlNam0sB9x6yTE3BbNzdE=; b=B2Mm33xi8LB1RqzWY7eifaDLsOuy0gzmGFy/c8y7gEHx/k/y9audDouH0+AmqIUXc8 ev7SaGZJrIuyzp4BMDtkMPPggejffcBG+vdYBUDOSHt8EBOKYTUHZ2H5NG393xlbY+me 4vdp/+agnXZdFjfW0aNwxPOLN7xVg1peBwvV5/sTTwNCCaJ5gScG6QJkR62l43nyMgs2 Cs/wtryMnWVfyZ2++Swnfy9mYI893hBejS+NmejXob+olVb8OZz+3x/llfRw7128okQ0 Eoe78dvcBu+fT39RDuTkykmTeq6A1XFn0B9NAcFbOMiMLdYhccTbaSVPf0vVRpw3pWnG HCRA== X-Forwarded-Encrypted: i=1; AJvYcCXqJdw5msFfPW6bX1p7YjE7jni6V1u/u5bHQGgeOvH3iwzRQCFpO4vvocWLo7GdeFs/sqUJa0Bs1G8uNgb+OAnIF1UdEc3bWzW8hAsC X-Gm-Message-State: AOJu0YwwD0v5xmtQyny3KWV766kq0x9U7NIQEICQh6SszI32zcb+WR1A KHHvs38XjNqIWaoJ09NCH/bPiJ2UDlhEJFzFYryiHc50as20S5R07iTFJUh6NOc= X-Received: by 2002:adf:fa88:0:b0:34a:d130:611b with SMTP id h8-20020adffa88000000b0034ad130611bmr7073198wrr.17.1713890408973; Tue, 23 Apr 2024 09:40:08 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id bb6-20020a1709070a0600b00a55b020a821sm3270479ejc.13.2024.04.23.09.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 09:40:08 -0700 (PDT) Message-ID: <90569329-62e1-472d-88ab-c93b44abb60c@linaro.org> Date: Tue, 23 Apr 2024 17:40:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/35] media: dvb-frontends: drx39xyj: Use min macro To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-14-477afb23728b@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240415-fix-cocci-v1-14-477afb23728b@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/04/2024 20:34, Ricardo Ribalda wrote: > Simplifies the code. > > Found by cocci: > > drivers/media/dvb-frontends/drx39xyj/drxj.c:1447:23-24: WARNING opportunity for min() > drivers/media/dvb-frontends/drx39xyj/drxj.c:1662:21-22: WARNING opportunity for min() > drivers/media/dvb-frontends/drx39xyj/drxj.c:1685:24-25: WARNING opportunity for min() > > Signed-off-by: Ricardo Ribalda Code is fine but, I think your commit log could use some love. "Replace ternary assignments with min() to simplify and make the code more readable." Not super-important. Reviewed-by: Bryan O'Donoghue