Received-SPF: pass (google.com: domain of linux-kernel+bounces-155614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 23 Apr 2024 18:02:36 +0100
From: Conor Dooley <conor@kernel.org>
To: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Chanh Nguyen <chanh@os.amperecomputing.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Justin Ledford <justinledford@google.com>,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Open Source Submission <patches@amperecomputing.com>,
	Phong Vo <phong@os.amperecomputing.com>,
	Thang Nguyen <thang@os.amperecomputing.com>,
	Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add
 maxim,pwmout-pin-as-tach-input property
Message-ID: <20240423-gallantly-slurp-24adbfbd6f09@spud>
References: <20240414042246.8681-1-chanh@os.amperecomputing.com>
 <20240414042246.8681-4-chanh@os.amperecomputing.com>
 <13b195e6-cbbd-4f74-a6fa-d874cb4aaa45@linaro.org>
 <065243cc-09cf-4087-8842-bd4394fb324f@amperemail.onmicrosoft.com>
 <d549cf2b-a7fa-4644-8fcb-3c420503ee01@amperemail.onmicrosoft.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="/X6819dsJjBjzCn0"
Content-Disposition: inline
In-Reply-To: <d549cf2b-a7fa-4644-8fcb-3c420503ee01@amperemail.onmicrosoft.com>


--/X6819dsJjBjzCn0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 03:45:12PM +0700, Chanh Nguyen wrote:
>=20
>=20
> On 16/04/2024 11:52, Chanh Nguyen wrote:
> >=20
> >=20
> > On 14/04/2024 13:07, Krzysztof Kozlowski wrote:
> > > On 14/04/2024 06:22, Chanh Nguyen wrote:
> > > > The max31790 supports six pins, which are dedicated PWM outputs.
> > > > Any of the
> > > > six PWM outputs can also be configured to serve as tachometer input=
s,
> > > > allowing for up to 12 tachometer fans to be monitored.
> > > >=20
> > > > Add a new vendor-specific property, 'maxim,pwmout-pin-as-tach-input=
',
> > > > to allow PWMOUT to become a TACH input.
> > > >=20
> > > > An array of six integers responds to six PWM channels for configuri=
ng
> > > > the PWM to TACH mode. When set to 0, the associated PWMOUT produces
> > > > a PWM waveform for control of fan speed. When set to 1, PWMOUT beco=
mes
> > > > a TACH input.
> > > >=20
> > > > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> > > > ---
> > > > Changes in v2:
> > > > =A0 - Update the vendor property name to
> > > > "maxim,pwmout-pin-as-tach-input"=A0=A0 [Rob]
> > > > =A0 - Update commit
> > > > message=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0
> > > > [Krzysztof]
> > >=20
> > > Please put binding before its user.
> > >=20
> >=20
> > Hi Krzysztof, I'll drop this [Path 3/3] in the patch series v3.
> >=20
> > My patch series will only be two patches. They are "dt-bindings: hwmon:
> > Add maxim max31790" and "hwmon: (max31790): Support config PWM output
> > becomes TACH"
> >=20
> > > > ---
> > > > =A0 .../devicetree/bindings/hwmon/maxim,max31790.yaml=A0=A0=A0=A0 |=
 11 +++++++++++
> > > > =A0 1 file changed, 11 insertions(+)
> > > >=20
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> > > > b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> > > > index a561e5a3e9e4..2d4f50bc7c41 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> > > > @@ -30,6 +30,16 @@ properties:
> > > > =A0=A0=A0 resets:
> > > > =A0=A0=A0=A0=A0 maxItems: 1
> > > > +=A0 maxim,pwmout-pin-as-tach-input:
> > > > +=A0=A0=A0 description: |
> > > > +=A0=A0=A0=A0=A0 An array of six integers responds to six PWM chann=
els for
> > > > +=A0=A0=A0=A0=A0 configuring the pwm to tach mode.
> > > > +=A0=A0=A0=A0=A0 When set to 0, the associated PWMOUT produces a PW=
M waveform for
> > > > +=A0=A0=A0=A0=A0 control of fan speed. When set to 1, PWMOUT become=
s a TACH input
> > > > +=A0=A0=A0 $ref: /schemas/types.yaml#/definitions/uint8-array
> > > > +=A0=A0=A0 maxItems: 6
> > > > +=A0=A0=A0 minItems: 6
> > >=20
> > > tach-ch solves your case. You define which inputs should be used for
> > > tach.
> > >=20
> >=20
> > Agree Krzysztof. I'll use the tach-ch property from the fan-common.yaml
> > to solve my case. So I will not need to define a new vendor property as
> > "maxim,pwmout-pin-as-tach-input". I'll drop this [Path 3/3] in the patch
> > series v3.
> >=20
> >=20
> > > Best regards,
> > > Krzysztof
> > >=20
>=20
>=20
> Hi Krzysztof,
>=20
> I checked in the
> Documentation/devicetree/bindings/hwmon/fan-common.yaml. I found the
> tach-ch property, but it seems define the tach channel used for fan.
>=20
>      tach-ch:
>      	description:
>        		The tach channel used for the fan.
>      	$ref: /schemas/types.yaml#/definitions/uint8-array
>=20
>=20
> In my purpose, I would like to configure the pwm output pins to become
> tachometer input pins by setting bit[0] in the Configuration Register.
>=20
>=20
> I think a vendor property is suitable for this purpose. It is only availa=
ble
> on specific MAX31790 fan controllers and not on other fan controller
> devices. So I think we can't use the "tach-ch" in fan-common.yaml.

Can you explain why you think that only MAX31790 fan controllers are
capable of an arbitrary mapping of PWM outputs to TACH inputs?

--/X6819dsJjBjzCn0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZifprAAKCRB4tDGHoIJi
0sBsAP4szpOAruzurA0AMuVIKmpMLtB6uiqkYMNtcr5cxnmZ+gEAk+pBGnO4u4kP
E83o5F7DEoyuPVHRNnYw6JiBMvOwaAw=
=cfs7
-----END PGP SIGNATURE-----

--/X6819dsJjBjzCn0--