Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp3104120lqt; Tue, 23 Apr 2024 10:20:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWwz8qThMMuJhJ+G5shprtMO3t8BY41jL7waCE7UR8mOCvdAgnzphTMaqAKPCodwpLnLBcUqBrJrvikbEr5xhSXebD7eJs5CvPIeRoJtg== X-Google-Smtp-Source: AGHT+IHrlneGSmvcNqxdCMqeUeY9hVX1QyaZRvEFcbGnNHnPED2G1KFSjcSK+80n+buKNHx1gKuk X-Received: by 2002:a25:f61f:0:b0:dc6:2e29:4262 with SMTP id t31-20020a25f61f000000b00dc62e294262mr188418ybd.58.1713892815214; Tue, 23 Apr 2024 10:20:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713892815; cv=pass; d=google.com; s=arc-20160816; b=hWrjRQc27wWMUfS8VGTyLXTRhkFJlXXWpzSAz4+1ODu9JyLOZYe3WdAO7/FdR0Ut9N U06a2I9/wDUpkBeuPbi1ygybM5Y/xLjVPnCwd7Fxi0mHSf2Kn+XQ0P49qozjdqo4uld8 93ttCXaQyjjx416NwgD/oPYpUb0xvAtYVmLKyVzUfO6Aj93OARVnolT2m4wuwV5I5naE z+qhNHfUYfQIGliykhHOr8Ut8SB1EojYgL09E5xm4dNTdmCYvpbcwT3XTe0GpIKMzvV2 2+8fuz5jsVyxh4jgUhEUFN0LSSKVnc0qtMUrdbOK73cv53hQgWj+NnbqCfFwqsuuM6oN J1RQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2HJSpnsUQWd8IMTpbh+5xqR3e7YIet2kA5NKuz6pQyk=; fh=y/ZWbFXBmP32xuuB2aPYQ037wxAyEGcK3dXjHSf7t2w=; b=w2W9OwiVruOw0uIBeCC1Z2Tl7EPSXDyGfpBFPAn5ly6C3M6P6rBqAolkcrh2DOo7kB bDDQI699ZllwR4wmj2occA9Plb0EJnJmUJqCIthQtYFK7KFAR07yjtN8jWwTXrvl397y SNhqqLIOcLlCt1NnTDQLHIpD/Q5R5V9V63dGZvwkQ9RHAwbUnFcj4qQ+CTu/sUnwbXpg P6QilfR1/6ADLvRitImGp078VX1WasPq7t/66hF43a47+rJDNahMFFAEPLZ3/WXFe4v5 CzPl7+FVQYAseQyNfywPr0WdW8piZO4FcEV7sEXgfR5w/SQcrQbvnW6tftqHNfR07TZh GjzQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rxNWsgdQ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-155654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i187-20020a1feac4000000b004ccce6184a9si2106821vkh.229.2024.04.23.10.20.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 10:20:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rxNWsgdQ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-155654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E6F191C220BB for ; Tue, 23 Apr 2024 17:20:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18D9E13FD71; Tue, 23 Apr 2024 17:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="rxNWsgdQ" Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E6113E8BE for ; Tue, 23 Apr 2024 17:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713892763; cv=none; b=TtigPXP0JECPB59UC5/6cRStoZU19VEg+iyaxnPCu2uuI+77/zz5b85fjwPghoVSUnXJAPld3ewSI7M/xepexHABFLaOyCRyNbkFonSgBqh6iHlaOxIHGfgG7PMQBQPSJAymfbSYwrkLyxc97ue4vo77tlHLzsI4jE1WwwfSP2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713892763; c=relaxed/simple; bh=ecUQRsM99KEZqVXhAbhY0JNaLKztzKm4innXl9K6a68=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KeGB/STTaaU13sf4ThiG1oh7DLL4tmVI1lpolPuWJ0VJMcaqgloXIxXUTrHm98UKHqjvWpDTMB8KCiy9fiVLtRBCekzwFgw2P6dznR0kUXYt4YC2uLZOnURBesg3VHy5jnnfzaLEUxN3mbP25DM+AOK4UEM7FLk8SSLBSjf1FXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=rxNWsgdQ; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713892759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2HJSpnsUQWd8IMTpbh+5xqR3e7YIet2kA5NKuz6pQyk=; b=rxNWsgdQki30F7wRtTp3wbNzHaRRnL7rV+HeIcDVpBkiD00gzSouvS68EwsZwNxHmOR0eg ymZeYahD/lPKbJFeu0WvucF6487YzljRe4pai6nw7uoXotcWHfZ6uf6+Iy7+Nwuf1dRYGk Y1uXAJluI6Zcgh/0qZzSQ0Nm8frnqhM= From: Sean Anderson To: Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, David Airlie , Tomi Valkeinen , Sean Anderson Subject: [PATCH v4 05/13] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding Date: Tue, 23 Apr 2024 13:18:51 -0400 Message-Id: <20240423171859.3953024-6-sean.anderson@linux.dev> In-Reply-To: <20240423171859.3953024-1-sean.anderson@linux.dev> References: <20240423171859.3953024-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Sort the members of struct zynqmp_dp to reduce padding necessary for alignment. Signed-off-by: Sean Anderson --- (no changes since v2) Changes in v2: - New drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index 79afe4358d06..6e8478d58b02 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c @@ -255,10 +255,10 @@ struct zynqmp_dp_link_config { * @fmt: format identifier string */ struct zynqmp_dp_mode { - u8 bw_code; - u8 lane_cnt; - int pclock; const char *fmt; + int pclock; + u8 bw_code; + u8 lane_cnt; }; /** @@ -295,27 +295,27 @@ struct zynqmp_dp_config { * @train_set: set of training data */ struct zynqmp_dp { + struct drm_dp_aux aux; + struct drm_bridge bridge; + struct delayed_work hpd_work; + + struct drm_bridge *next_bridge; struct device *dev; struct zynqmp_dpsub *dpsub; void __iomem *iomem; struct reset_control *reset; - int irq; - - struct drm_bridge bridge; - struct drm_bridge *next_bridge; - - struct zynqmp_dp_config config; - struct drm_dp_aux aux; struct phy *phy[ZYNQMP_DP_MAX_LANES]; - u8 num_lanes; - struct delayed_work hpd_work; + enum drm_connector_status status; + int irq; bool enabled; - u8 dpcd[DP_RECEIVER_CAP_SIZE]; - struct zynqmp_dp_link_config link_config; struct zynqmp_dp_mode mode; + struct zynqmp_dp_link_config link_config; + struct zynqmp_dp_config config; + u8 dpcd[DP_RECEIVER_CAP_SIZE]; u8 train_set[ZYNQMP_DP_MAX_LANES]; + u8 num_lanes; }; static inline struct zynqmp_dp *bridge_to_dp(struct drm_bridge *bridge) -- 2.35.1.1320.gc452695387.dirty