Received-SPF: pass (google.com: domain of linux-kernel+bounces-155673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 23 Apr 2024 18:25:45 +0100
From: Conor Dooley <conor@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lucas Stach <l.stach@pengutronix.de>, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl, irqsteer:
 Add imx8qxp support
Message-ID: <20240423-velocity-italicize-c4f1f22c2ef4@spud>
References: <20240422064949.70778-1-alexander.stein@ew.tq-group.com>
 <20240422-channel-emission-d485dee6ae48@spud>
 <6041240.lOV4Wx5bFT@steina-w>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="eGhzn0VEzH+sEQMJ"
Content-Disposition: inline
In-Reply-To: <6041240.lOV4Wx5bFT@steina-w>


--eGhzn0VEzH+sEQMJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 08:26:55AM +0200, Alexander Stein wrote:
> Hi Conor,
>=20
> cc'ed imx@lists.linux.dev
>=20
> Am Montag, 22. April 2024, 17:48:20 CEST schrieb Conor Dooley:
> > On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> > > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-spec=
ific
> > > compatible, which also requires a power-domain.
> > >=20
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > > Thanks for the feedback.
> > >=20
> > > Changes in v3:
> > > * Move 'allOf' before 'additionalProperties'
> > > * Remove superfluous 'minItems: 1'
> > >=20
> > >  .../interrupt-controller/fsl,irqsteer.yaml      | 17 +++++++++++++++=
+-
> > >  1 file changed, 16 insertions(+), 1 deletion(-)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/f=
sl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/f=
sl,irqsteer.yaml
> > > index 20ad4ad82ad64..3d33b75d6ecfa 100644
> > > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqs=
teer.yaml
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqs=
teer.yaml
> > > @@ -14,7 +14,9 @@ properties:
> > >      oneOf:
> > >        - const: fsl,imx-irqsteer
> > >        - items:
> > > -          - const: fsl,imx8m-irqsteer
> > > +          - enum:
> > > +              - fsl,imx8m-irqsteer
> > > +              - fsl,imx8qxp-irqsteer
> > >            - const: fsl,imx-irqsteer
> > > =20
> > >    reg:
> > > @@ -42,6 +44,9 @@ properties:
> > >    clock-names:
> > >      const: ipg
> > > =20
> > > +  power-domains:
> > > +    maxItems: 1
> > > +
> > >    interrupt-controller: true
> > > =20
> > >    "#interrupt-cells":
> > > @@ -70,6 +75,16 @@ required:
> > >    - fsl,channel
> > >    - fsl,num-irqs
> > > =20
> > > +allOf:
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            const: fsl,imx8qxp-irqsteer
> > > +    then:
> > > +      required:
> > > +        - power-domains
> >=20
> > Provided the power domains are optional on the existing platforms,
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > otherwise,
> > else:
> >   properties:
> >     power-domains: false
>=20
> A power-domain is used on imx8mp, but imx8mq does not.

So then make the contains be an enum with both of the one supporting it
& add the else please.

--eGhzn0VEzH+sEQMJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZifvGQAKCRB4tDGHoIJi
0tskAP48o/+s5lq1jpc+7TE1+8Thqvqyi8lpX4xp9HbEQYDoeAD/aucpundN/HbF
FwX9e75oP9cKObcaPj16TtFGFHbq8ww=
=RUuj
-----END PGP SIGNATURE-----

--eGhzn0VEzH+sEQMJ--