Received-SPF: pass (google.com: domain of linux-kernel+bounces-155695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ee56b1c9-c783-4adf-8ea1-6601cbfb9535@oracle.com>
Date: Tue, 23 Apr 2024 10:37:43 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [External] : [PATCH] mm: slub: Fix compilation without
 CONFIG_SLUB_DEBUG
To: Bert Karwatzki <spasswolf@web.de>
Cc: linux-kernel@vger.kernel.org
References: <20240423124025.193812-1-spasswolf@web.de>
Content-Language: en-US
From: Jianfeng Wang <jianfeng.w.wang@oracle.com>
In-Reply-To: <20240423124025.193812-1-spasswolf@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?aTFMT2F4Sm9neEUwQTY5MVR2WTRvQkZaTnMrNHpIUU1oS3NtQXl1bElrbW8v?=
 =?utf-8?B?T0JIZ1JhRGhoeDRkRnZXcW5BRVpiL2dFb01Gbmk2d0h0Tkh6YXQyVysweDNF?=
 =?utf-8?B?OGdWWWVqYm9uVC9KQTNHdnV5WCtpK2NyMTM5Y3o3TURLdW14OUVlS1dHUUNl?=
 =?utf-8?B?RHp3Nll6U0FYQjdpclozWWFjTnEzY25SMTZ5TVlsR0xrc1BtM0ZPeHV6VDlv?=
 =?utf-8?B?VFZvUFVVckFJRk5Vcm9GZGp4b2lmUUNkb1FabnFtUDc3VHV2KzN5U3dIbUk4?=
 =?utf-8?B?ZG5SNXoyOHhTMHlDV0FKTEl6SExINjgxL0FxNGlLL3FxQUo0R0YyTjNKT1lI?=
 =?utf-8?B?SUx4blpOd2dyNUZuaE9uNTJtYVQ4VGdmbVRxZVFmOGd3K2hRRERIeE5rMjlr?=
 =?utf-8?B?dTlrcWJIS0w2RVNKOUVMamhpUVhLcktmOUpQeksvUm5UMjZvTWNFK1BPM1hX?=
 =?utf-8?B?amtCRUl6Qy9wTFVZK21NOHlJUUUyVm9LVXlZWlBvV3hUaU5FRm50bXNsczNC?=
 =?utf-8?B?SlVEcHp6MGFPK3V3THkzUFl1Tmc4cTBLdlZaL1lHOHVZeWhBRlFKcVQ3MW50?=
 =?utf-8?B?b09Jb0RHbjRDdHE0ZjJmZzFHL3QwTllRRFI3VVdySlFkK04zZWIwSm0rVmxr?=
 =?utf-8?B?bGFaUjVzK1JsempRMk1CL2ZDNFQ3UURyY0tmc09kM2NCWGNRU3J5ZnR4NENQ?=
 =?utf-8?B?RTBndkt0bnZ1Wng3cHpjb1pPVGdjM0ZUckVkQXNmZm9xclNyRUtFbjByR093?=
 =?utf-8?B?dFBibU5KTFkxNXYyUkI4MldrTU9pQUZBMDN3ZTI0S1JDaFFRaTNxQnBaelk3?=
 =?utf-8?B?OE5iMUd2dWdDZmhCTUZiUm40dlFabzdVS0dnSjFUN3VnRDZJb3NCaCtSU2tU?=
 =?utf-8?B?YnA5SElNczhMZzlzOWdHbEhSMHpsbWN5OWl4aFNabGs0OTgrU0ZpN3h0YmU4?=
 =?utf-8?B?cWVSSjEzU2pDd3M1RXprYjc0bVZwMFZ6QkJkK29yV1NHYkFwYkVnRlJLemlW?=
 =?utf-8?B?MFlvOHMyclZVNktKZ3VzZVc5SjBsVU0zWU8ydjZVd1BuellqRUFtRnlQWGZq?=
 =?utf-8?B?U0JJSGJQK3FUNS9FMER4dldWR05CZ3NtSjlPdmh1VHV5YlFVc2oxb1VTNmZP?=
 =?utf-8?B?N25YaEQxTVBybTYzR1dpSGRCdnlWSkFob0VxVnUwTzJzWmE3QUNIQ2JUK0Ry?=
 =?utf-8?B?dUtwc0QzVldUejdCS0tRdXRxY0Q2dTlJdk0xN00zV2VuRFRUbERJekgxSWpz?=
 =?utf-8?B?QVBCYk5oSjIrWHZxWVZET1ptRmNqVWlPZ1N0OHRsbHR4c2dZai9vL01RZ3FM?=
 =?utf-8?B?NGtONkhNVm9nTWZKQ2JSeHIyaVgwa3dzWFh2aWswbFFqbFJ2QlVtVk9LZCtJ?=
 =?utf-8?B?WGQ3MDQ4QUlmUjZ5eG9HT3B3SGZ0MFlHWXgwaWthMmVDZG5jNCtkSVJyQ1pw?=
 =?utf-8?B?VUlRc0Y0cG1iUnRLMU9rbEhXUitNTjFvQ0YrL0VFa3c5M3pLSFQ0cTNnWG1U?=
 =?utf-8?B?SWJjWnlNbkVjM0laaGNzN2gvTmdFSEhOdEVTbzdGbVNiNGZGQmZGaG94N0tR?=
 =?utf-8?B?WWw2ZktaMnpvSU1YZWczNGdKVXBpbnpVMUR3TXE0TnVuM1BtSW5haEVVMlpG?=
 =?utf-8?B?di9VMnVkSFp3ZzE3T29SbloyeVQyODlURDM5cDJnSjhTRTdqd1daYXVPczZJ?=
 =?utf-8?B?ajlVZW5HQ2QvdG93cWVmWkZaVk1zZGUzYjkxSWtBWWhtbkEzUTQyVmRpVHRM?=
 =?utf-8?B?WFVZZmcyaXBCVmttZVBjSlE5SVVmTGNqcUc1QmJzWnVMVXIrVTQ2MmRMMmcv?=
 =?utf-8?B?RXJlMVlNKzlENFZaSG9halMrSTAwZlNzdyt6L0N1d3dVTUJxakRZOE8vQWNG?=
 =?utf-8?B?TjMxZXZoYmxnYTQ4SC9WY3o3QkF3bzBROFhNTnFoMDhkekFadmZZVGFSM0ZZ?=
 =?utf-8?B?VWIwR2pNRmV2Qm16SFNTbCtvNkxTSjBEd05kWmVxcDd0RUZ6MUNXZStIdFFY?=
 =?utf-8?B?RUVlQlEzUXl3ZW9uTDVDTm5LQlh6MjlpZHU4dWExVmVxN0JOZURqdWJkSlFC?=
 =?utf-8?B?VU82WFlFNE9UKzRTdUxRcnAwblpkSk1kNEFmNHFzazB1bjRJL2ROdmEyblZG?=
 =?utf-8?B?Wk1TemdwK2t5U1ZrTC8xMVVydEJKcUVsVGt1QnJGOTF1YlhLbFl3TUF2Kzd0?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	pMR8u/SOEOry69bCmKEZHllWytguQG/YXb+UTyU/6MQdLOOm17ctMDe1LZASK3ttpYieTzOQ7l+FsuNY7ddIRlfU63SXcK0MpUGW4nlNAMdWaIGvdFiILFl/bF0WzjCx5lbdMkgopOv7buOuZilGX7C+i5jVR3JqNmu84J59B4Zlt6RJaNcqNpTD/MBQER9uRzCQdAT57di1V3E4uAgrCwXtxBlH7w0aEOt6gfIucV6eWt50UoO3QnIUpteJogDy2t1AhEqAAsKndmlxddYEpP7ssIJUTIj5/cZAY12pwjSvLHjLI6GYyqjWRoLoN9SJ57mWPUsvC9N/tAtexPla4QI1+13FWIeorlGtanxPvVvfcW0lxuHcdCbWJBIx1hivVbPWd9Xvc/itPldpYLMWFkmHK46WmNjjeN4XCr9TBf0mRYI1FUe9Cg0GMZ5DgEf0lFP5Y/guFFvVr/NuWJrPhcf++Y03MTG+wSqgPYC5VX1P5Zqs4AZDu9I10S49jX7pDXNOJcZS54F0thyrVKKPRxvqbLd/VDybDWa93Dyc0eyftOmVkKELtlb3hwH/nMm9W+XFXB4WshHAEeOPUK+2jCUy7RYisJc9iXyk4a7tmi4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 086bc01a-c930-4880-f7d3-08dc63bc1f14
X-MS-Exchange-CrossTenant-AuthSource: PH7PR10MB6379.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 17:38:00.8028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7bnqwVGx9byoi5sl4wqYs+IrMjnuTdiorzySnSIoqFiR3FITXbNwoinR4hMvmUNY9+WmJ31QyfjavSl34IvWxC9lHOfR5ZskzQrUf+FRBmU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7239
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-23_14,2024-04-23_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404230040
X-Proofpoint-ORIG-GUID: MbkByoc1FXeNPiZckX1PJonWzjnDnUs2
X-Proofpoint-GUID: MbkByoc1FXeNPiZckX1PJonWzjnDnUs2


On 4/23/24 5:40 AM, Bert Karwatzki wrote:
> Since the introduction of count_partial_free_approx the compilation of
> linux fails with an implicit declaration of function ‘node_nr_objs’
> because count_partial_free_approx is compiled when SLAB_SUPPORTS_SYSFS
> is defined even without CONFIG_SLUB_DEBUG. As count_partial_free_approx
> is only used when CONFIG_SLUB_DEBUG is defined it should only be
> compiled in that case.
> 

Hi Bert,

Thanks for noticing this.
The original patch was updated to fix it and was sent to the MM maillist.
It has been applied several hours ago.

Link: https://lore.kernel.org/linux-mm/20240423045554.15045-1-jianfeng.w.wang@oracle.com/T/#m6ec634d0d214bea8807deac8cb15bf27dd47743d

> Fixes: commit 1c5610f451be ("slub: introduce count_partial_free_approx()")
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>
> ---
>  mm/slub.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index a3b6f05be2b9..a547ed041bc7 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3226,6 +3226,7 @@ static inline int node_match(struct slab *slab, int node)
>  }
> 
>  #ifdef CONFIG_SLUB_DEBUG
> +#define MAX_PARTIAL_TO_SCAN 10000
>  static int count_free(struct slab *slab)
>  {
>  	return slab->objects - slab->inuse;
> @@ -3293,10 +3294,6 @@ static inline bool free_debug_processing(struct kmem_cache *s,
> 
>  	return checks_ok;
>  }
> -#endif /* CONFIG_SLUB_DEBUG */
> -
> -#if defined(CONFIG_SLUB_DEBUG) || defined(SLAB_SUPPORTS_SYSFS)
> -#define MAX_PARTIAL_TO_SCAN 10000
> 
>  static unsigned long count_partial_free_approx(struct kmem_cache_node *n)
>  {
> @@ -3332,7 +3329,9 @@ static unsigned long count_partial_free_approx(struct kmem_cache_node *n)
>  	spin_unlock_irqrestore(&n->list_lock, flags);
>  	return x;
>  }
> +#endif /* CONFIG_SLUB_DEBUG */
> 
> +#if defined(CONFIG_SLUB_DEBUG) || defined(SLAB_SUPPORTS_SYSFS)
>  static unsigned long count_partial(struct kmem_cache_node *n,
>  					int (*get_count)(struct slab *))
>  {
> --
> 2.43.0
>