Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp3147615lqt; Tue, 23 Apr 2024 11:34:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU5PwSLzAsXPLHuAh8EIuO1lir56tsOth6/MdbHATVG0qkclG9cT60DeyXYWqZVh9wDijzhK1VoaMj571JdCzLSfNPGYU3D6KM7RDtxzg== X-Google-Smtp-Source: AGHT+IEY8X3t3mYasN1c5ScmuWW0WzJyO9DHEtzrKCgU5Hjku/501QcCflHBLqLfuUCG4CmJoW8g X-Received: by 2002:a05:6830:1106:b0:6ea:1bf3:9854 with SMTP id w6-20020a056830110600b006ea1bf39854mr471511otq.12.1713897270067; Tue, 23 Apr 2024 11:34:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713897270; cv=pass; d=google.com; s=arc-20160816; b=SGOnii4D3BoI7+mNysiqobIznyskkl7pdEqN+NbuSIuPeNac8HWY55eV8SAltviuxQ +1pvE/O3svVlNzay7P77D01KhovJ1EYuQXpTEgZiZqCm0h1Zt1fBJRKE5NEBdBYCXlPq LdqxI0SL3V9sBifvs2xtQzWZ7LSO/NNuFY1LPf5x1uSXYLqB2bk1vq99xRAvvqW9snjr ss3zbKV/5XneS+uOKeI0rLQV32KS++1y60qlBlC0AQZff683Hv+cHhlxTrzihqazSWOk xRIaVl94aTXcdugQI56IulhS4omBOmuTwIBnYCZVcPP/sZuAdWDcdwd9rkW8zszrjuht Qdnw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-filter; bh=hBq2Lfs8xlfyW3XO8/KWLtollTTuiPYKud0Kl1Gf4vk=; fh=YPB6smmkDIKJA3a8AQbe7oLWhmaFArz4Rg9M7M49aVo=; b=s4ABG+nLVywfeTFLYQ8z6p8e4dL2vOM8pUM6hz6SzW8mu7iXmTR3aZOgRww4w5cIVw 3GGPpOMZiRfZH/7U7/HL6Cn/wyIq4yypFdwp89KXSTtzJXEUCiOr0ZGMQpc0LsXryxTB IYsKW/20vsQgDAwFMg3uGeQCzuQSbdrQB+CipmfKVogINf1Bh4UC/U3HQgVfu2pnPKZe BsDUgADzG9NwjThrXqotfr1N2VDbEjLyRjyFIl8BztuiLJJASL/BrPhtyUOh3FhczR+Q JbeN49O58HIb5+XC7R8X+9qwac03+XuheC2Epm70UGUYPisMNGUX1xErr6Z+2tajSp7d GGhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=XGslnqNG; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-155753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155753-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id vy15-20020a05620a490f00b0078ef8c97619si13020349qkn.626.2024.04.23.11.34.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 11:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=XGslnqNG; arc=pass (i=1 dkim=pass dkdomain=broadcom.com dmarc=pass fromdomain=broadcom.com); spf=pass (google.com: domain of linux-kernel+bounces-155753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155753-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C36E51C22F3B for ; Tue, 23 Apr 2024 18:34:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ECC8D1411E9; Tue, 23 Apr 2024 18:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XGslnqNG" Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.144.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D47A023775; Tue, 23 Apr 2024 18:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.19.144.209 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713897229; cv=none; b=Nem7SzPdoWIc29fRYzdd2g9yOpNtpqvf+k7yjZbQXKrjYWirc6E7UL+PHJ8r8qz0y0t/XH4HZwKXiek0UzFqW8Zz+FRSQaVCl3ufBKoaE/NgxSBB9Tuyu/+kJJYWOkWHwxSDAkpgThAkB/xy071LEhsPZjwM7ILrDikszFQJJqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713897229; c=relaxed/simple; bh=WXA2ZfSFb7CbPUJRrqZdpAtOjK+DU+4PHhQxaWIgaCo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LZ1W7i6EwjN5F1lE0tOEhB3FP0JQ4aiw/hWPigMq7wPwTwkMCpmQXRgfSHUjXsM98r84YRpeCB+de+QnyiHUrb3zA6fVU76JJFNmRzOuMPhjRFgFrixdQLwSjUzJzqvJBC7YcDGTnCtuXlpsw8gF+qtRHgEbiGiC7yiK+XA+3bA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XGslnqNG; arc=none smtp.client-ip=192.19.144.209 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id B8930C00281B; Tue, 23 Apr 2024 11:33:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com B8930C00281B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1713897221; bh=WXA2ZfSFb7CbPUJRrqZdpAtOjK+DU+4PHhQxaWIgaCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XGslnqNGknPdxUopqHaujYiNG7PSj7tAYSIJWW3hxfn1BvxoydIbxS0FMYcTR8H8q j71rzh++YAIEFODroVXXXmtIsr256j1MJ5UTXeCASix5AScNJYzGeqN9K45zuTAR7Q EE2j3zRl5LDTN6OViWWDwONQXRrfDqdVERxgf66w= Received: from fainelli-desktop.igp.broadcom.net (fainelli-desktop.dhcp.broadcom.net [10.67.48.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id D1E7C18041CAC7; Tue, 23 Apr 2024 11:33:39 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 6/8] net: dsa: b53: Call b53_eee_init() from b53_mac_link_up() Date: Tue, 23 Apr 2024 11:33:37 -0700 Message-Id: <20240423183339.1368511-7-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240423183339.1368511-1-florian.fainelli@broadcom.com> References: <20240423183339.1368511-1-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit And make sure this is done for the MLO_AN_PHY case, where it actually makes sense, contrary to b53_adjust_link() which only did it for fixed-PHY configurations where it does not make sense. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 18b87e903943..a4b50ee97f87 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1481,9 +1481,13 @@ static void b53_phylink_mac_link_up(struct dsa_switch *ds, int port, bool tx_pause, bool rx_pause) { struct b53_device *dev = ds->priv; + struct ethtool_keee *p = &dev->ports[port].eee; - if (mode == MLO_AN_PHY) + if (mode == MLO_AN_PHY) { + /* Re-negotiate EEE if it was enabled already */ + p->eee_enabled = b53_eee_init(ds, port, phydev); return; + } if (mode == MLO_AN_FIXED) { /* Force flow control on BCM5301x's CPU port */ -- 2.34.1