Received-SPF: pass (google.com: domain of linux-kernel+bounces-155789-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <56f9a311-a786-4586-8b9f-4db918667434@amd.com>
Date: Tue, 23 Apr 2024 15:16:46 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
 Avadhut.Naik@amd.com, John.Allen@amd.com
Subject: Re: [PATCH v2 04/16] x86/mce/amd: Look up bank type by IPID
To: Borislav Petkov <bp@alien8.de>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-5-yazen.ghannam@amd.com>
 <20240423170608.GCZifqgD-N2B7vm6_D@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240423170608.GCZifqgD-N2B7vm6_D@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWNNeUZ2U0xoeElPckF4RzBKTU02K3FkK3lYNzV2eXJNRDd1MUpmRytyaVBz?=
 =?utf-8?B?eXFqdkYxNjdEcnZpakMzUkU4aWpwdWRPM1V1YXN3elJWRUFBTDNmYWVLZDJn?=
 =?utf-8?B?WUdxallIelZkQXhFOEJnZFp6S3JaTXRIZUJSYlp5cEI5QXpFd1EvcGRWNENv?=
 =?utf-8?B?ckdYOUdiSEEyMHF0M3JBM1FOdEo0SHJaRHBDYUVOcnJYU0JoY0RtQUIrNXhu?=
 =?utf-8?B?ajJPSHk0SExRNE1NTWxxaTRKQW4vdDJZSU9taHRKeldwWXpPcjY0dUVEWVVq?=
 =?utf-8?B?L2hDNHlaWUdCdFNER1J1dGJ1ODJzS3JEd2xwZDlDM25CTGtWSk4zTitIL0k4?=
 =?utf-8?B?a1RESjlmUWJ1QmxCTjh5MjVLNHg2ZmYrWldudHpiMEd3RUUzTGFGTDZFdW5y?=
 =?utf-8?B?enpra3ozakdYYzNPSVNHc1p5OXhjd0k4bUlKS2lVaWhDWENJV1JIaWpxbjRI?=
 =?utf-8?B?WWRNaHQ5VlRNVUtqRWhzWEowOTA1dUhtM01CSnBidjFkb3UxY1ExNFp0MkZU?=
 =?utf-8?B?OUVISGFiTFFkam9mR01NVjFCUnZUOWJ0RmFKZFFPN0F6LzhHV1dVaVNWaHlw?=
 =?utf-8?B?MnVGVzN4eFlsU3htMDJJbWU0THBGQUdJZExsNWNVeGM3cFFQdkxnaDcrWGgw?=
 =?utf-8?B?YVlTMXI1OEtCc3BmdzEyNXllc1N3ZFU0cGZDc2tzTFB1Nmc4akpRcTZJYk8v?=
 =?utf-8?B?VmhJUVJVYzQ3N0lGSWdxd2JxbVVIVGNBRG5rOURZVFB4bnpLUURqVXU2cmI3?=
 =?utf-8?B?ZFFIMkZNWnVVeVBYU1R4WXJYWmIxVjlYSFczNjhkSVF2REdhL1IvdmFVbXdY?=
 =?utf-8?B?RWE1eXpGZEFZcXMvYXVwMDNlZjFvUFBydnlXWHF0T2k0cHZxbEhyWjRNSmFS?=
 =?utf-8?B?ZUZtNlR5Nlh6TW9tTjFSSUQwby8zUlJGbXZ2VDBoRUZUODNiUWl2Q3U4aHNj?=
 =?utf-8?B?a0J2OGowTDFEbXZKWjZKMTdUY3Y3ZFBZZzVyMjRUczlwa0tRMTVwOUFXd1Iz?=
 =?utf-8?B?RUw1ZmJQU2twcEx6VVI1K0d2ejhpMnBOYXNUYXpMMDJtZ01QSnVmUm1CQm1Z?=
 =?utf-8?B?QzBCOTZyNWFBeVJWQXhrSXdMSkxpQ0dmQlVQVHZhM25QQVNVcDkvZEc2SjhY?=
 =?utf-8?B?Y2hZKzgrMVVWSVI3cnl2WUVveFhqaENLSnVjVS9kaGNtSmdrS2NYeENXN0Ix?=
 =?utf-8?B?Zy9IMGVXcjh5YWdoa2Y4alF1ekNQMnlOTlBXZFo1cEROVGhLbHVTcW5Ja25W?=
 =?utf-8?B?TkkySWZOdDcwWDRwcUZMSnpObFpTWFE0WDhHVkNwdEVvVEhaVmhybk13MjZF?=
 =?utf-8?B?V2hrMThjbm90djlmMWM2d3F1NW1LVmNFZ1NteWpDbjBPUVM3bXIwVnFWMjFr?=
 =?utf-8?B?cFExekVXNWJSU2hIVWd1ZUpEMnFES3hDTy9CY3FqclM2bm1YQjA5aDV4Tkha?=
 =?utf-8?B?dHVyVmdVNjBuYTd6WXRDV0Fwdk04OUM0eWYyRGNwMnpYWktBMDc4U1RIVWEy?=
 =?utf-8?B?NlhMVW9seEtwcDNPV1p2NGZ0Ny96Vy9NTU5TaUViNHdWZTNEZW8xNVExd2RY?=
 =?utf-8?B?WXoxZFRTM09mOTdrcGxORzIzVkl5VDc1NEluQmFCdFkvQjRLS004Z1VhOE5T?=
 =?utf-8?B?QmxwdmI0cUVQOGJvMHRWTFBabUFkekVtdTlwTURRbXpkSzBYSnlMM1N1RHVy?=
 =?utf-8?B?RFZubGpJUHpST2JTQ1NVM2ZCd1VxZ2lkMEtEamNKbFhDQnV6Tk1yQ2VrWVhr?=
 =?utf-8?B?Yyt5MUJzem90K0J5bEl6ODR4enBiYjBsbFJudXJSd0Q2bi9sRmhyQUpLUzRo?=
 =?utf-8?B?ZGdDSHkyall4VUp1clcwOUkyL0NHN1dvT2FFMzBIdEs0Y0tTVXBHajJGVUpl?=
 =?utf-8?B?RTRJZmhIcXdJOG15OU1LZFhwVVp4ekl0dUE4K1NrSCswOHRiUmRYMDkxQVBl?=
 =?utf-8?B?eG8zSGFsN01CNDVzRURud2hsZVdnR3dEK1NoNGZIWmU5TFYxeFpiQlNsZEIz?=
 =?utf-8?B?SG9ra1BhOUIvbVMwRFlQOFBZTWdRdHMwaVJhcW84VkhNZEQwT010RTAyV3Zi?=
 =?utf-8?B?QUJxSGZPVlhDczB2M3pYVkJjRmVLVkZBYmVqazdLc1FTaXdzdDhYV0xJOVVM?=
 =?utf-8?Q?qbUmFZ3t+CFIPPDR34RvUTqhg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 725e068e-4452-45f5-2c72-08dc63c9ec63
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 19:16:48.7582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0/50Wq+MH1ClHKm43UIvWXe6pPd7saor8rzM5JO2Rtvy92RWNS3Ynv14YDwd5hoJZbtobfH1dz2aTZy8kiBrHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7303

On 4/23/2024 1:06 PM, Borislav Petkov wrote:
> On Thu, Apr 04, 2024 at 10:13:47AM -0500, Yazen Ghannam wrote:
>> Scalable MCA systems use values within the MCA_IPID register to describe
>> a bank's type. Other information is not needed.
>>
>> Currently, the bank types are cached during boot and this information is
>> used during boot and run time. The cached values are per-CPU and
>> per-bank. The boot path needs the cached values, but this should be
>> removed. The run time path does not need the cached values.
>>
>> Determine a Scalable MCA bank's type using only the MCA_IPID values.
> 
> Lemme get this straight: You want to switch it all to use this new array
> smca_hwid_mcatypes[] to lookup HWIDs?
> 
> If so, where is the patch which removes the _old thing?
> 

It would be part of a follow up set.

Here's where it would finally be removed after a bunch of refactoring.

https://github.com/AMDESE/linux/commit/291c85ae22277

>>  arch/x86/include/asm/mce.h              |  4 +-
>>  arch/x86/kernel/cpu/mce/amd.c           | 99 ++++++++++++++++++++++---
>>  drivers/edac/amd64_edac.c               |  2 +-
>>  drivers/edac/mce_amd.c                  |  2 +-
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c |  2 +-
> 
> $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> Alex Deucher <alexander.deucher@amd.com> (supporter:RADEON and AMDGPU DRM DRIVERS,commit_signer:91/89=100%)
> "Christian König" <christian.koenig@amd.com> (supporter:RADEON and AMDGPU DRM DRIVERS)
> "Pan, Xinhui" <Xinhui.Pan@amd.com> (supporter:RADEON and AMDGPU DRM DRIVERS)
> David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS
> ...
> 
> You need to CC folks on changes touching their area...
> 

Yep, sorry I missed that. The same is true for the wrapper struct patches
later in the set. They touch all places with MCE notifiers.

Thanks,
Yazen