Received-SPF: pass (google.com: domain of linux-kernel+bounces-155812-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <08742373-ca86-47e5-ab6c-e2e3189eb9fe@amd.com>
Date: Tue, 23 Apr 2024 14:40:41 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] ACPI: PM: s2idle: Evaluate all Low-Power S0 Idle _DSM
 functions
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
 Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
 Mark Pearson <mpearson@lenovo.com>, "Rafael J. Wysocki" <rafael@kernel.org>
References: <12427214.O9o76ZdvQC@kreacher>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <12427214.O9o76ZdvQC@kreacher>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cEtpbVB3ZkVOM3k0RDBWVzRmcHZac3AzQ1Z4TWp2MUtOZWVVaXlhL1ZhbHh2?=
 =?utf-8?B?NWw4ekt3RHFlR1FGS3V1VnB2cUZtcUI2amdiaEYxN3NmSTFIb0dNTk02NGV6?=
 =?utf-8?B?M3p5clZHT2JpMmNsd0lsazVkSVgzNEFtUEdYZ08vc1BpU1Fmb0RJd1JzeURN?=
 =?utf-8?B?QkdSbFlNQmUrY2lKeFI2anRRL2JYL2dJV2lraHliM3NwTSs5V2hpT0w2UU9t?=
 =?utf-8?B?WjBITWFHZ0ZLSXhXVm8yT2ZJYXIrSldkRkxLdXh2SHk4R1pSb1A5RVVOOFdJ?=
 =?utf-8?B?Qkw1cFJ6RXJWay9ZU281QlYyY3loK0g0RmV3MXljcGZhN0hIa1lvWFlwbkxs?=
 =?utf-8?B?ZEVQMnd0aEhpOWc0TVREdnFuL2c3RlFjVTcrWXh6THRkb3NJVU5kQXF3Smh1?=
 =?utf-8?B?d1NwaS9HRjJiWUpHWHNlWVFZVW4rUXI2TFExd2plL3hzZTdZem1XOXZ4TnpH?=
 =?utf-8?B?cTBiZytBeUVVY21uc0RCckhacW9MQlcreEZHNWpVL2hkTXJweElwNHBIbUo5?=
 =?utf-8?B?QXlTd05BNkVzb2RuUDI3bU05aThZaDduWXB5RENqYmVmV2RpNjlJSjJweHZw?=
 =?utf-8?B?Zm5XY0JXRXpZbWIxaVJNRWw0RlBKYTUwZGc3Ym5NdGZxRmRrelhHaEtwNUVZ?=
 =?utf-8?B?Mm00eWs3MmtONlI5SEU1UkRJV1dReFNBcW9pdnUrWU4vT1dHTDBlb2w0QlBw?=
 =?utf-8?B?YU9JYW9lYlZwQXlUWVUvM09hdzVFSzh2a3N6SzlPazhxenlSUk55S1hpTFB1?=
 =?utf-8?B?Wi8rNHR2NitpbVFuaWlLN0JHQS9OSzFZdHh6NGt1WXI2RlJpaXFCQ3AxMmFV?=
 =?utf-8?B?Q1RKdWI1QTNJQURKdVFETGFlbGNlczdDcEtVcUZnQWg2UDdoR3ZtcFlrMmFI?=
 =?utf-8?B?bEJzVWp2enQ5cGhOWVoyclpDYkZ2aFYzSXVTdzg3Zmh5d1I0K1dnMDRaSmpM?=
 =?utf-8?B?dERHN1hsVFc1ZENzUVNtUER4VC9odzl4Q1FaOUhSdUlTcndRTFIzTTNoVjJk?=
 =?utf-8?B?SG1LMVErM292aUJZSSt5R0o3L2VqcG5paDlBUEZuQ3dzcVlBS1ZMMjY1bGtq?=
 =?utf-8?B?SFovZjdWNHl5aE95Y0pSbEhKNktEbUd1MDBQeTlQSjlSb3I3eldGZjhmY2pJ?=
 =?utf-8?B?VWdUSENhL2kxQkhEcGloM0E5WnI5NkxiNVdtdFdadlV1eStZK2RDTTh5L2sv?=
 =?utf-8?B?SGNXLzZoK2lOZyt4enNIaG1FbzNuRmNjd25KYkV6N1ozOHFPMU9XSlJyUXJN?=
 =?utf-8?B?YXJPNXFoM3JLN20xNlNvRG1uajRMUUxGQ1dDOWt2dXJKOHZxc2x3d2w1Yk40?=
 =?utf-8?B?ZGRqcklQTmFJamJRY1BTSkJJRkxFVlpQWE9zbE5hOEYzWUR1b2IwZFBRZlZh?=
 =?utf-8?B?R1JmcTM2bzRnM2hhN0gxUzcwb0VleTlWVFVMSXFJN25uSGlKa29vYXlId1dl?=
 =?utf-8?B?NnZ2VGU3NGtGVTk5NW5IOWx1WlpJbm0rajdRNDFvUWdHR3FhVzlwcFBuS01Z?=
 =?utf-8?B?U0RFZmxqYWUwZnNVYXpZeWdVbEpTc2tCWGRMdms1dXJJclVHcWFGa0lsOFRJ?=
 =?utf-8?B?VlhFYmp0dktoZktxNis3MVNOa0NoYW83Y3NhOXh0anpXTGRITDJuVElKaHNu?=
 =?utf-8?B?N0txRytFbGxJZzlhVzBOMVdVeTc4N3hFZmF4WG9MVUlQWVh0NXNJZ2tJcDdh?=
 =?utf-8?B?d1F1d1k5ZEsxNXp4d3JPby9Ccm5ZSExod3dUL01PMXBtYXV6V3NrMWgvL2FQ?=
 =?utf-8?B?ckdLZjg3SmZmL3RTTzBmTHFRSTBTZDQxZzJ6Sm96Q2N4dHBLY09kZWxwVFpX?=
 =?utf-8?B?YlRRYk95M3diS2VjWWlZKzZiVSswSVU2ZzExOUdtQzAxSHBYRk9RYXFWRTFi?=
 =?utf-8?B?aSs2ZDYrWGY0YzJZQmlyTkhHalRkSmJyWFlvRlA2L3RBVEZMYWo3b0xLNTJN?=
 =?utf-8?B?OGFrbnNUcDU1UysxaW5aVnJjek5FTzh0dWJUbkIrWjcxcjVQUXUvV0pBcno0?=
 =?utf-8?B?dVAwMit1a28wTjRXVXlUWFh3d1l1SUlHSmdNRlV4b1BuczAvbTFsblpaY2pR?=
 =?utf-8?B?SXp5T293c3ErNWp6ek9OV3ZxcE5OWnpHVTYyeFR6WjkyOC9wSUdMNE8wa0VR?=
 =?utf-8?Q?qyVawAe/Jt3tsW843WfcvXVjv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a392e9b6-2f5b-43d8-87ec-08dc63cd4432
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 19:40:44.4704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UdDxCyhLI6PztpkVkAqmGQhsXcOD64e50yzaxFWuJDfzEtdEUycPDW4VZT6XZChuAqX6yjf3EpSvKTZ7aYZcog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8726

On 4/23/2024 14:19, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Commit 073237281a50 ("ACPI: PM: s2idle: Enable Low-Power S0 Idle MSFT
> UUID for non-AMD systems") attempted to avoid evaluating the same Low-
> Power S0 Idle _DSM functions for different UUIDs, but that turns out to
> be a mistake, because some systems in the field are adversely affected
> by it.
> 
> Address this by allowing  all Low-Power S0 Idle _DSM functions to be
> evaluated, but still print the message regarding duplication of Low-
> Power S0 Idle _DSM function sets for different UUIDs.
> 
> Fixes: 073237281a50 ("ACPI: PM: s2idle: Enable Low-Power S0 Idle MSFT UUID for non-AMD systems")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218750
> Reported-and-tested-by: Mark Pearson <mpearson@lenovo.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Ah glad to hear that my idea worked.  FWIW we saw the same type of issue 
on some AMD systems when we first introduced the MSFT UUID.

Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/acpi/x86/s2idle.c |    8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> Index: linux-pm/drivers/acpi/x86/s2idle.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/x86/s2idle.c
> +++ linux-pm/drivers/acpi/x86/s2idle.c
> @@ -492,16 +492,14 @@ static int lps0_device_attach(struct acp
>   			unsigned int func_mask;
>   
>   			/*
> -			 * Avoid evaluating the same _DSM function for two
> -			 * different UUIDs and prioritize the MSFT one.
> +			 * Log a message if the _DSM function sets for two
> +			 * different UUIDs overlap.
>   			 */
>   			func_mask = lps0_dsm_func_mask & lps0_dsm_func_mask_microsoft;
> -			if (func_mask) {
> +			if (func_mask)
>   				acpi_handle_info(adev->handle,
>   						 "Duplicate LPS0 _DSM functions (mask: 0x%x)\n",
>   						 func_mask);
> -				lps0_dsm_func_mask &= ~func_mask;
> -			}
>   		}
>   	}
>   
> 
> 
>