Received-SPF: pass (google.com: domain of linux-kernel+bounces-155813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Kunwu Chan <chentao@kylinos.cn>, "arnd@arndb.de" <arnd@arndb.de>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"kunwu.chan@hotmail.com" <kunwu.chan@hotmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mei: bus: constify the struct mei_cl_bus_type usage
Thread-Topic: [PATCH] mei: bus: constify the struct mei_cl_bus_type usage
Thread-Index: AQHalSiMY12PPI1KcEW/2xbBxOJ0FbF2QxYA
Date: Tue, 23 Apr 2024 19:45:08 +0000
Message-ID: <PH7PR11MB76051D97AC76E8FCDE464F2FE5112@PH7PR11MB7605.namprd11.prod.outlook.com>
References: <20240423024133.1890455-1-chentao@kylinos.cn>
In-Reply-To: <20240423024133.1890455-1-chentao@kylinos.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+u4yyJlJAr/mio2vfSTkp3LrTnxClvJzc9bxHLdKtdQhT8AKu4Mt+2Xzmi0d?=
 =?us-ascii?Q?FDrKVVoFPcKwvbEuAEGyPNs9IAhR41aohG15cfbZadyjW9rjRs5Wn2iwiXN9?=
 =?us-ascii?Q?556QgWzWQ2b3GNFDKLU2HTV0cxWcpcU6Gti9fASBZxSGzn/nyTyQh9dV/xJx?=
 =?us-ascii?Q?hMSgrHju+du1CuqOCMlLcugg4Sr/H48FgbqKK70W8P/17w7wJQKalRRxQiZ6?=
 =?us-ascii?Q?J8FdK/fuBjga0MG6zLQO9qflH181gsdRzou6cxzhdHyj5WYXp4lfnCskHMCS?=
 =?us-ascii?Q?O6HzAEkmGdMTIIP5UqqBWDhg7k0meaapJ9CqKB0pICmFq5DCfc/iCKV3Z94N?=
 =?us-ascii?Q?kuMFqLKoV5ZOvC3EtuMJO6/dc3e/E9eZvf36cLwEE0G2zFGWJwKse4gCQHjx?=
 =?us-ascii?Q?AgQXnIVA086qkmBl+8ZVqhhHtTJ/+B+NmrjeCUL+Eq+OwpmW5TfBwk/Z0Lav?=
 =?us-ascii?Q?fY2uwARdtkopIwHXltGELUXlkmDq+AuVYyPxZGJ9E/HK0lEt7Yx0FrqfTF0c?=
 =?us-ascii?Q?p07bxe2TKGh0QmWk05LxxZFkR8nc0vqXQL/DKkgGe4L3fazxkAF9pkyyXu+X?=
 =?us-ascii?Q?lz6BsTyenIBerjEmLerlGjOaRVPOvN51H6s5ddzXLaex5frIp5l4QRAQ1UGe?=
 =?us-ascii?Q?7I2ZOrRa77J7OPYR1J0VghQ3pVdXey1RQvjxS4KrGtrv9JHwxnZ0kDo7vwwM?=
 =?us-ascii?Q?kNyn/6hc8wHTaYk6xQM2BFF4cM65ypiQqF/BquSQUCvElgOmSadheiDD1RHr?=
 =?us-ascii?Q?i1rugH4UCCXpMaY3EeRAi+9/M/ZMTDiAZEaw8rD9+bt4KmwlmjjeJYjOR5DI?=
 =?us-ascii?Q?TH6YDZrALWGTsyV9XX2eb4u6BFBuyXVdQqeW3nWCSYjGsN6248WmJNeMLjzQ?=
 =?us-ascii?Q?6I7/z/Mav1xuczNjR9uuoCOCeAd96mc4ZqtEKAFR+OqoHfzvpDT7O5W/9pYa?=
 =?us-ascii?Q?6hUCXRYWkRwhsPQuoU8UC67TTVWl9/gFoT2C4yjEjcZ/YAT97lJhn58qq4tw?=
 =?us-ascii?Q?uuz7dyYBmnULgRpWQAQagsyUCPDH7JF2UZ79R+UTGJVJhGbmE2mMUW6sA7CV?=
 =?us-ascii?Q?CB97Hzp315bUsj90FFZhvIMBQuFV/SU3KLEiBUya1lbshWu+D10LciOASmVy?=
 =?us-ascii?Q?zeZ9uqo9Mt8I7L9H0qT9bf92cA+zdy4zJvKR34KO+JRZ/76qL/4oH3WLgPUo?=
 =?us-ascii?Q?naEy0KwoYIJFpVP2SMzIo5FDovzt0tzWPTzbyqNPJcnffJmcYlV2wnZ+VNN9?=
 =?us-ascii?Q?beEt6Y5pVL7n7h7MF2+ynho17pARLFu9bC/nWHnM7dmyCWHg+xNCIXwk1hu7?=
 =?us-ascii?Q?tYYwkyWYB2+PpL10rtlnOl7VKkoEH8kLU3n4uI4AcxFMXsrA0n9BqrNmHN3F?=
 =?us-ascii?Q?xV/uM1VHGM5pB3EO9IsiM7nXLJkYgERGJr3fCP9tTqAHaEbrO6BxST7oGc5P?=
 =?us-ascii?Q?S4ZZ9M39wTva96JHoWldeqnE36X5oK8nnivOVsvUXhbVQSsXOTGgkv2l7cn/?=
 =?us-ascii?Q?s8KmnkSwYk7fs7pTYWq0Zbdrnq877QUzCt4/P3t9Y9QDB8DB7IvSqkFqkf1Z?=
 =?us-ascii?Q?EIPkutKZqz9jVkfVGe8dds7KrcrSOSDqhChMjPxS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB7605.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad5d238e-2b02-43aa-cecc-08dc63cde1a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2024 19:45:08.4757
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rqMHB2eZUWg3I+kCWEQuMneQcwvaJqZOFXVIvizhpxmGq3LyEMpSAg7oCxzhl74Rb+hK1hl6b0/chL86c3sX7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7591
X-OriginatorOrg: intel.com


>=20
> Now that the driver core can properly handle constant struct bus_type,
> move the mei_cl_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>=20
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
LGTM=20
> ---
>  drivers/misc/mei/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index
> f9bcff197615..99393f610cdf 100644
> --- a/drivers/misc/mei/bus.c
> +++ b/drivers/misc/mei/bus.c
> @@ -1327,7 +1327,7 @@ static int mei_cl_device_uevent(const struct device
> *dev, struct kobj_uevent_env
>  	return 0;
>  }
>=20
> -static struct bus_type mei_cl_bus_type =3D {
> +static const struct bus_type mei_cl_bus_type =3D {
>  	.name		=3D "mei",
>  	.dev_groups	=3D mei_cldev_groups,
>  	.match		=3D mei_cl_device_match,
> --
> 2.40.1