Received-SPF: pass (google.com: domain of linux-kernel+bounces-155816-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <12427214.O9o76ZdvQC@kreacher> <08742373-ca86-47e5-ab6c-e2e3189eb9fe@amd.com>
In-Reply-To: <08742373-ca86-47e5-ab6c-e2e3189eb9fe@amd.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 23 Apr 2024 21:47:23 +0200
Message-ID: <CAJZ5v0iKuemDmHCfL67cFyv6gA7Q8cfiNj+nXWqJt2_b_vrhkA@mail.gmail.com>
Subject: Re: [PATCH v1] ACPI: PM: s2idle: Evaluate all Low-Power S0 Idle _DSM functions
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux ACPI <linux-acpi@vger.kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	Mark Pearson <mpearson@lenovo.com>, "Rafael J. Wysocki" <rafael@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 9:40=E2=80=AFPM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 4/23/2024 14:19, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Commit 073237281a50 ("ACPI: PM: s2idle: Enable Low-Power S0 Idle MSFT
> > UUID for non-AMD systems") attempted to avoid evaluating the same Low-
> > Power S0 Idle _DSM functions for different UUIDs, but that turns out to
> > be a mistake, because some systems in the field are adversely affected
> > by it.
> >
> > Address this by allowing  all Low-Power S0 Idle _DSM functions to be
> > evaluated, but still print the message regarding duplication of Low-
> > Power S0 Idle _DSM function sets for different UUIDs.
> >
> > Fixes: 073237281a50 ("ACPI: PM: s2idle: Enable Low-Power S0 Idle MSFT U=
UID for non-AMD systems")
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D218750
> > Reported-and-tested-by: Mark Pearson <mpearson@lenovo.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Ah glad to hear that my idea worked.

We've arrived at the same solution independently, I've only looked at
the BZ when the patch was ready to send.

> FWIW we saw the same type of issue
> on some AMD systems when we first introduced the MSFT UUID.
>
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>

But sure.

> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks!

> > ---
> >   drivers/acpi/x86/s2idle.c |    8 +++-----
> >   1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > Index: linux-pm/drivers/acpi/x86/s2idle.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- linux-pm.orig/drivers/acpi/x86/s2idle.c
> > +++ linux-pm/drivers/acpi/x86/s2idle.c
> > @@ -492,16 +492,14 @@ static int lps0_device_attach(struct acp
> >                       unsigned int func_mask;
> >
> >                       /*
> > -                      * Avoid evaluating the same _DSM function for tw=
o
> > -                      * different UUIDs and prioritize the MSFT one.
> > +                      * Log a message if the _DSM function sets for tw=
o
> > +                      * different UUIDs overlap.
> >                        */
> >                       func_mask =3D lps0_dsm_func_mask & lps0_dsm_func_=
mask_microsoft;
> > -                     if (func_mask) {
> > +                     if (func_mask)
> >                               acpi_handle_info(adev->handle,
> >                                                "Duplicate LPS0 _DSM fun=
ctions (mask: 0x%x)\n",
> >                                                func_mask);
> > -                             lps0_dsm_func_mask &=3D ~func_mask;
> > -                     }
> >               }
> >       }
> >
> >
> >
> >
>