Received-SPF: pass (google.com: domain of linux-kernel+bounces-155840-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 23 Apr 2024 16:16:36 -0400
From: Frank Li <Frank.li@nxp.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kwilczynski@kernel.org>,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Yue Wang <yue.wang@amlogic.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Xiaowei Song <songxiaowei@hisilicon.com>,
	Binghui Wang <wangbinghui@hisilicon.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Subject: Re: [PATCH v2 3/4] PCI: imx6: Convert to agnostic GPIO API
Message-ID: <ZigXJJj4e+oaANAt@lizhi-Precision-Tower-5810>
References: <20240423172208.2723892-1-andriy.shevchenko@linux.intel.com>
 <20240423172208.2723892-4-andriy.shevchenko@linux.intel.com>
 <ZigSiCBIwoEIPYoG@lizhi-Precision-Tower-5810>
 <ZigUL7exXBSbWDIR@smile.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZigUL7exXBSbWDIR@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Q/alq3jYTDmY662v9+Ke6OpyP4VqoAEAV2I9uUyv0nCCDpBOuGbX38MLZBdZ?=
 =?us-ascii?Q?aw6jg4OSDMr0y//Ulu9zWJ9+W+gbOl4E2r7r5fGYR+zQcBh9koGGoKItiNDd?=
 =?us-ascii?Q?VQxEfcl1lVOzzQqml5l/bP70ZQ/6EXTILatrU6N2Jh5KFkSG/V4051N+Gafa?=
 =?us-ascii?Q?VmGoQWZxQheopGglNf8VhE7evbxoo00B5yG1yMybNxlPtNMQ9gVuzePl7xUy?=
 =?us-ascii?Q?bqZyt1spuaA+gMO+JbwgqQ5inYogOv6xIMKv43TZ05AAyy7YWe39mNGdXHgk?=
 =?us-ascii?Q?AYtSABAgB2jTTbpCzpl5n3tN2gIsoYZUYAiWh6LE5au07C5XE14c6z6Lb+Bk?=
 =?us-ascii?Q?YSxiDjhe+lauqABn6um914RRuZnEHQor4/Hn0ZMUwh9mAKe3mvwBqTyZepy4?=
 =?us-ascii?Q?F0cifpbtGarP1vzY2MVbsCYY4P82qodzZLtvNvU7waglvrrT6CusxylCD35r?=
 =?us-ascii?Q?b2cljfAns90hNefY5clBGpB7xV+SrfDshI3XGpsG1FTLW+JHJcgmoDF1U8Uc?=
 =?us-ascii?Q?f5tOKfe13Pd4w/cA4y/Pi8AJJQTCakPbcIiyOMADqdsDZKhLG7MPPgsmk8Md?=
 =?us-ascii?Q?LFSW83Dy8f7xJ2Q6QSJM3iYajs8V2lbLzOh5Mn/PWlKfaHkP/u9drBAtEBTG?=
 =?us-ascii?Q?KvK4MiA4K+3Mw6oF9v2Vq0rgV23ZuuJE0CiHVcmGFq1h1fV8fMTvw0OLyLoe?=
 =?us-ascii?Q?5YsrlLSpDvGWsFyTrgaNxQ+oZPucWSn2ny/TMeQqKuHD4LZEhPTiQsq0gEq8?=
 =?us-ascii?Q?Xklas0kmLtxJcpMgOZ3CEFSejwZM2LNaeD14GWcVSWCnVz60BoqCpTdxGThi?=
 =?us-ascii?Q?KpNJep+K9w+uPrzpZXZ/n/MuV8goqUbOS9LNuy2sCKBv81UhSBYkOmYQ7lwD?=
 =?us-ascii?Q?FAiWA/zUWMSAdcmlFCrguCZ7dKZUHTSTu2bkVEXQiAJkF92kueQ2d2bvvB4a?=
 =?us-ascii?Q?v0CqXttQoBnMVMJKg3u5ONpOmRiNzZItt0Lse11r4S6krAP83v2niNFybF8G?=
 =?us-ascii?Q?bMMBs8JVoPW1SJwA/YABPFi74OA/UO+q+IjM2rmkdvsza4enzx/xFHvm+Yor?=
 =?us-ascii?Q?LKO7eyvwHgN65pJPPMbZtlQ/mYKiuzCKovj7cspsnoEkbTps6Eh6uvaROyNN?=
 =?us-ascii?Q?IokaqAyE8EDkRS5FLFillw/qkhEALC6bdk+CbaIPHAxiOs0rgyZwn36fo/iG?=
 =?us-ascii?Q?OLz/ivMblicuNoUbHy2ABAO8NQEXJXykSP7iLQ4NtkGZMaMYHeCbWwCsDKDo?=
 =?us-ascii?Q?VgCNjukgghMMeCOcimaBcA38ZESXIRJamvxHJIB1yLfzQ5TXqbEja/It64Ka?=
 =?us-ascii?Q?Jt0G+tLwsQg2ZvxULWCveyl7XCXEGRCYPZgTslH+pZ8N1mQF15EnJOHFWdlr?=
 =?us-ascii?Q?Qy9ne9+wEfaC/6KOcR1W4bb0SkkggwPpzErI680Lo6gtTc05K6HF4Zs9eNHA?=
 =?us-ascii?Q?QVLPDiGS6YxpnXjgalH79KIn4IAgH8i1YU8QHzkjI9Ms1ytLfW56ooC1WVOU?=
 =?us-ascii?Q?HXWeLY6a6J0Bn0E8tgc7MJTrK6t65hPfrmUGbX0pLOCBMckv0WMftkoFuZFH?=
 =?us-ascii?Q?f6uGZfzmKb9n/h1/8GfeM9cGZEkbVOHX4pluVhXt?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fda70e91-29bc-438c-668c-08dc63d24e62
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 20:16:48.9926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U+l9MjkGn/knoIHUprvkIyAW0InSfQc4WoDdbEIrhB4VRfHZhbE4C2j54VxCU1BxRSnNqFv1cykZUndLCAdrMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8615

On Tue, Apr 23, 2024 at 11:03:59PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 23, 2024 at 03:56:56PM -0400, Frank Li wrote:
> > On Tue, Apr 23, 2024 at 08:19:06PM +0300, Andy Shevchenko wrote:
> 
> ...
> 
> > > +	imx6_pcie->reset_gpiod =
> > > +		devm_gpiod_get_optional(dev, "reset",
> > > +			imx6_pcie->gpio_active_high ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
> > > +	if (IS_ERR(imx6_pcie->reset_gpiod))
> > > +		return dev_err_probe(dev, PTR_ERR(imx6_pcie->reset_gpiod),
> > > +				     "unable to get reset gpio\n");
> > 
> > Small problem here. err message "unable to get reset gpio\n" will print
> > when -EPROBE_DEFER happen. EPROBE_DEFER is quite common when use i2c
> > expand gpio chip.
> 
> I'm not sure how you come to this conclusion. Can you elaborate, please?
> P.S> I do not see a problem as described.

If i2c gpio-expander driver have not load when imx6_pcie probe, I supposed
devm_gpiod_get_optional() will return -EPROBE_DEFER, 

if (IS_ERR(imx6_pcie->reset_gpiod)) should be true. then dev_err_probe()
will run and print "unable to get reset gpio\n" with error code
-EPROBE_DEFER.

driver framework will retry imx6_pcie probe again when a new device appear.
it may retry sevial times utill i2c gpio-expander driver probe success or
timeout.

Frank

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>