Received-SPF: pass (google.com: domain of linux-kernel+bounces-155920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240317184130.157695-1-krzysztof.kozlowski@linaro.org> <20240317184130.157695-4-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20240317184130.157695-4-krzysztof.kozlowski@linaro.org>
From: Rob Herring <robh@kernel.org>
Date: Tue, 23 Apr 2024 16:23:00 -0500
Message-ID: <CAL_JsqJfT-jui5P56CO4Fr37kr5iNN8dpxt8ecKeFmdVGnRYbA@mail.gmail.com>
Subject: Re: [PATCH 4/4] arm: dts: allwinner: drop underscore in node names
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, 
	Samuel Holland <samuel@sholland.org>, Corentin Labbe <clabbe@baylibre.com>, 
	Maxime Ripard <mripard@kernel.org>, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 17, 2024 at 1:41=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Underscores should not be used in node names (dtc with W=3D2 warns about
> them), so replace them with hyphens.  Use also generic name for pwrseq
> node, because generic naming is favored by Devicetree spec.  All the
> clocks affected by this change use clock-output-names, so resulting
> clock name should not change.  Functional impact checked with comparing
> before/after DTBs with dtx_diff and fdtdump.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

This adds warnings:

13  prcm@1f01400: 'ahb0-clk', 'apb0-clk', 'apb0-gates-clk',
'apb0-rst', 'ar100-clk', 'ir-clk' do not match any of the regexes:
'^.*_(clk|rst)$', 'pinctrl-[0-9]+'

Since we documented it with underscores, I'd say just leave these at
least until if/when we define some standard names. I'd prefer we spend
time reducing warnings from the common schema. I'm looking at
root-node.yaml. simple-bus.yaml generates a lot too.

Rob