Received-SPF: pass (google.com: domain of linux-kernel+bounces-155925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 24 Apr 2024 00:33:27 +0300
Message-Id: <D0RTOKUKOP3M.15LBA63K3KVWP@kernel.org>
Cc: <linux-integrity@vger.kernel.org>, "Heiko Carstens" <hca@linux.ibm.com>,
 <linux-kernel@vger.kernel.org>, "Arnd Bergmann" <arnd@kernel.org>
Subject: Re: [PATCH] char: tpm: Keep TPM_INF_IO_PORT define for HAS_IOPORT=n
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Niklas Schnelle" <schnelle@linux.ibm.com>, "Peter Huewe"
 <peterhuewe@gmx.de>
References: <20240422123711.1739063-1-schnelle@linux.ibm.com>
In-Reply-To: <20240422123711.1739063-1-schnelle@linux.ibm.com>

On Mon Apr 22, 2024 at 3:37 PM EEST, Niklas Schnelle wrote:
> The recent change to handle HAS_IOPORT removed the TPM_INF_IO_PORT
> define for the HAS_IOPORT=3Dn case despite the define being used in
> sections of code not covered by the same ifdef check. This was missed
> because at the moment TCG_INFINEON indirectly depends on HAS_IOPORT via
> PNP which depends on ACPI || ISA. As TCG_INFINEON does in principle
> support MMIO only use add it for COMPILE_TEST to cover the HAS_IOPORT=3Dn
> case.
>
> Link: https://lore.kernel.org/lkml/9d9fa267-067e-421b-9a39-aa178b913298@a=
pp.fastmail.com/
> Fixes: dab56f80e7f9 ("char: tpm: handle HAS_IOPORT dependencies")
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>


Thanks!

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

I applied it to my master but for some reason it is not yet reflected
to web ui:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/

But it is still applied and perhaps also visible when you seee this!

BR, Jarkko