Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp96428lqd; Tue, 23 Apr 2024 16:20:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWF5VNNZ80L+5vIREkQ0fbOjbyEjo/fn6td3+6wYmzPStv0udR/Nw8n/DAmSx4Gn072k3ChSJRHoij08Wb8ZaIkzcu1NDbuhC9SOY/h1Q== X-Google-Smtp-Source: AGHT+IGSj0VxgLMchc1kfKtPlOL76Z6MaBBM6soZlPuOE2rK01tPBU3oER0rC2D9hvcmCkG24CFm X-Received: by 2002:a05:6a21:627:b0:1a7:857d:7fb5 with SMTP id ll39-20020a056a21062700b001a7857d7fb5mr891894pzb.1.1713914413381; Tue, 23 Apr 2024 16:20:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713914413; cv=pass; d=google.com; s=arc-20160816; b=J/72gGlLVsZJt+mERvO0stiygm7R5UmmhQygnmizH2GLQ9hM02ozwBI4t/DtDLNTat MC4jrliI/oxCa1/We9RADpWfbp0CU8LMq26Rg0+xa2kK3/w0zqLTGkNVd8ccgRlBlcdk 7otbbiYHcM+lRIJ5qWoQyX1xUfc2wQPhVbgIl3GfcS7pugU5F0lbA+DkbkIlbDoVnpW/ 13BtBK6/GVLf2KC9qxySDa0oAGOBB74wKXUCroAIh36k2YiWD97mnYZQ05WYTTXubZP7 k4aFOVNIAPYUtRflYZpUobYfH9X/MWykVHZeFUG2qoym65T6cXEcDmhq0DHej9Ucync+ kTOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yo/azk6enc6QmwwKUibOlX+VM7LeQmslPJZahnN5aqM=; fh=iT69aLAFCaAL1ECVELFGqnZRVt9iikoJcvzeKR1Ry4g=; b=zQTwu8TTuQlFJXGQ3ZhtHsqTkG5mTKUxy2jWWcey9PBalTJtCzfluhfY9RNBgk2tqf FXkDLPsalVzcBAjTFsNxTSmLhLH5oJneOolvWqoab3Jpaug6XkdSWHIbrLKMhdF9M/iG kgE4gIMJHlIPULPp9P4AFd3EV9rPrzMz928fI07svpikZ3OYNcZ/rw1q0lZQwcRZRvv2 1yhwK5oW3jGl/Q5NOdryDOIVtcTBcwYB8V22BJ1O4eL288ImZh+YPU2+X79S1WQVcJvr SBJPbESvgMKsoPEbjb8wNARejyzHzISpCuFOEKd9HAlkWTd3sCIekqrMF4JMhFSkZ04/ jW8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wR2tz+Z6; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-155996-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155996-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s6-20020a62e706000000b006e6be504abcsi4996606pfh.90.2024.04.23.16.20.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 16:20:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-155996-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wR2tz+Z6; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-155996-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-155996-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 14EE5B22F7F for ; Tue, 23 Apr 2024 23:17:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 168943E47F; Tue, 23 Apr 2024 23:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wR2tz+Z6" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB10B44366; Tue, 23 Apr 2024 23:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713914237; cv=none; b=dNAN+bS2WN/l+KGxIYMW7UgNV46xZUEpDKXXVq+6pEuvAGC6kMX70CnIjhutHAQ4oIB+Cw64ryNZmSJs4NiheyIGk6h2L2oOURVlq/dyApwY53ttq1SVwwSDuMTHg6NmBW6vkVpjYdgO85JY2WZrjgmG/vXJqZ7yj2xK9vOrkog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713914237; c=relaxed/simple; bh=6tt29QpRIkzCTP0vI3/A7kHdomrFExRog0V0dqNWXIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O5ajIP4kiHhCZPxX/AuxlTfJyfDv5vlxaA/G2U3XC0fkmbsLoQcPWKP5+QnMF73KGkLEon3StN5tX3Gip23OOP9cNLudsX0qTCJMUF93T/BIdeLBnGl+cBdXCn1jUbeIpQMRklSSikGHHpKwig/H3QYgXuBCFEO7ngPVwZz/8lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=wR2tz+Z6; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yo/azk6enc6QmwwKUibOlX+VM7LeQmslPJZahnN5aqM=; b=wR2tz+Z6rOsIhlAh2C8zyt4AyE B5C/Ihh2Dk3qdhGcp2LNYv4c5DCJ6UGk42dmHyITb+mIY37uIwSKDLjDzd4qegOHxWK+QKQuJel5F z2E26InckLGbSQQDThYfVjIwiaxzpHrQOG/hOFu5bNfcL6ZAaSfKIMZSJUjaUSe3SRXo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rzPNo-00Dl1S-Ul; Wed, 24 Apr 2024 01:17:04 +0200 Date: Wed, 24 Apr 2024 01:17:04 +0200 From: Andrew Lunn To: Parthiban Veerasooran Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, horatiu.vultur@microchip.com, ruanjinjie@huawei.com, steen.hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation Message-ID: References: <20240418125648.372526-1-Parthiban.Veerasooran@microchip.com> <20240418125648.372526-4-Parthiban.Veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240418125648.372526-4-Parthiban.Veerasooran@microchip.com> > +static int oa_tc6_check_ctrl_read_reply(struct oa_tc6 *tc6, u8 size) > +{ > + u32 *tx_buf = tc6->spi_ctrl_tx_buf; > + u32 *rx_buf = tc6->spi_ctrl_rx_buf + OA_TC6_CTRL_IGNORED_SIZE; Reverse christmas tree. Those two need swapping around. Andrew