Received-SPF: pass (google.com: domain of linux-kernel+bounces-156013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <24c894ae-5c4a-4462-b036-5929db2fc5ac@quicinc.com>
Date: Tue, 23 Apr 2024 16:33:29 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] of: reserved_mem: Remove the use of phandle from the
 reserved_mem APIs
Content-Language: en-US
To: Jeff Johnson <quic_jjohnson@quicinc.com>, <robh@kernel.org>,
        <saravanak@google.com>
CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@quicinc.com>
References: <20240422235243.2878536-1-quic_obabatun@quicinc.com>
 <d024a0b0-46aa-4182-a8e8-8ff15f12c363@quicinc.com>
From: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
In-Reply-To: <d024a0b0-46aa-4182-a8e8-8ff15f12c363@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 4/23/2024 7:32 AM, Jeff Johnson wrote:
> On 4/22/2024 4:52 PM, Oreoluwa Babatunde wrote:
>> The __find_rmem() function is the only place that references the phandle
>> field of the reserved_mem struct. __find_rmem() is used to match a
>> device_node object to its corresponding entry in the reserved_mem array
>> using its phandle value. But, there is already a function called
>> of_reserved_mem_lookup() which carries out the same action using the
>> name of the node.
>>
>> Using the of_reserved_mem_lookup() function is more reliable because
>> every node is gauranteed to have a name, but not all nodes will have a
> s/gauranteed /guaranteed /
>
> (jumped out at me while scanning the kernel patches)

ack.

Thank you Jeff!