Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp109173lqd; Tue, 23 Apr 2024 17:00:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXjNe9KxUMiUl4TAjsAHSbc4DnfXC+eqfH+vg7/rJSfndC5cxF8O+RUGIsZG94wxbctYQTAknBGYc0HeFROS60TUCsDLStcdt8UGcJYpg== X-Google-Smtp-Source: AGHT+IF7iAAo9vkFzYg66L6a/Ir+5GdOO88IOPmPw4/5R/B+y+KUOp4uQS6wxAgZTojYrXlpxvgI X-Received: by 2002:a17:902:d2c5:b0:1e3:dfdb:ac6b with SMTP id n5-20020a170902d2c500b001e3dfdbac6bmr1381229plc.4.1713916819577; Tue, 23 Apr 2024 17:00:19 -0700 (PDT) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h10-20020a170902f7ca00b001e8505652c3si10171763plw.414.2024.04.23.17.00.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 17:00:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-156038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156038-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3785A285B25 for ; Wed, 24 Apr 2024 00:00:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 952A228F5; Wed, 24 Apr 2024 00:00:11 +0000 (UTC) Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5F5193 for ; Wed, 24 Apr 2024 00:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713916811; cv=none; b=lVsLH3+kPFuzLRF1MdAyHELnPN98LkwIfMyVFGCDaIlnIsGCECbEonVRVfHcTc1iNm4TAtnNUwfuJ0ktt9fI3djs3U+sMG6FHrBh47xStt+61M66zacr3/w5zOQ/UQIfMDBjBRZPz1tp3XdOA4SM6MFboJFGwbdOwKC/0trtWfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713916811; c=relaxed/simple; bh=YHhAzKEj1cXzSZSyGZxvntWUsJLnny/LcXCQYZ0+TBg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a0K0pVXDemxXORawDJkah4XksmwJMK6aeFAgxj3GyBEOPTbqfnss0S+bxewu5oi8E5VzgOodcnPcNs1VxdA9lWXaR7ipcvPeZ+5Ze8fT5I9hQI/AusSVn9E6cQ/itX8aRuks+yDuF5TOTvb3uRZJjFkpmO6tYVacazy5xtl4M8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 9bebda9f-01cd-11ef-b3cf-005056bd6ce9; Wed, 24 Apr 2024 03:00:07 +0300 (EEST) From: Andy Shevchenko Date: Wed, 24 Apr 2024 03:00:06 +0300 To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Lee Jones , Jiawen Wu , Mengyuan Lou , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maciej Fijalkowski , Andrew Lunn , Duanqiang Wen , "open list:SYNOPSYS DESIGNWARE I2C DRIVER" , "open list:WANGXUN ETHERNET DRIVER" Subject: Re: [PATCH 2/4] mfd: intel-lpss: Utilize i2c-designware.h Message-ID: References: <20240423233622.1494708-1-florian.fainelli@broadcom.com> <20240423233622.1494708-3-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423233622.1494708-3-florian.fainelli@broadcom.com> Tue, Apr 23, 2024 at 04:36:20PM -0700, Florian Fainelli kirjoitti: > Rather than open code the i2c_designware string, utilize the newly > defined constant in i2c-designware.h. .. > static const struct mfd_cell intel_lpss_i2c_cell = { > - .name = "i2c_designware", > + .name = I2C_DESIGNWARE_NAME, > .num_resources = ARRAY_SIZE(intel_lpss_dev_resources), > .resources = intel_lpss_dev_resources, > }; We have tons of drivers that are using explicit naming, why is this case special? -- With Best Regards, Andy Shevchenko