Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp110009lqd; Tue, 23 Apr 2024 17:01:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV2LvoMkCsWSU78hRO0EJwwSWvh0Tlob0O9rf1r3U9EcxoYiDS2Lyt5xdOcKInluwiSDoHOVmG9/ziNdQFgxgK5gl7O2MqqPG9x3whLZw== X-Google-Smtp-Source: AGHT+IH0CCQrl/3TEGDMrzUYkpgJhTOSeYx1oXijd/lEywwZduvoDl9mnjbjKU2K4Its1bWhzKXl X-Received: by 2002:ac2:44a8:0:b0:519:3c0d:d0b with SMTP id c8-20020ac244a8000000b005193c0d0d0bmr660795lfm.39.1713916905024; Tue, 23 Apr 2024 17:01:45 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ak6-20020a170906888600b00a5190b36f4fsi7697145ejc.634.2024.04.23.17.01.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 17:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156040-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-156040-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156040-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D645E1F22E04 for ; Wed, 24 Apr 2024 00:01:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EBA381FDA; Wed, 24 Apr 2024 00:01:30 +0000 (UTC) Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 068B0193 for ; Wed, 24 Apr 2024 00:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713916890; cv=none; b=RltDxGvA0PvmuSaSP+Rz2yivJUt2XMY9CNItO0Xk4Sbr81D9/oH16Xzem+y+uODvN0LdCqE6+U2YdyuhoM+7dLqkvdynHfq9F8oS9NbYFZkOM6WeK3CaPbVZB/DxkxHR+PWTeP4P0VgEVwRj2IqhtwEyuR1fXiWcQuL3uZReP7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713916890; c=relaxed/simple; bh=yWWZtVuFVmsAHihQ0rbT6L7WRYIXUYZVJCHeb4B1eU0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jdop22e6PKiL7/m/eHEJfESmuMW5KwYP7bO9SUFXsd5p0riagAOG6LShpXr8znld1T2waA9PdHrTrvha/6wLmUzoxf1FkY6qzHBnRuN3c0+5leuNyk6mongAg0DRp5ny8mcLenXCfzDWC2d8GO9TbXJ6wB3uHZCt+9Y5Dgz+DBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id cb8c8f3e-01cd-11ef-abf4-005056bdd08f; Wed, 24 Apr 2024 03:01:26 +0300 (EEST) From: Andy Shevchenko Date: Wed, 24 Apr 2024 03:01:26 +0300 To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Lee Jones , Jiawen Wu , Mengyuan Lou , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maciej Fijalkowski , Andrew Lunn , Duanqiang Wen , "open list:SYNOPSYS DESIGNWARE I2C DRIVER" , "open list:WANGXUN ETHERNET DRIVER" Subject: Re: [PATCH 3/4] mfd: intel_quark_i2c_gpio: Utilize i2c-designware.h Message-ID: References: <20240423233622.1494708-1-florian.fainelli@broadcom.com> <20240423233622.1494708-4-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423233622.1494708-4-florian.fainelli@broadcom.com> Tue, Apr 23, 2024 at 04:36:21PM -0700, Florian Fainelli kirjoitti: > Rather than open code the i2c_designware string, utilize the newly > defined constant in i2c-designware.h. .. > -#define INTEL_QUARK_I2C_CONTROLLER_CLK "i2c_designware.0" > +#define INTEL_QUARK_I2C_CONTROLLER_CLK I2C_DESIGNWARE_NAME ".0" So, if you build a module separately for older version of the kernel (assuming it allows you to modprobe), this won't work anymore. -- With Best Regards, Andy Shevchenko