Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp114263lqd; Tue, 23 Apr 2024 17:11:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV1u9nBst2Xcil2a7Oe9J0aLmszWgQIo/RBRd7cmwcQqYYqD2uJmDGga7e8AOzdpW4u8cM8Wq0L8IF8NYeUtFuWwW9PM03dxhWy7ugstw== X-Google-Smtp-Source: AGHT+IGHzl/y9kIUCL3HuiQuws6l9MOTvGpjsf78SEyItzjBlJVTBLKTUxnFEiHW2tr7WEIq9bMr X-Received: by 2002:a54:4790:0:b0:3c7:4eff:f67e with SMTP id o16-20020a544790000000b003c74efff67emr904847oic.36.1713917478333; Tue, 23 Apr 2024 17:11:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713917478; cv=pass; d=google.com; s=arc-20160816; b=f/HpXO8/elECZSlpWlm7LLGms9jgp6XyHyWWiptiMXS9kgL/UhN7PLq8Xg+PdGRUi6 HfZolWnOHzbiYL6ze91QR9dk4DwfMaMqprKrQHOYrOf2TxPrjR1ErMDgwbgegOjdG7b1 PU5aNOHAyMj8F7v1Xn4igeekCw4ffSq6YV+dTJuHMwt2+Je+M4LbVzDJvcYX31gazl7x spHIQaOE9dJ8EgfCvL8hpTyUTxgR7EzSqynAGfGpKNMZxm9WWJSng16PJorVWh6km/g9 xCQMf3Lf8WgLeP5vzTHKRlEl9CodI3vptKkfRh3Gp/9t7ispGgmbrY9VFkHzZT/zUueE KHXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:date:from; bh=XlvA1OcfaGEGqNTCVj9XAb7meuPyVsIxP3nCf1ZEVlM=; fh=gSjya4GZWiwgbepPOhXeuMZsYjJpmNKoBzoHKMazQEY=; b=Sle9dInACA2N/GEL6gy+KcsyYOTPg8IHvfw+M7Aa5BHqHAp4ULC3b6tXhmJLoWRNJm SGtp0XzOSSu9MutqItc4OFq675bVQbbC6Q6h/pGo0S7tkHXvGcIltkATmoE123H1lj+U i41+XrudaYGgNwIztbvjsArKh7BMloXhiFPZsMWLm+IUScYL638XQjNaUMgrYmy4expZ SY2JL1YGn+xS0dkamcJosYgPqh7uKwBZfLFbTdNwzEB3/Kfbh027UPz9VSNup8IOBhrn mXBK9PMzrQ3JyYRDmTy9Dl0GZh16lqZ5R92MZLcrFYD/n+LC1fhWGjELN9C4EdnQy40K hJsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-156049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q8-20020a05621419e800b006a075c1ad9fsi8179798qvc.12.2024.04.23.17.11.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 17:11:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-156049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 140541C21F7F for ; Wed, 24 Apr 2024 00:11:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0E01D1FC4; Wed, 24 Apr 2024 00:11:10 +0000 (UTC) Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2237FF for ; Wed, 24 Apr 2024 00:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713917469; cv=none; b=g/A1WLrmuhVAPTqxaLyCMMuUhPwTK92sh21ZvT2oX+LlJew5V1FGGWVfMgPqxe++YSsviM2dRsn6YHIzx69jBKqZQlL5qH0luatD5+eyQGps5BkDDThFzHMqAudTfhPE2NenxI/lHhIBKA/Aog//Ld2S8Hao5ciyomsXjutgvDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713917469; c=relaxed/simple; bh=v97JnFigdJQ9lbLuqbnZwJGG1k8S71/PRqmW3bvb2LY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AYWhfn3rD7GESAXeLLdbRjlYuUid3f+wvUOvbVVD8nOLSifGy/O05th1zXqz+Ve9ZjkrrQyCpBLaZJVEXhGIuV9KutyFAM3xZXtpLsN1JyH2394eN8u/8GQj/7PTIaAtmrzde/tF6awtlfQgzM2+58FyJvGvktmuQrJ73bFxjlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 247e3573-01cf-11ef-abf4-005056bdd08f; Wed, 24 Apr 2024 03:11:05 +0300 (EEST) From: Andy Shevchenko Date: Wed, 24 Apr 2024 03:11:05 +0300 To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Jean Delvare , Andi Shyti , linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/18] i2c: i801: remove printout on handled timeouts Message-ID: References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com> <20240410112418.6400-26-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410112418.6400-26-wsa+renesas@sang-engineering.com> Wed, Apr 10, 2024 at 01:24:20PM +0200, Wolfram Sang kirjoitti: > I2C and SMBus timeouts are not something the user needs to be informed > about on controller level. The client driver may know if that really is > a problem and give more detailed information to the user. The controller > should just pass this information upwards. Turn all timeout related > printouts to debug level. As I mentioned in reply to cover letter this change does not seem to me right. If you provide an equivalent dev_err() in the core, I'll be totally fine with it. -- With Best Regards, Andy Shevchenko