Received-SPF: pass (google.com: domain of linux-kernel+bounces-156259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 24 Apr 2024 00:07:01 -0400
From: Frank Li <Frank.li@nxp.com>
To: Ma Ke <make_ruc2021@163.com>
Cc: vkoul@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	dmaengine@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: mxs-dma: Add check for dma_set_max_seg_size()
Message-ID: <ZiiFZZ8kwDeRWhjR@lizhi-Precision-Tower-5810>
References: <20240423143205.1420976-1-make_ruc2021@163.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240423143205.1420976-1-make_ruc2021@163.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hQHTuBBHQ+ubABK0njNImAzUDTITfHdW98e2gxwwM93qXFRC6SPoJ3tw8JQe?=
 =?us-ascii?Q?Ci+0y7mQhuOUiUa3akuKHzaLGyuOF8FFmnGFhzUr8zhoreEpU+HH5tjLi1AW?=
 =?us-ascii?Q?th38sFiFY9eD9hiCKqIoSbnTUs8pg/q/j43jzjhmZItZleA0QX0GFp+3h8rx?=
 =?us-ascii?Q?28WWRE+0E9HTIHbjKQdMdccNfX2V0otaBEh4to9BGtLR+cozN/Tx9Q/mv+IZ?=
 =?us-ascii?Q?RzJubhH3usHhFHOCZsS1l3l+PRiKN2K2zF24zATVhZ1Kz5PkgU9SPxUYcJft?=
 =?us-ascii?Q?LbCDo9Dcj/lieZEa7WpQ9nyVtX5z1qc14rxQcPLvYmpYoMIcLikMuXnj0nJz?=
 =?us-ascii?Q?O1kuTbqKqk6+w3EZ/jVnlPZ/hgW9qnBA4IbG6aEtv0CWFYYBAOaASbF4ks5f?=
 =?us-ascii?Q?U77gNjWGnxzN6F5xbg8/XSwjdcC9UlQh6JCzKCy+eM+JomReVLWObOTBanZ3?=
 =?us-ascii?Q?p6X419dMOWJDCydYI07+3vDX/OMte06IsJLV0FewhmOZtbZ9dslQoO7mPch9?=
 =?us-ascii?Q?/Bskmq4yLzsVXBm8ximn8NWX9ukw+MbN6a4KUNvhQ02RMwZJwi9BUmx6jMXN?=
 =?us-ascii?Q?OmojUX4QQ/lzb+1ZOwNReKOCBOTAGAYUTtXe4ovOkwQq4mafOKTqNuh84qzz?=
 =?us-ascii?Q?KrUdGAa1gPUMYDJh/53YyV2cupQYdni8hHy7CWow/joAOdwzhhe3gNkSepH9?=
 =?us-ascii?Q?4tpmnllbrZrbaERuelIhw36pnaYkvMZQLmukAVT/LiwC837YD4qXruYqUbx9?=
 =?us-ascii?Q?2blY20EPZTEJbFAsTMrd4bs0Br4pc5CLiFfTMaecqIkCGp1p+L0sRLlvSmJR?=
 =?us-ascii?Q?UVuVj/Wdo+NivoW96s9XIUYCckYMRWM26WgiBVdRJ8M8SbNoBfYrdGbW5NKH?=
 =?us-ascii?Q?y3X5QtFIirh42MRtFerA4wE0wVlkaGrexJU1yq//d+QhUfSrDuxbBZtFCP4l?=
 =?us-ascii?Q?cOMBgDUJOKlyyr7NpUB/ooTebpcU9tvu2lxaAGFmHW1+LVtGBIukvLlCryOo?=
 =?us-ascii?Q?irHq956+cPNMLOECeoA7KAZuV6/cNOmh9712HE5CmNAN2Ozo3RX6Box6jUqc?=
 =?us-ascii?Q?QyzHHGEMvupj8L3paNSJbaH5w+YXxzWf0uayFu6tAkNX3ONjiG3qM/+gmznE?=
 =?us-ascii?Q?GMYV5TduDVpZ7gpJcQDtNBCAEq18ZPAhcgXnUox4sE0eOXbYfAdSG/O+NtqN?=
 =?us-ascii?Q?qMAG/vhZ67WJ7U4xkKqLaoTIotD56CunhfNjaQEK4+16Y6JFjzJ53hqW1vO+?=
 =?us-ascii?Q?HYA8MPcRfpSJFtIsDXGZL88yx86P25kjMMlRIri4g7xliKjWjwlFUSvJLIsM?=
 =?us-ascii?Q?42OHJ1gL+Oq74GJEBPwni8kRFyO8b/m3ilSdwVOa5mLjmf19blvarh3//KM6?=
 =?us-ascii?Q?UEmNYY0AgCoa6TMV35dz3XrYd05UdgI0imuMK575WfFGB3v3GKcJfB+6m11k?=
 =?us-ascii?Q?WDJXrBUjEkicFJbWPjdRCf5upMJToL2DgOSeyXmKyB3S1IdQv49AJRQRP7Gp?=
 =?us-ascii?Q?6KVwZiahdmwGlODf/hOlopxrk2c0aKAv8YCOBHdXOXRMIZCZUtUc4R/4EvCo?=
 =?us-ascii?Q?uvJ/h3Exq0X3nBaQdh0at1cO0MI6zXRN+P0IhXYs?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20dcf9f7-9e59-4b2d-1e36-08dc64140288
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 04:07:08.5799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jug7XBCeiS/IyhLp4Zcce9wjzd7hatBOXm2tf6nbmWatt2byQ+7cFT6IqSlhjnC+V3lRieWfP20hYpSsGi6FvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7515

On Tue, Apr 23, 2024 at 10:32:05PM +0800, Ma Ke wrote:
> To avoid the failure of dma_set_max_seg_size(), we should check the
> return value of the dma_set_max_seg_size().

Check return value of dma_set_max_seg_size() in case it return error.

> 
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/dma/mxs-dma.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index cfb9962417ef..90cbb9b04b02 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -798,7 +798,9 @@ static int mxs_dma_probe(struct platform_device *pdev)
>  	mxs_dma->dma_device.dev = &pdev->dev;
>  
>  	/* mxs_dma gets 65535 bytes maximum sg size */
> -	dma_set_max_seg_size(mxs_dma->dma_device.dev, MAX_XFER_BYTES);
> +	ret = dma_set_max_seg_size(mxs_dma->dma_device.dev, MAX_XFER_BYTES);
> +	if (ret)
> +		return ret;

How error happen? 

static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
{
	if (dev->dma_parms) {
		dev->dma_parms->max_segment_size = size;
		return 0;
	}
	return -EIO;
}

Only possible dev->dma_parms is null. but mxs-dma is platform device, it
point to platform's dma_parms field. Look like impossible it is null.

Frank 


>  
>  	mxs_dma->dma_device.device_alloc_chan_resources = mxs_dma_alloc_chan_resources;
>  	mxs_dma->dma_device.device_free_chan_resources = mxs_dma_free_chan_resources;
> -- 
> 2.37.2
>