Received-SPF: pass (google.com: domain of linux-kernel+bounces-156285-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Ma Ke <make_ruc2021@163.com>, "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "jtornosm@redhat.com" <jtornosm@redhat.com>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>,
        "horms@kernel.org" <horms@kernel.org>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>
CC: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
Thread-Topic: [PATCH] net: usb: ax88179_178a: Add check for
 usbnet_get_endpoints()
Thread-Index: AQHalgUknx7HYzkMS0eaYian7Fw28w==
Date: Wed, 24 Apr 2024 05:06:19 +0000
Message-ID: 
 <PH0PR18MB4474AE468493AE97094D0002DE102@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240424011454.1554088-1-make_ruc2021@163.com>
In-Reply-To: <20240424011454.1554088-1-make_ruc2021@163.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?WJDPp5/shWxLojecQJvDCxtatZWhM3MfO519yFUAWhO/Hr1+h2irMjZ9EkyJ?=
 =?us-ascii?Q?aFcEu1fzVLwH1xrQbPelYX4yVzy/QyFAT7OU1tSMhAWjsCUSwLBBTp2Sc6Mm?=
 =?us-ascii?Q?KpbSJe6Ni2byRxT1UKFJ3uUWGkq/VEWMXmcc2FLVWplpgLLssUk1P9YkWTVV?=
 =?us-ascii?Q?m/BhZGzq/m0JnUccA2nD3vimNZnWd166MGee28aOJI1G6cHQTMaXcjpgcdSY?=
 =?us-ascii?Q?m7dIY+41xu7AeWqBRsseMwSM2YpReyVlGcN31KPGUnqpKyPfAKH5YyBI4EYH?=
 =?us-ascii?Q?QzIxoh4652VfmffWSJutL8QW5be4MtsyahYoqkDU1zsiVvEktutnuOO6EEWF?=
 =?us-ascii?Q?saNX2sMzRj0knhw1jvxz6B3oFZsikYMeT2Tm8EzCwzHgt8MdK0lurdOtF55U?=
 =?us-ascii?Q?Z9RmQauqNmAIFvpbKlg+qIrGIV8U88eCBZfqsqWIKHeWoxBaq+wmt+XgKwjA?=
 =?us-ascii?Q?pDw6x4lpHS2ewhk+RxXO5bIIFgIklF8cTn0kWKYxnRDNEIFVJK/OZ8FUpbX7?=
 =?us-ascii?Q?G5Wb0oOIfs9X0jY0PCGzAf+ng6IrSG3EMPjrIdFWH3nJmXVzvrF3GXPBYsQx?=
 =?us-ascii?Q?qvEbroAaJWFNmfmrHUkIrCm1sy/2PMU79sh5/25oWZM3s7Idv6cdCVAKbLCq?=
 =?us-ascii?Q?IYmi28gccgJRIwLyAvDnkHT58HLRMqFEQ6g4u17pqNQAelt/6KDoswHIIYbW?=
 =?us-ascii?Q?nqrYhGlCcAsaamBXsr2ftFCBEhUVT4QH1pJtpYVkeGes9TYMwE7Kx3I1DOTr?=
 =?us-ascii?Q?wVTnojt2g1YhAorV6Cp7gJY5QqMVh050jCeYiVcpmfnVqxorhpJqzM9OiDGC?=
 =?us-ascii?Q?B7o8TIFvDjp5JbwlzGbPHJA5O9mBlheNctWuuPaZNG32ySPvH5qs+aHamVSh?=
 =?us-ascii?Q?3QmNNQFeMxegFHx976MdycO8H5Yl9nhZYkIzov4tZG6RkgqzEbfbpvR6WiSp?=
 =?us-ascii?Q?u7yS+P1Yrjz88MiEDW/T16oFpDcWUrPUTmHbXTGPsenvLedCXmPwDtqF2xMW?=
 =?us-ascii?Q?O3cVLrVDxhFtXFPVNO69/JQ0nsFFD7rWKG9UcHBN7hBMS6HJh5R4mLoCiZzW?=
 =?us-ascii?Q?b3UFn1+0NoClF/nqxKxuVuOK8NPxamCv/8A32YnuTd+lA6I2Tx1iF3d0/XIu?=
 =?us-ascii?Q?vnc1LIoMsNdHxIRkb+6g3chz4SSiRXPULGLwa55gspxo2qEm8SxmJ6+eieXB?=
 =?us-ascii?Q?YptHvl2FyMTcIgMdfuanLfhA3Y+nHZOnZarpBFA36V6Ly22BhqvmYxpMzi2H?=
 =?us-ascii?Q?NbC7nDk3d1d4dSsHnwX9o5smr+WaK/JYrNHB/nZWs9W3gAgFzcPpaif6gc+U?=
 =?us-ascii?Q?p82h4GFs5ZUv3nWHvX3QdPJ+gidb5vl21ziizXhyCcaG8H3q3VBDwzacnxlb?=
 =?us-ascii?Q?lmIgEqi2aq0O98s95wThBgE68KjAdGDhnTJidX9BXW/8plduLKfvzmPYw5FL?=
 =?us-ascii?Q?G5IttxL+wILKKNhAKux7jqUMJIWnR+w82t3dJVHvEK0aGdT4rVrKx1BS37a+?=
 =?us-ascii?Q?VQLgCaCaUyyJYK2Cr04UjT9i7BNb1pdYkAZc7shHh8fq3FgJJ9cLsJqfUR2F?=
 =?us-ascii?Q?2t0NwxwVK89wAUkyecE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13a760a4-e727-4b08-0302-08dc641c46ea
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2024 05:06:19.1274
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HDSQEgNkAFv3KLyZyDQlZimMSz7qPKqzookldZNnxaXHaWw9vZxHk0NkTHt/onSVaXnaj/Xuvbk+xos66sDd2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4572
X-Proofpoint-GUID: ma00HWd632RIxPpFC2-MV7z1-jjKEeH5
X-Proofpoint-ORIG-GUID: ma00HWd632RIxPpFC2-MV7z1-jjKEeH5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-24_02,2024-04-23_02,2023-05-22_02

See inline,

> To avoid the failure of usbnet_get_endpoints(), we should check the retur=
n
> value of the usbnet_get_endpoints().
>=20
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/net/usb/ax88179_178a.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/usb/ax88179_178a.c
> b/drivers/net/usb/ax88179_178a.c index 752f821a1990..cf8d19584725
> 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1288,7 +1288,9 @@ static int ax88179_bind(struct usbnet *dev, struct
> usb_interface *intf)  {
>  	struct ax88179_data *ax179_data;
>=20
> -	usbnet_get_endpoints(dev, intf);
> +	ret =3D usbnet_get_endpoints(dev, intf);
> +	if (ret < 0)
> +		return ret;

Don't we need to declare "ret" variable. Did you compiled  this patch befor=
e submitting.
Thanks,
Hariprasad k
>=20
>  	ax179_data =3D kzalloc(sizeof(*ax179_data), GFP_KERNEL);
>  	if (!ax179_data)
> --
> 2.37.2
>=20