Received-SPF: pass (google.com: domain of linux-kernel+bounces-156339-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7ae09b97-70d6-4613-bc1c-b58f09f24531@amlogic.com>
Date: Wed, 24 Apr 2024 14:02:03 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson
 A1 pwm
Content-Language: en-US
To: Jerome Brunet <jbrunet@baylibre.com>, Conor Dooley <conor@kernel.org>
Cc: George Stark <gnstark@salutedevices.com>, u.kleine-koenig@pengutronix.de,
 neil.armstrong@linaro.org, khilman@baylibre.com,
 martin.blumenstingl@googlemail.com, thierry.reding@gmail.com,
 hkallweit1@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
 linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, kernel@salutedevices.com,
 Dmitry Rokosov <ddrokosov@salutedevices.com>,
 "junyi.zhao" <junyi.zhao@amlogic.com>
References: <20240423161006.2522351-1-gnstark@salutedevices.com>
 <20240423161006.2522351-2-gnstark@salutedevices.com>
 <20240423-wildcard-smoking-90b50f00da50@spud>
 <1jr0ewezvc.fsf@starbuckisacylon.baylibre.com>
From: Kelvin Zhang <kelvin.zhang@amlogic.com>
In-Reply-To: <1jr0ewezvc.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nk1ZNDh4WjVEempxN0hKdUZMWlU5TW5SU2lRM2dhek5Jd3hLVWZtWkFibXNt?=
 =?utf-8?B?aWpwaVJ5QjdvNG4wRllkZ3BwTVZBUlI0WG5xM3hIWjVhUm43d3R6WkJVQVp3?=
 =?utf-8?B?TVNZWlRJQld2NEdvZDZKa1JkNWE1cXVLTmJTZlk5TjNUMkRNVG5kcWs4QnNl?=
 =?utf-8?B?Wi9MQlBMVndjb015N0dHeVhBRjI5MlgvRFd2S3VJQ3ByN1JPN29RQUd2QnJG?=
 =?utf-8?B?VU9nckwxZCtkTWNXVWpKV3MyRzBlM0NDVEFGRk1Xb05NMHRjT2hDTFNFVGls?=
 =?utf-8?B?WjAxaUFPekI4UCs5NGVrc2ExZlF0VmZPQUVPMmlVREptTXBZWEdtMWJibEhN?=
 =?utf-8?B?SXNSbUtVc3d5R3VjK3JDdzNNeE45VUZwSHhuajlKK3NXakZ0a04xOGNjYmla?=
 =?utf-8?B?ZUxtUzNtV1FnS1FLaWwrajhSY1FvYzlaTHJnUnNGWG1BblltVEsrQW1vdGR1?=
 =?utf-8?B?Y3FZUkxXOTVZWG9XUWxOOGFaT1hXajlGMEVTNjF2aTgwTnZLTzRPQnV1cHNO?=
 =?utf-8?B?QmUrSVArL2VPS1FYWUR1NG9YMVM0NVQ1NzBWbDJuS2Jta0NsV1Y3VHJEMDB6?=
 =?utf-8?B?L0F0aFlnZjlLSWhYaFI3SEgwYkJaY1JuUm5Qd0ltdTRpZDUyRnRFT1RJZ1BU?=
 =?utf-8?B?YVZjOGFJcnBWQkxkUWJhSmJvTlBYM2NEYnFHbWNBNlpzVE81aEd0OWNOek5J?=
 =?utf-8?B?TGMxVmx3S3lIUzZnOWtwYlRGaUU4eG42clF0TWtZWmJLazhMMGxVS3d0RHZM?=
 =?utf-8?B?OTI3UVRhMjRiREF4bGhlSEZROExzM1N3NVRmVm54WnlXT3ROUlNsK2lzN0Nr?=
 =?utf-8?B?eUIvanp1UkNRTkZkTVNlS3dodlNURndXUERVWXVocG54OVczcWFkR0NCejhX?=
 =?utf-8?B?UjBwQytyeitLM0xJdVlaQnQrOHZxMzJVMDNFV0k5YlhydDMzU3l1aG5XeUdI?=
 =?utf-8?B?c2hobkdCT3ZvYXlqN3ZOaHV6VVdLSmpUMkNvMmdIYklWdjFvRUQ0Z2hUcHV1?=
 =?utf-8?B?ellPK21kUFoyWWwrYm5rQWRwNGJBNkV6V3k5SFNzSVNWdXEvOHU2dkdsZkw2?=
 =?utf-8?B?VGZrcEI2dVZMdEVtNnhUYjRwclI4Ty85T01iS3ZHOGcwRFBhZUpQdS9yK1FE?=
 =?utf-8?B?QUkzZGR4RmZRTEJESDU3TlJHNmhGbGpVZFdMK0ZWYmxpaXc2TStLd0o5bXlM?=
 =?utf-8?B?Ui9CTlRzZkhkY1dkMlVEdEZmTTk0UFNtcEtWM2ZwSHhtR0IzditIOUNJTjVu?=
 =?utf-8?B?N3VHK3NnT2VrenBwaFRNdktBTDRBSlpPSG5TdERTOVViLzhSclNrN0pGbmdI?=
 =?utf-8?B?WkdDTFAzOFd4VWh1NElCa2RuT1BRNXg4MXVNcjB4MTV6ZnpyQVk3aTdnOUEy?=
 =?utf-8?B?Z3dCN3RFVTBRWDg0aVdtWE1CeHl0cTRpWlJERHVyalRKOGFUY0RZNUthSy9o?=
 =?utf-8?B?N3pwa2tRQWVjTURhT2YvM1F3RlJUclBpNFpwRWtEVXRRbGlPOFgxcng0d0px?=
 =?utf-8?B?TXJBb3VzVkszOERHNVNtYUtaZU5QSTR1bEJGc0VEMk9YN0Z6ZlptVm9Ka0Ev?=
 =?utf-8?B?SHRBRWxnMW9aSmlvYlZYaVNrNUpETXEyaTBFWlRDUmx5TUNRcE1mMmtzYm5M?=
 =?utf-8?B?cHJQNUZiS2pwbW43WGdYYytrR0gzSzhGWjZ1eDU0eVV6dFJHcGdDMlNVVytY?=
 =?utf-8?B?TzhzMHNrbkhoSXZzbnlNWDVkWkM5L1U1SU5ZT2ZteURzUUlWS004dFA5UjMy?=
 =?utf-8?B?YVY1S282a0RLRERIdTZuT0VmNXIrOE9UZDRPNzlLRjdoMjNGUzFZTzBOTjVF?=
 =?utf-8?B?dkVwdFpkWnlSY1ZvT0dZWmt6VzRqbkRuMkFoRFcyTVlQZW5uTzJyemlSTWFk?=
 =?utf-8?B?ajk4K3RxQXVpUjVXbVYzSUtFNkwxMUQwVjQwRUFuSVVwajhWbmRPeWM3cDFq?=
 =?utf-8?B?QWNRTGFFOGtLWHdTcHMyTjhpWXhVS2lpVmNiSUQ4b0V1Zys4NmR5Y3hva01W?=
 =?utf-8?B?THNiTlpwZDFGSDNnQmdFU2w2SXZTdVlKUnpVTmNycEY4TDZIcnlyQUQ1RjJU?=
 =?utf-8?B?Z0xMaXhydy9lTyt4U0dYNGdDa2RVbTA4U2RKSUJsalFOR0YrNGhycUd4aGww?=
 =?utf-8?B?MjFLekxqbnA2U21LQW1tUW1BMHZvMUxldGdST3lRbjZwMUpDOS9Bbkg3d29J?=
 =?utf-8?B?Wmc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6e3076-5d04-4489-8f94-08dc642413fc
X-MS-Exchange-CrossTenant-AuthSource: TYSPR03MB7387.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 06:02:09.7620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /XCrhJnQ8/NMgcAGrwn/ZcSIc+Wge1WX9ZkHfr8aoqiw2c6QqS/rw01ca1hZLUvQfB/FYeHMyoz7ah7IEIJ6LWDK45O1kRDNPJVXaW9v5c0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB8134


On 2024/4/24 01:44, Jerome Brunet wrote:
> 
> On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote:
> 
>> [[PGP Signed Part:Undecided]]
>> On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote:
>>> The chip has 3 dual channel PWM modules AB, CD, EF.
>>>
>>> Signed-off-by: George Stark <gnstark@salutedevices.com>
>>> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
>>
>> a would sort before s.
>>
>> With the re-order,
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> Thanks,
>> Conor.
>>
>>> ---
>>>   Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>> index 1d71d4f8f328..ef6daf1760ff 100644
>>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>> @@ -37,6 +37,7 @@ properties:
>>>         - enum:
>>>             - amlogic,meson8-pwm-v2
>>>             - amlogic,meson-s4-pwm
>>> +          - amlogic,meson-a1-pwm
> 
> AFAICT, the a1 interface is exactly as the s4 interface.
> So a1 should list s4 as a fallback and the driver should match on the s4.

Hi George,
For your information, we are preparing S4 submission.
Thanks!

> 
>>>         - items:
>>>             - enum:
>>>                 - amlogic,meson8b-pwm-v2
>>> @@ -126,6 +127,7 @@ allOf:
>>>             contains:
>>>               enum:
>>>                 - amlogic,meson-s4-pwm
>>> +              - amlogic,meson-a1-pwm
>>>       then:
>>>         properties:
>>>           clocks:
>>> --
>>> 2.25.1
>>>
>>
>> [[End of PGP Signed Part]]
> 
> 
> --
> Jerome
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic