Received-SPF: pass (google.com: domain of linux-kernel+bounces-156450-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Apr 2024 09:13:23 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: George Stark <gnstark@salutedevices.com>
Cc: neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, 
	martin.blumenstingl@googlemail.com, thierry.reding@gmail.com, hkallweit1@gmail.com, 
	linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@salutedevices.com, 
	Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: Re: [PATCH 2/2] pwm: meson: add check for error from clk_round_rate()
Message-ID: <egrt5wtiulo7ovnxkgyxaaopyfbwsnmy6ire26vukj6kyaiuki@gkzflkoxmjwb>
References: <20240423161356.2522636-1-gnstark@salutedevices.com>
 <20240423161356.2522636-3-gnstark@salutedevices.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qnio7x5dn2l5fiqc"
Content-Disposition: inline
In-Reply-To: <20240423161356.2522636-3-gnstark@salutedevices.com>


--qnio7x5dn2l5fiqc
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Apr 23, 2024 at 07:13:56PM +0300, George Stark wrote:
> clk_round_rate() can return not only zero if requested frequency can not
> be provided but also negative error code so add check for it too.
>=20
> Fixes: 329db102a26d ("pwm: meson: make full use of common clock framework=
")
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> ---
>  drivers/pwm/pwm-meson.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index ebe76298f6e2..52604635b31e 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -168,9 +168,10 @@ static int meson_pwm_calc(struct pwm_chip *chip, str=
uct pwm_device *pwm,
>  		freq =3D ULONG_MAX;
> =20
>  	fin_freq =3D clk_round_rate(channel->clk, freq);
> -	if (fin_freq =3D=3D 0) {
> -		dev_err(pwmchip_parent(chip), "invalid source clock frequency\n");
> -		return -EINVAL;
> +	if (fin_freq <=3D 0) {

fin_freq is an unsigned long, so your change doesn't have the intended
effect.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--qnio7x5dn2l5fiqc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYosRIACgkQj4D7WH0S
/k777wf/YOQM3/Dxt9O6SoVOz6MFbrovsT52w/n56bi6J1XQp845Y2b4HfQKqObS
ZKMnklknnVoOSRAJyuPtD3asa/pnZjZMTNzFomshqjlMGZGH7L8iXrpbbcxYegG2
t028M81HcjNPNLcYobkNJIaBGz4/XyIL0RtkoIb6KC/jtNWo7l1vmgoNos9i7ooD
Z9omjRL7BUfu7Df78FL/fTBBSKTiNB6Qez1TrvQusNWFquJGJ1EoZXgIK8KXKvua
qC8nZE3AOGp3aPIDtOxM98b729+2lCpIv2I2TLxxcnBXTMxzHaEfCtQckFxa9TNW
PgTEnXpzsCjbu0YPeDDXFB4kQWyhjQ==
=opt7
-----END PGP SIGNATURE-----

--qnio7x5dn2l5fiqc--