Received: by 2002:a05:7208:1509:b0:82:bbfa:f723 with SMTP id o9csp227135rbf; Wed, 24 Apr 2024 00:17:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVOOUG8ARgXUx0ZsuX/pPUqXOea4n57aeLYnJrmH5g9ezVMu1KTLzYJCRMgKkA35p7uHexBsgDTGDxE+Z/J4YMLdiAGyRKyuygY2lOKCQ== X-Google-Smtp-Source: AGHT+IGjIvnPf27eTuZLzCMIfsWwwMG7+78BRKaAdXrTMBcK9d1oZRvJorykaI7LPMRymCdq1JYG X-Received: by 2002:ad4:5283:0:b0:6a0:810b:327f with SMTP id v3-20020ad45283000000b006a0810b327fmr1606577qvr.41.1713943051525; Wed, 24 Apr 2024 00:17:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713943051; cv=pass; d=google.com; s=arc-20160816; b=nkq81n1m+ivgSPFDbCTNV9s8WSi7kpolSIibzvA0U49dUV6u44Y+ar3pfwkT2gHq8M gwiR0trop7+BXG5PdYxj+3o157Q1WVxtDFhM7Ix2Y7IfATcyybC9smJgalSmRkuyZpzK Hn6sCqYwrTmQNMt4fg7z7VgyZ32R1EYpCAB4VIGiKBGZNnUze4neklv8aZD2GmGy4E9b nXbeb+cp10jTtCUfKP6+TWIqqVTNeigGyJkTCAolMsWYtPe51O3wNxj1IOYUrP+SkvjO 0R11Tr8xKWX7L4LpSi+9RpbnUVtxk7lbyV/jrHjqCW0A8hvZzI8NfTpBAYm4nbPBi0PH wStg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=9iaYIAZiKliqY/TEMeW9+sVZsOPyKdm6944m3JCdN9c=; fh=O3/qYM+C5nXGaiD1Oyz5h+ZP4SefvhZ5HReBw56kpmY=; b=auDH6MDw7WpzEKnzWUPCG1fXuO0pBxm82pgpKiQcQckb2dXhPIgQhGY7KfHB5yeizu tDENVPTvGDgkNrHnh4yHYs1rLyymU8EjTNQWs6YOzbPfN7eUF6moE6jOJhMFD8wF/fXd UhiL5JR2cIdPHTNWPCaynl/Df00UvluPrRYKGQwhobMMnWcX4Nqt5FValeXBsSEnCx7X u1gH6ADOPE3Z6F3GewNCwYRcZeqUzZZD5jgMDVdviSM7fRYsQUU6/V1TAPQfDbgxlgEF XeCdnARHzJthbJLsNcxpGvHy/2LEPBeWvyRU1DskVQFGj+13AE1PrFMsGN7W7n+stxA2 OEcw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=USIrOMjN; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-156454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156454-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id pn7-20020a056214130700b0069b7d811b24si14405920qvb.234.2024.04.24.00.17.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 00:17:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=USIrOMjN; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-156454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156454-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 40DA51C22A60 for ; Wed, 24 Apr 2024 07:17:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F34BF157A7C; Wed, 24 Apr 2024 07:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="USIrOMjN" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C8E360 for ; Wed, 24 Apr 2024 07:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713943040; cv=none; b=WGH4EEYOnBTF3uVFm96YFMW9TopXut0rVay+fcVY6OxD/RHNEY8R8d742Lb/mh/kKWJa7Z+D1a0JWTaKGQVFS5fs+s8fe8sYuaWydJwchAS8sY0Iz713101T8cXUji+A0DaZSBkeB+1yllKOkK1kSfvRgG23lVfW0PGyVEijy/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713943040; c=relaxed/simple; bh=AmULsBhF22qDpm7U3r8KmtqTPqh7ExmO7/k6ZU7Ywq8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I4KjjWd3rdm8tlWAeJEd6QzpcpwL+0ez5V+6GWhJEbdWY3ZljRDN12ct16xEXYV0wT3JypS0ne4bamZe0ylBla9w9OUFYEH1Wol45QgTDgBnUQ1UF16Bdw1ZMvXTptFNN0Bqhnn7hVHjoY0dI/uqcTgoiyUFFIZDO9Z4qKM/vos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=USIrOMjN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713943037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9iaYIAZiKliqY/TEMeW9+sVZsOPyKdm6944m3JCdN9c=; b=USIrOMjN78HVtp/L8KceRL13bIVoayo1NxwslaK5oFaBfGomlnOZsvsy83Q/MPx/NGuPY0 N6/kPfpcdE0KkZ5ohqNx8WNNQro37nuhZI4f7JHep1ro4Q5Mz/KEpOocMPeCSJzNwZxOkZ MtFlEFR0FWPBOczZWu9qeyRLZmgy0Zk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-Seqk0RwrMkKsS4SZdAKKKw-1; Wed, 24 Apr 2024 03:17:16 -0400 X-MC-Unique: Seqk0RwrMkKsS4SZdAKKKw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-418f8271081so26412315e9.3 for ; Wed, 24 Apr 2024 00:17:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713943035; x=1714547835; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9iaYIAZiKliqY/TEMeW9+sVZsOPyKdm6944m3JCdN9c=; b=vP3vOG+hWMJ/V5gTv8pFYMo4vltM9kcZJJu5zKtfsZLZ9cDDl0YGZMmij8GijB+YtU +3IoEwvecTy/IV5bnU/SrRK3AOTM5u1L4iKz4UGj5GzMbvPanDsn6qmHm+szi3WXSuRY 42z7NTZy9XvMkHasJCWw80wE6IaktTq218r/FZRpTD4qdOVBEXABy0/V7+Rbzvjz/BqZ 6iyitiyYZVvZ0Q6ljlWxQtwjW0LcSMiBteZBispTpiW/THtUojlslUQhycvSR6qNLHPX oUD6rRmkituZhqsCy4lfWVN1nFey8mCNgJC2YfWIi/eV8HZEi9GTnwqIoWT9VM/dwzom zqxQ== X-Forwarded-Encrypted: i=1; AJvYcCX/kEAr0H+3PKjxxeVlzqbVSiFW2Miw8TSppSQ+JXZQwIgGFw9HJEzegOMIb3bAMsvTg3YhBZ3nuZ1Uq+k2TQ02IQwVuk0Yaj5aaEWW X-Gm-Message-State: AOJu0YzYlMx8MmjaEapMoDq90M7OYm3fXSCKSXPnnlnO2mFE7ae2lT6p frNVaQOYbUjD/fx1T0bGYkOOX6Wi0SP62Rl4ACKkADpFT+aKplgQr+y+zbHFMoG3SU7dgYIArAl KaGHspQw6y2l4ZaYhes8PN+xVgRH4OxlkjaUBDwCuRq9QYOBoDTZaoDOe0E9dwQ== X-Received: by 2002:a05:600c:3b14:b0:418:a985:3ca with SMTP id m20-20020a05600c3b1400b00418a98503camr1747517wms.31.1713943034987; Wed, 24 Apr 2024 00:17:14 -0700 (PDT) X-Received: by 2002:a05:600c:3b14:b0:418:a985:3ca with SMTP id m20-20020a05600c3b1400b00418a98503camr1747483wms.31.1713943034592; Wed, 24 Apr 2024 00:17:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id fm13-20020a05600c0c0d00b0041b0ade42b1sm731364wmb.7.2024.04.24.00.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 00:17:14 -0700 (PDT) Message-ID: <1a0ca018-8ad3-42b0-b98a-8e6b6862fc7a@redhat.com> Date: Wed, 24 Apr 2024 09:17:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list() To: Matthew Wilcox , Lance Yang Cc: akpm@linux-foundation.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240422055213.60231-1-ioworker0@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24.04.24 06:15, Matthew Wilcox wrote: > On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote: >> When the user no longer requires the pages, they would use >> madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would not >> typically rewrite to the given range. >> >> At present, PMD-mapped THPs that are marked as lazyfree during >> shrink_folio_list() are unconditionally split, which may be unnecessary. >> If the THP is clean, its PMD is also clean, and there are no unexpected >> references, then we can attempt to remove the PMD mapping from it. This >> change will improve the efficiency of memory reclamation in this case. > > Does this happen outside of benchmarks? I'm really struggling to see > how we end up in this situation. We have a clean THP without swap > backing, so it's full of zeroes, but for some reason we haven't used the > shared huge zero page? What is going on? It's not full of zeroes. User space called MADV_FREE on a PMD-mapped THP. During MADV_FREE, we mark the PTEs as clean, the folio as clean and sd "lazyfree" (no swap backend). If, during memory reclaim, we detect that (a) the folio is still clean (b) the PTEs are still clean and (c) there are no unexpected references (GUP), user space didn't re-write to that memory again, so we can just discard the memory "lazily". -- Cheers, David / dhildenb