Received-SPF: pass (google.com: domain of linux-kernel+bounces-156475-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 24 Apr 2024 09:19:34 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: George Stark <gnstark@salutedevices.com>
Cc: neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, 
	martin.blumenstingl@googlemail.com, thierry.reding@gmail.com, hkallweit1@gmail.com, 
	linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@salutedevices.com, 
	Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: Re: [PATCH 1/2] pwm: meson: drop unneeded check in get_state callback
Message-ID: <wkn6ybnnlco7vrqbpclfxaajt5cvywpr633au7qcr6vpjihabq@kb7q6y4khh2k>
References: <20240423161356.2522636-1-gnstark@salutedevices.com>
 <20240423161356.2522636-2-gnstark@salutedevices.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3xwbvuajde4meb2t"
Content-Disposition: inline
In-Reply-To: <20240423161356.2522636-2-gnstark@salutedevices.com>


--3xwbvuajde4meb2t
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello George,

On Tue, Apr 23, 2024 at 07:13:55PM +0300, George Stark wrote:
> Drop checking state argument for null pointer in meson_pwm_get_state()
> due to it is called only from pwm core with always valid arguments.
>=20
> Fixes: 211ed630753d ("pwm: Add support for Meson PWM Controller")
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>

I'd apply this one with the following changes if you agree:

 - capitalize "drop" in the Subject line
 - s/get_state/.get_state()/
 - make "null" all caps (i.e. "NULL")
 - swap the order of Signed-off-by lines to have yours last.

Alternatively send it in a v2 together with addressing the comment in
the second patch.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--3xwbvuajde4meb2t
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYosoUACgkQj4D7WH0S
/k7G1gf+PGBuQXOKBKGgHuOhdu/hGX+YqKlLX7bGKVF4a/6Hj5zjVxP2W2WeOd42
o5lwOx0Aby2qxA2/greyP1XODpf86xX9J5CPuk0h9haNt10XVsLP+tzX0bpgorYY
ltKCskC3VzFM4L+l7tiSF+8478kLzjpzwKR/lg1jr6ib5IH8g/riSNpJekMstrK6
FUnzSKBW1r01wv8T7OW+cy3f35ygttE//Bii1OSiEGqU/gtouoEtoy2AKZrIwCuP
C28ArBOOsUmbVTW/0U9g7wakmNlxaLVqC8kJPVrG4cz5ndaDczWjQV02MlbvrkO/
XaP6LMwi1REygGrxkME/m1VxDaxEVQ==
=gKa2
-----END PGP SIGNATURE-----

--3xwbvuajde4meb2t--