Received-SPF: pass (google.com: domain of linux-kernel+bounces-156480-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a922af6e-7b57-4802-809d-72d36c0b468f@intel.com>
Date: Wed, 24 Apr 2024 12:51:40 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH CI 1/3] drm/xe: Store xe_he_engine in
 xe_hw_engine_snapshot
To: =?UTF-8?Q?Jos=C3=A9_Roberto_de_Souza?= <jose.souza@intel.com>,
	<linux-kernel@vger.kernel.org>, <intel-xe@lists.freedesktop.org>
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>, Matt Roper
	<matthew.d.roper@intel.com>, Zhanjun Dong <zhanjun.dong@intel.com>
References: <20240423160626.77110-1-jose.souza@intel.com>
Content-Language: en-US
From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
In-Reply-To: <20240423160626.77110-1-jose.souza@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDFBZFl4cUZJQW92dGlBUXRlNWRQczdlcUdmRnh2c1o1bGVpZEdONklVSXdD?=
 =?utf-8?B?Z1VZc3Z1bHNUMzdiVTkyN0tBUkRJRVNpMHNhTyswK1VYVTQ5TTNLekgrdXA1?=
 =?utf-8?B?cHRjM3k2cG9QNmFJMHdtZ2xrZEtPTDdwSWM2ck1xQXVDalRtSHpxNWRHWG55?=
 =?utf-8?B?eWZYcTIzZ1FBM2NJN1FSZm5sem5sYnZOZVhWcTVpYWw1R3dyTGxBbTF1WHdZ?=
 =?utf-8?B?S0U4RXRaOUNaQ0hWVlErNTVmcDRCL2dmR2JxdzNLVXJSRU9TYnY5OVh4TGN0?=
 =?utf-8?B?cUJDTEJjbWJmbytrTlRwOEVUTW9XclMrVk5vYzJuOXJiVzkzdmpBS0hTV0Zp?=
 =?utf-8?B?bldSSGZyMGRpSXg1QklqcmJKK1N6bEJGWXVjRFBWQlBzM3RsMi9NeGJOK3Zl?=
 =?utf-8?B?OEg4TWVhSWZTdzRTY0Z6TjExNFF1cTlJRjNKU1NwT1d6VEsxN0g5NHRXdDJq?=
 =?utf-8?B?Q3lXa1JEQUMzTk4vZWJjV0YwbzlBWEFER2I4VGVuUjRoeExXSHhBT0dNbzlY?=
 =?utf-8?B?Y0h2ZWVMWjlBZGNNWGlDSXZvNUh2azRjWkk3V0xxaGpyeUJ4ZU1EVkJnTHpn?=
 =?utf-8?B?UmZ1dGdPTWN0YWo1NkxQSkpoUEJHWXc4MTZPQU1jT29PWE00VGswd0d4VVQ5?=
 =?utf-8?B?cXJUc2Q3OVNZRlpDdnV6NEs4bVY4RGVsRkVoV2hpTWxkb3hTWkNkYzI4dUlU?=
 =?utf-8?B?RGFuMzg5YXRKQ2x1ZHB1WGRqY2FRUXR3WXlvaGYzb3RhWGU0YzY3Q3QwZjJQ?=
 =?utf-8?B?RVV2U2srcmpJMEs3a01nYWtveG8rdFhBSU5Dd0lVKzlMc05CMGM1WVFGM2xv?=
 =?utf-8?B?a0ZmR3htUTRhUWZ6dzIvUmc0cjA1V0NONmlHdHRDK1E4SDhpdEIrc09vSUJy?=
 =?utf-8?B?dURuT2trWGk4bHFUOGNpYVlRUlE0VllQVUg5WnpKam4yMlpZQTFjSWd0dG8x?=
 =?utf-8?B?cGRCUEFhamVLdE5yK0tlVmFQNkJWVEw0dHZqQlhvYUp6ZkF4dlhnRFNYY09N?=
 =?utf-8?B?a2t1N2NGOWJWeTVEUWpNT3YycUxaQ2ROWGdEeFUrcDR3TjRTTzhTbmwzMjkv?=
 =?utf-8?B?R2VNbllNckptaXM2TnZnKytxM2ppM1orenZWUHJ0UzQxd05CcGZVZTVaZ2hs?=
 =?utf-8?B?YmNUZ0hLVVFxTFFreHlyMkRSU3V4ZU1WNVRRZjRPV2RLRFdjcCtqUFE3UFNE?=
 =?utf-8?B?YWhURGc3OFFXeGprUDluVCtsR2pOTlJqR0pqSUFuOFRMNk5Lc2ZaNVQ3RWtF?=
 =?utf-8?B?YlhIdUZPM1l2UlVjbTg0UmdWckZhSTkxNE9RamtEampGcDgxYWZMVjdFTGVE?=
 =?utf-8?B?UEJQVm92NU8vMW9hTlVmMTFxUmdHU1I1VFJEMzA1OEgvWklMZEk5cU9Hb0FE?=
 =?utf-8?B?elByS05xK0FmWDBRQW5uY1B4a0FhR3ltSkpUMC9lTGY1aDF2MFRRYVBJWGNv?=
 =?utf-8?B?TW9yWFk3U05aNFdSTXhmcEpYUUQrdE5UNEZ4S0gwK2w1TTFPdEx3TnM0WnRt?=
 =?utf-8?B?bUh2Y2ppYU03SVp2TnVnWk5sd0JvSnNPSXh2TDdOMmcyNU1UY3hINE1yYytG?=
 =?utf-8?B?OWMwRDRpbGV5R2c4MkI2QVptZUN4NUNBUUVjTURmWUxrREdIV0ZnSVhWb2I3?=
 =?utf-8?B?VE8rN3h6ZXZKdDZjWGcvWGlxeXN6RXNOSzVMd3BQNGRUZi8zMUJZK3VDUUd2?=
 =?utf-8?B?MC80NUhaelh6ZTVKci9VcXphczY4bndoUHhTRXczTVFvM3hYMTZ4YXlhcjBp?=
 =?utf-8?B?NkptbEFaVVM1bmxKZWZ6aEUrZGtFcTE3YTFpd3c1dGc0NngzNkhad3BCTGcz?=
 =?utf-8?B?K3VCYmNxck53VWQydTdQTVBHZDVGRENoTTJpZmdNZCtoUXVteUNGckJScHJx?=
 =?utf-8?B?dkxHRjQ5bGY2RlBCeksyK1ZhMmlqMnRQelgwU1lQOGkyeHFrRm1tU2Nlbkx1?=
 =?utf-8?B?cVpPTUk4WkpHdWw4SlBPbjVuWW1XS1pHRGUzZGYvdUpUWXVYaXdSbjR0WGRl?=
 =?utf-8?B?ZjFKWU5mNFZkNGJzbHJPKzNob3V5ak5pWUQvM0hjZ08rUGRHQ3dJTWZoZTlO?=
 =?utf-8?B?L0JLeEF0bk1nd1dKQTEvbkRDNmZid1VjSi9CUUdtWTZjQnVzcEh5d0tSUG9X?=
 =?utf-8?B?MHBZT1pJWjF1UDZlWVJ6MkdEYys2bEFGQmFBRVRzOURYN21jMFhWSEhBWGRP?=
 =?utf-8?B?eHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac8d340-234f-47fa-8876-08dc642f33b5
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7056.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 07:21:47.6542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jPTPqbSLJbW9iAVzYiItKUKFKok4BItgdOEoYy03Wchgn8LlKCYg7r8QyKeX92KahtzjWvJIjPqWpdwoOOT45+EJ/VQlkdGjncaGRFho+4g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7621
X-OriginatorOrg: intel.com

Typo in commit.

s/xe_he_engine/xe_hw_engine

On 23-04-2024 21:35, José Roberto de Souza wrote:
> A future patch will require gt and xe device structs, so here
> replacing class by hwe.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Zhanjun Dong <zhanjun.dong@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_hw_engine.c       | 6 +++---
>   drivers/gpu/drm/xe/xe_hw_engine_types.h | 4 ++--
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index 455f375c1cbd6..c84dbe8a8ed1d 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -791,7 +791,7 @@ xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe)
>   		return NULL;
>   
>   	snapshot->name = kstrdup(hwe->name, GFP_ATOMIC);
> -	snapshot->class = hwe->class;
> +	snapshot->hwe = hwe;
>   	snapshot->logical_instance = hwe->logical_instance;
>   	snapshot->forcewake.domain = hwe->domain;
>   	snapshot->forcewake.ref = xe_force_wake_ref(gt_to_fw(hwe->gt),
> @@ -842,7 +842,7 @@ xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe)
>   	snapshot->reg.ring_eir = hw_engine_mmio_read32(hwe, RING_EIR(0));
>   	snapshot->reg.ipehr = hw_engine_mmio_read32(hwe, RING_IPEHR(0));
>   
> -	if (snapshot->class == XE_ENGINE_CLASS_COMPUTE)
> +	if (snapshot->hwe->class == XE_ENGINE_CLASS_COMPUTE)
>   		snapshot->reg.rcu_mode = xe_mmio_read32(hwe->gt, RCU_MODE);
>   
>   	return snapshot;
> @@ -887,7 +887,7 @@ void xe_hw_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot,
>   	drm_printf(p, "\tBBADDR: 0x%016llx\n", snapshot->reg.ring_bbaddr);
>   	drm_printf(p, "\tDMA_FADDR: 0x%016llx\n", snapshot->reg.ring_dma_fadd);
>   	drm_printf(p, "\tIPEHR: 0x%08x\n", snapshot->reg.ipehr);
> -	if (snapshot->class == XE_ENGINE_CLASS_COMPUTE)
> +	if (snapshot->hwe->class == XE_ENGINE_CLASS_COMPUTE)
>   		drm_printf(p, "\tRCU_MODE: 0x%08x\n",
>   			   snapshot->reg.rcu_mode);
>   }
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_types.h b/drivers/gpu/drm/xe/xe_hw_engine_types.h
> index d7f828c76cc5f..27deaa31efd31 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_types.h
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_types.h
> @@ -158,8 +158,8 @@ struct xe_hw_engine {
>   struct xe_hw_engine_snapshot {
>   	/** @name: name of the hw engine */
>   	char *name;
> -	/** @class: class of this hw engine */
> -	enum xe_engine_class class;
> +	/** @hwe: hw engine */
> +	struct xe_hw_engine *hwe;
>   	/** @logical_instance: logical instance of this hw engine */
>   	u16 logical_instance;
>   	/** @forcewake: Force Wake information snapshot */