Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp247489lqd; Wed, 24 Apr 2024 00:28:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXUzuH/a1gwoLE/M1+jx+5zt68i0IKWWfHS204C4KjBYAxUDVzl4BpZnus4RuqcsgZRtsbdo/YuGng8fPivb80V2nweRiej+ln4Z7a5Zw== X-Google-Smtp-Source: AGHT+IF0c5qESfBu3XrzvQ8BMcTQECszZGkD+Xh81Ag2y9xaeTDjNYHi7qOuczNHoq3lv/78n1Xs X-Received: by 2002:a05:620a:12e2:b0:790:8765:876f with SMTP id f2-20020a05620a12e200b007908765876fmr1529504qkl.47.1713943709523; Wed, 24 Apr 2024 00:28:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713943709; cv=pass; d=google.com; s=arc-20160816; b=AEP3wYFi7ll8KXfdJ6hM5giHZz4BeABaBB8pO//5KDDMZGHYexqvJmeGRER23/vHQP XThiUCspmpN89/N3i0wcoii48zzBSytRxp5TY05MhfKkDte/ks2rXn4UuYBj+UVp7uvc P+Seb9gDv7+y5kbwhGAW4oKNo2ax/jiBzznPrjj3DNvioDE4T8Y9OmBi6KAoeZe+1XOp Cb9Gl/2DrV3GGqhqMK+MbB9WUFGnS/TmxDR2MgMIKORSdsEz+qlD5cNwEYeOlVxHTSFO d5vYgUZsoncopdJg8IOyXnUsDb8enQJf8eZW9TrZ/oUbuJD1dzZsuKZgRt6oKMWicsUr dGMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=RELgunHjEruOdWhQvb7HAUAGKHW8EDTQZHeyfFhGB18=; fh=X+YDyvNKP/lQ1fLxtZ3JBYZWEOhAGXwKCpfrUEdVKNw=; b=VIToDpazvvZbPmIniLosFRfjJ24bW3BfhzR7SxzvaCCEaV1A5/pxBy3XnGsLw80DzT luGAU8Sz334aU48d1MpwAaNfXO2vLh9ZjrlAZGJmV1hBSz2lBQ7AWke7auBdSE47IItc 6dAbFegzdXy6FmnP2bvgQ29+I9+1BOlMAyrYzC9LgIgfVeQWgCjmQbsCJ21Hm/8Q7PZc aIq3mzCqryT7V8cMczJM6ppnjgd1M5jJlU3beOfHa05BFgd/I/pmBUt61q5TEDamih+W MLTY/0P6NMHmc47kVDevFVrhUdmX/DLPvz7AbC+9A1my4+DCDkYTXXrtRuRig386QEq1 Nkdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KxUUqjRh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-156488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156488-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w5-20020a05620a094500b007908a02f651si1891777qkw.349.2024.04.24.00.28.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 00:28:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KxUUqjRh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-156488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156488-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 138551C24478 for ; Wed, 24 Apr 2024 07:28:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 734841581E7; Wed, 24 Apr 2024 07:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KxUUqjRh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903F2D29E; Wed, 24 Apr 2024 07:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713943681; cv=none; b=QYAmfEtxoBBsoOgS65xOGqoRof0lSmQ1fMUd88MXaf2ZXt+nYK2TB1VcvR8Wdg9rtK0kmxDa8NGyMUcrThwbS4+oW1QhzYgknXrzVFIFNjwrPHW/70CdALIqef0yV/mBuV0iCbEQ/JiqtvLVxoNU6z+d3vTgLG/jYOiNGsV21C0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713943681; c=relaxed/simple; bh=U+9Jy2HriAOq6JXv5BGv9/GxjLWl2uRiHVloYWp9ZZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tomxKFOgrTlWuRoDjBXBkbtwN9vPaxXbs5H8TC+A6X0CxWeRtXF6Pa2H5s9q5GtIzv49HZUnCQxPR8D7mbFQ43cmvkJft+RyFS7geTPL/rLiAMsyWw/n7MDsFhdx88LVmBP4JuUHU7hm9PfXA1yQcF0AsZ2Qx0D3lFS+l5JB3o8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KxUUqjRh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 100A7C113CE; Wed, 24 Apr 2024 07:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713943681; bh=U+9Jy2HriAOq6JXv5BGv9/GxjLWl2uRiHVloYWp9ZZU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KxUUqjRhBW+OETFzFCjR+bkMsSiWfWuuPcQk3Up9p9/DJtc2Vu/LcHY5lQxenI9E+ ScjKkspowKMEIm0JGDIDY+kc7SpyC4GRwrveXMd3V4VSvz9upW/TcEoeg8fpSj0D0S UEcKiRv9J4Y3d5X6J88+Ia6wBt9+okihtgae9NAb6aSySo1lttI9IOhJ7KrAPvVTuX thKOG3RP39eUAAygVORjrSHj3l+twr+shTdb8Q9OVL7Mbl+S7lBW86+JsTAOpvgG+P h8orAMZAS49pfbfBBl+c5xTo+Pz+q7ZfFUr1B99BWUt+Tmrwwi6YDFQwhQga1sccMn oKi5+/K9+eQPA== Message-ID: <8d69e3dc-97e9-4672-a741-d31daeaf8388@kernel.org> Date: Wed, 24 Apr 2024 10:27:53 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns() To: Dan Carpenter , Roger Quadros Cc: MD Danish Anwar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Jan Kiszka , Diogo Ivo , Rob Herring , Grygorii Strashko , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain> Content-Language: en-US From: Roger Quadros In-Reply-To: <05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/04/2024 19:15, Dan Carpenter wrote: > The rx_chn->irq[] array is unsigned int but it should be signed for the > error handling to work. Also if k3_udma_glue_rx_get_irq() returns zero > then we should return -ENXIO instead of success. > > Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver") > Signed-off-by: Dan Carpenter Reviewed-by: Roger Quadros