Received-SPF: pass (google.com: domain of linux-kernel+bounces-156509-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 24 Apr 2024 09:55:07 +0200
From: Joel Granados <j.granados@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
CC: Konstantin Ryabitsev <konstantin@linuxfoundation.org>, Konrad Dybcio
	<konrad.dybcio@linaro.org>, Luis Chamberlain <mcgrof@kernel.org>,
	<josh@joshtriplett.org>, Kees Cook <keescook@chromium.org>, Eric Biederman
	<ebiederm@xmission.com>, Iurii Zaikin <yzaikin@google.com>, Steven Rostedt
	<rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland
	<mark.rutland@arm.com>, Thomas Gleixner <tglx@linutronix.de>, John Stultz
	<jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>, Andy Lutomirski
	<luto@amacapital.net>, Will Drewry <wad@chromium.org>, Ingo Molnar
	<mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Juri Lelli
	<juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Ben Segall
	<bsegall@google.com>, Mel Gorman <mgorman@suse.de>, Daniel Bristot de
	Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>,
	Petr Mladek <pmladek@suse.com>, John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>, "Naveen N. Rao"
	<naveen.n.rao@linux.ibm.com>, Anil S Keshavamurthy
	<anil.s.keshavamurthy@intel.com>, "David S. Miller" <davem@davemloft.net>,
	Balbir Singh <bsingharora@gmail.com>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, John Fastabend
	<john.fastabend@gmail.com>, Andrii Nakryiko <andrii@kernel.org>, Martin
	KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song
	<yonghong.song@linux.dev>, KP Singh <kpsingh@kernel.org>, Stanislav Fomichev
	<sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
	<linux-kernel@vger.kernel.org>, <kexec@lists.infradead.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-trace-kernel@vger.kernel.org>,
	<bpf@vger.kernel.org>, <tools@kernel.org>
Subject: Re: [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel
 dir
Message-ID: <20240424075507.ggdmj7hg2xihmbq6@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="5scxkb2uvfn4vufj"
Content-Disposition: inline
In-Reply-To: <1804aebc-68a5-4bd8-b42e-e06ce82f7355@kernel.org>
CMS-TYPE: 201P
References: <20240328-jag-sysctl_remove_empty_elem_kernel-v3-0-285d273912fe@samsung.com>
	<36a1ea2f-92c2-4183-a892-00c5b48c419b@linaro.org>
	<311c8b64-be13-4740-a659-3a14cf68774a@kernel.org>
	<20240422-sensible-sambar-of-plenty-ae8afc@lemur>
	<CGME20240422150814eucas1p273f4eedd9082763e57ea53f16e5ac7f1@eucas1p2.samsung.com>
	<1804aebc-68a5-4bd8-b42e-e06ce82f7355@kernel.org>

--5scxkb2uvfn4vufj
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 05:07:59PM +0200, Krzysztof Kozlowski wrote:
> On 22/04/2024 16:57, Konstantin Ryabitsev wrote:
> > On Mon, Apr 22, 2024 at 04:49:27PM +0200, Krzysztof Kozlowski wrote:
> >>>> These commits remove the sentinel element (last empty element) from=
=20
> >>>> the
> >>>> sysctl arrays of all the files under the "kernel/" directory that us=
e a
> >>>> sysctl array for registration. The merging of the preparation patches
> >>>> [1] to mainline allows us to remove sentinel elements without changi=
ng
> >>>> behavior. This is safe because the sysctl registration code
> >>>> (register_sysctl() and friends) use the array size in addition to
> >>>> checking for a sentinel [2].
> >>>
> >>> Hi,
> >>>
> >>> looks like *this* "patch" made it to the sysctl tree [1], breaking b4
> >>> for everyone else (as there's a "--- b4-submit-tracking ---" magic in
> >>> the tree history now) on next-20240422
> >>>
> >>> Please drop it (again, I'm only talking about this empty cover letter=
).
> >>
> >> Just to clarify, in case it is not obvious:
> >> Please *do not merge your own trees* into kernel.org repos. Instead use
> >> b4 shazam to pick up entire patchset, even if it is yours. b4 allows to
> >> merge/apply also the cover letter, if this is your intention.
> >>
> >> With b4 shazam you would get proper Link tags and not break everyone's
> >> b4 workflow on next. :/
> >=20
> > I was expecting this to happen at some point. :/
> >=20
> > Note, that you can still use b4 and merge your own trees, but you need=
=20
> > to switch to using a different cover letter strategy:
> >=20
> >   [b4]
> >   prep-cover-strategy =3D branch-description
>=20
> Yes, but you still won't have:
> 1. Link tags
> 2. Nice thank-you letters
> 3. Auto-collecting review/tested/ack tags
>=20
> So sure, maintainer can even cherry-pick patches, use patch or manually
> edit git objects and then update git refs, but that's not the point. :)
>=20
> Just use b4 shazam, it's so awesome tool.
I'll try this out going forward (instead of chaning the cover letter
strategy)

Thx again.

Best

--=20

Joel Granados

--5scxkb2uvfn4vufj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYoutcACgkQupfNUreW
QU+F2Av/QqbfQttykaAD7KNkB5kok78Ab5AkiiDAM8lFgJvBZN1h8U7IueUGwXBr
n0i2wBPUZRDZ4k2OYMltTAhLdVXGNqAfJDmWChJpxRKSpCh+CNK5l1FImfM7I9Hg
wbAXyzgEJofNgic+s75BLSbyC8SQB/4xHZ8HXD5xV7rT5nyxk6FKTU+1CHM0wcMJ
BRRl0JzlPSkfJ9soQFrr0JMosSK/zJfhqQMT8/lYmMWoJfT8u/X6xSiFfOWl3yKD
T/E/zJphjpNN1RVwFGln4I0AAZ1T3bu211IX05ekhYZepQHgx0bhv6/vsqXp1LbG
TB++mNPYhhW0UA7N8OvJCcZHOxTP/KW3bybjDyVBZilmqzhCeIukm/svXIL3t2zV
+yLZIPGFi3anx0l7TBhlWzuLb4BqjOt9sGuJnnzcb421bXtBDTWo6wbrxjvbqXdr
QVauUByn/c8ZYnJkw6j1VhrY39EXSjkcYOC5Li9L1dXfKwgB3daeQ8ZPn3g8TcNn
Aw0xDsib
=jM5G
-----END PGP SIGNATURE-----

--5scxkb2uvfn4vufj--