Received-SPF: pass (google.com: domain of linux-kernel+bounces-156568-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7ae4a071-56b3-410b-9c95-d6677dc46f25@huawei.com>
Date: Wed, 24 Apr 2024 16:44:27 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next] erofs: modify the error message when
 prepare_ondemand_read failed
Content-Language: en-US
To: Gao Xiang <hsiangkao@linux.alibaba.com>, <xiang@kernel.org>,
	<chao@kernel.org>
CC: <huyue2@coolpad.com>, <jefflexu@linux.alibaba.com>, <dhavale@google.com>,
	linux-erofs mailing list <linux-erofs@lists.ozlabs.org>, LKML
	<linux-kernel@vger.kernel.org>
References: <20240424023945.420828-1-lihongbo22@huawei.com>
 <871467f7-1218-4c13-ae47-13e89bbbe0cc@linux.alibaba.com>
From: Hongbo Li <lihongbo22@huawei.com>
In-Reply-To: <871467f7-1218-4c13-ae47-13e89bbbe0cc@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

ok, thanks!

On 2024/4/24 11:29, Gao Xiang wrote:
> 
> (+cc linux-erofs & LKML)
> 
> On 2024/4/24 10:39, Hongbo Li wrote:
>> When prepare_ondemand_read failed, wrong error message is printed.
>> The prepare_read is also implemented in cachefiles, so we amend it.
>>
>> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> 
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> 
> Could you resend the patch with proper mailing list cced with my
> "reviewed-by:" tag?  So I could apply with "b4" tool.
> 
> Thanks,
> Gao Xiang
> 
>> ---
>>   fs/erofs/fscache.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
>> index 8aff1a724805..62da538d91cb 100644
>> --- a/fs/erofs/fscache.c
>> +++ b/fs/erofs/fscache.c
>> @@ -151,7 +151,7 @@ static int erofs_fscache_read_io_async(struct 
>> fscache_cookie *cookie,
>>           if (WARN_ON(len == 0))
>>               source = NETFS_INVALID_READ;
>>           if (source != NETFS_READ_FROM_CACHE) {
>> -            erofs_err(NULL, "prepare_read failed (source %d)", source);
>> +            erofs_err(NULL, "prepare_ondemand_read failed (source 
>> %d)", source);
>>               return -EIO;
>>           }